linux

iv/linux

History

Masahiro Yamada bf2f1eeed0 s390: add unreachable() to dump_fault_info() to fix -Wmaybe-uninitialized

When CONFIG_OPTIMIZE_INLINING is enabled for s390, I see this warning:

arch/s390/mm/fault.c:127:15: warning: 'asce' may be used uninitialized in this function [-Wmaybe-uninitialized]
  switch (asce & _ASCE_TYPE_MASK) {
arch/s390/mm/fault.c:177:16: note: 'asce' was declared here
  unsigned long asce;
                ^~~~

If get_fault_type() is not inlined, the compiler cannot deduce that
all the possible paths in the 'switch' statement are covered.

Of course, we could mark get_fault_type() as __always_inline to get
back the original behavior, but I do not think it sensible to force
inlining just for the purpose of suppressing the warning. Since this
is just a matter of warning, I want to keep as much room for compiler
optimization as possible.

I added unreachable() to teach the compiler that the 'default' label
is unreachable.

I got rid of the 'inline' marker. Even without the 'inline' hint,
the compiler inlines functions based on its inlining heuristic.

Fixes: 9012d011660e ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

2019-05-28 14:49:21 +02:00

cmm.c

s390/cmm: avoid add_timer on concurrently used timer

2018-07-16 15:45:41 +02:00

dump_pagetables.c

kasan: rename kasan_zero_page to kasan_early_shadow_page

2018-12-28 12:11:43 -08:00

extmem.c

s390/extmem: print DCSS range with %px

2019-02-21 15:57:25 +01:00

fault.c

s390: add unreachable() to dump_fault_info() to fix -Wmaybe-uninitialized