linux/drivers/net/can/rcar
Vincent Mailhol 7d4a101c0b can: dev: add sanity check in can_set_static_ctrlmode()
Previous patch removed can_priv::ctrlmode_static to replace it with
can_get_static_ctrlmode().

A condition sine qua non for this to work is that the controller
static modes should never be set in can_priv::ctrlmode_supported
(c.f. the comment on can_priv::ctrlmode_supported which states that it
is for "options that can be *modified* by netlink"). Also, this
condition is already correctly fulfilled by all existing drivers
which rely on the ctrlmode_static feature.

Nonetheless, we added an extra safeguard in can_set_static_ctrlmode()
to return an error value and to warn the developer who would be
adventurous enough to set to static a given feature that is already
set to supported.

The drivers which rely on the static controller mode are then updated
to check the return value of can_set_static_ctrlmode().

Link: https://lore.kernel.org/all/20211213160226.56219-3-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2022-01-05 12:09:05 +01:00
..
Kconfig can: rcar: drop unneeded ARM dependency 2021-10-24 16:26:04 +02:00
Makefile can: rcar: add SPDX identifiers to Kconfig and Makefile 2018-11-28 16:19:53 +01:00
rcar_can.c can: do not increase tx_bytes statistics for RTR frames 2022-01-05 12:09:05 +01:00
rcar_canfd.c can: dev: add sanity check in can_set_static_ctrlmode() 2022-01-05 12:09:05 +01:00