Vladimir Oltean a50a151e31 net: ipconfig: ic_dev can be NULL in ic_close_devs
ic_close_dev contains a generalization of the logic to not close a
network interface if it's the host port for a DSA switch. This logic is
disguised behind an iteration through the lowers of ic_dev in
ic_close_dev.

When no interface for ipconfig can be found, ic_dev is NULL, and
ic_close_dev:
- dereferences a NULL pointer when assigning selected_dev
- would attempt to search through the lower interfaces of a NULL
  net_device pointer

So we should protect against that case.

The "lower_dev" iterator variable was shortened to "lower" in order to
keep the 80 character limit.

Fixes: f68cbaed67cb ("net: ipconfig: avoid use-after-free in ic_close_devs")
Fixes: 46acf7bdbc72 ("Revert "net: ipv4: handle DSA enabled master network devices"")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-03-22 12:57:51 -07:00
..
2020-03-12 15:55:00 -07:00
2021-01-11 18:20:09 -08:00
2020-11-09 17:50:28 -08:00
2020-11-09 17:50:28 -08:00
2021-01-29 20:59:53 -08:00
2020-12-16 11:01:04 -08:00
2020-03-16 18:26:54 -07:00
2020-12-14 16:40:27 -08:00
2020-03-16 18:26:55 -07:00
2021-03-01 15:32:05 -08:00