Ye Bin
1b6ad24210
jbd2: fix a potential race while discarding reserved buffers after an abort ...
commit 23e3d7f7061f8682c751c46512718f47580ad8f0 upstream.
we got issue as follows:
[ 72.796117] EXT4-fs error (device sda): ext4_journal_check_start:83: comm fallocate: Detected aborted journal
[ 72.826847] EXT4-fs (sda): Remounting filesystem read-only
fallocate: fallocate failed: Read-only file system
[ 74.791830] jbd2_journal_commit_transaction: jh=0xffff9cfefe725d90 bh=0x0000000000000000 end delay
[ 74.793597] ------------[ cut here ]------------
[ 74.794203] kernel BUG at fs/jbd2/transaction.c:2063!
[ 74.794886] invalid opcode: 0000 [#1 ] PREEMPT SMP PTI
[ 74.795533] CPU: 4 PID: 2260 Comm: jbd2/sda-8 Not tainted 5.17.0-rc8-next-20220315-dirty #150
[ 74.798327] RIP: 0010:__jbd2_journal_unfile_buffer+0x3e/0x60
[ 74.801971] RSP: 0018:ffffa828c24a3cb8 EFLAGS: 00010202
[ 74.802694] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[ 74.803601] RDX: 0000000000000001 RSI: ffff9cfefe725d90 RDI: ffff9cfefe725d90
[ 74.804554] RBP: ffff9cfefe725d90 R08: 0000000000000000 R09: ffffa828c24a3b20
[ 74.805471] R10: 0000000000000001 R11: 0000000000000001 R12: ffff9cfefe725d90
[ 74.806385] R13: ffff9cfefe725d98 R14: 0000000000000000 R15: ffff9cfe833a4d00
[ 74.807301] FS: 0000000000000000(0000) GS:ffff9d01afb00000(0000) knlGS:0000000000000000
[ 74.808338] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 74.809084] CR2: 00007f2b81bf4000 CR3: 0000000100056000 CR4: 00000000000006e0
[ 74.810047] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 74.810981] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 74.811897] Call Trace:
[ 74.812241] <TASK>
[ 74.812566] __jbd2_journal_refile_buffer+0x12f/0x180
[ 74.813246] jbd2_journal_refile_buffer+0x4c/0xa0
[ 74.813869] jbd2_journal_commit_transaction.cold+0xa1/0x148
[ 74.817550] kjournald2+0xf8/0x3e0
[ 74.819056] kthread+0x153/0x1c0
[ 74.819963] ret_from_fork+0x22/0x30
Above issue may happen as follows:
write truncate kjournald2
generic_perform_write
ext4_write_begin
ext4_walk_page_buffers
do_journal_get_write_access ->add BJ_Reserved list
ext4_journalled_write_end
ext4_walk_page_buffers
write_end_fn
ext4_handle_dirty_metadata
***************JBD2 ABORT**************
jbd2_journal_dirty_metadata
-> return -EROFS, jh in reserved_list
jbd2_journal_commit_transaction
while (commit_transaction->t_reserved_list)
jh = commit_transaction->t_reserved_list;
truncate_pagecache_range
do_invalidatepage
ext4_journalled_invalidatepage
jbd2_journal_invalidatepage
journal_unmap_buffer
__dispose_buffer
__jbd2_journal_unfile_buffer
jbd2_journal_put_journal_head ->put last ref_count
__journal_remove_journal_head
bh->b_private = NULL;
jh->b_bh = NULL;
jbd2_journal_refile_buffer(journal, jh);
bh = jh2bh(jh);
->bh is NULL, later will trigger null-ptr-deref
journal_free_journal_head(jh);
After commit 96f1e0974575, we no longer hold the j_state_lock while
iterating over the list of reserved handles in
jbd2_journal_commit_transaction(). This potentially allows the
journal_head to be freed by journal_unmap_buffer while the commit
codepath is also trying to free the BJ_Reserved buffers. Keeping
j_state_lock held while trying extends hold time of the lock
minimally, and solves this issue.
Fixes: 96f1e0974575("jbd2: avoid long hold times of j_state_lock while committing a transaction")
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220317142137.1821590-1-yebin10@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-27 13:50:50 +02:00
2020-11-05 11:43:34 +01:00
2021-03-04 10:26:48 +01:00
2021-09-30 10:09:22 +02:00
2019-10-25 00:03:11 -04:00
2019-08-30 07:27:17 -07:00
2021-01-06 14:48:39 +01:00
2022-04-20 09:19:38 +02:00
2020-11-05 11:43:36 +01:00
2021-10-27 09:54:27 +02:00
2022-04-27 13:50:47 +02:00
2019-09-19 09:42:37 -07:00
2022-03-02 11:41:10 +01:00
2019-11-23 21:44:49 -05:00
2021-09-12 08:56:38 +02:00
2022-01-27 09:19:36 +01:00
2022-02-01 17:24:34 +01:00
2022-01-27 09:19:40 +01:00
2021-05-26 12:05:19 +02:00
2020-12-02 08:49:53 +01:00
2019-08-30 07:27:17 -07:00
2021-11-21 13:38:51 +01:00
2019-11-10 11:56:05 -05:00
2022-04-15 14:18:13 +02:00
2022-04-27 13:50:50 +02:00
2022-04-15 14:18:06 +02:00
2020-06-17 16:40:36 +02:00
2019-08-30 07:27:17 -07:00
2021-09-22 12:26:25 +02:00
2022-03-16 13:21:47 +01:00
2022-04-27 13:50:45 +02:00
2021-07-31 08:19:38 +02:00
2021-05-19 10:08:29 +02:00
2021-04-14 08:24:14 +02:00
2019-08-30 08:11:25 -07:00
2021-07-28 13:31:01 +02:00
2021-09-15 09:47:35 +02:00
2021-11-12 14:43:03 +01:00
2022-04-27 13:50:50 +02:00
2022-04-15 14:17:59 +02:00
2022-04-15 14:18:36 +02:00
2020-08-19 08:16:12 +02:00
2021-09-22 12:26:34 +02:00
2022-04-15 14:18:35 +02:00
2022-04-15 14:18:36 +02:00
2020-12-30 11:51:22 +01:00
2022-04-15 14:17:59 +02:00
2021-09-26 14:07:13 +02:00
2020-06-17 16:40:24 +02:00
2022-04-15 14:18:23 +02:00
2022-03-23 09:12:06 +01:00
2019-08-30 08:11:25 -07:00
2022-01-20 09:19:17 +01:00
2021-12-22 09:29:40 +01:00
2021-12-01 09:23:31 +01:00
2021-03-04 10:26:45 +01:00
2021-09-30 10:09:26 +02:00
2019-08-30 07:27:17 -07:00
2022-02-23 11:59:55 +01:00
2020-10-29 09:57:53 +01:00
2021-08-12 13:21:05 +02:00
2020-08-26 10:40:51 +02:00
2021-05-19 10:08:29 +02:00
2021-03-07 12:20:48 +01:00
2019-08-30 07:27:18 -07:00
2022-03-02 11:41:13 +01:00
2022-04-15 14:18:31 +02:00
2022-02-01 17:24:34 +01:00
2020-08-21 13:05:37 +02:00
2019-09-17 11:48:24 -04:00
2021-10-06 15:42:30 +02:00
2022-01-11 15:23:32 +01:00
2021-12-14 14:49:02 +01:00
2020-02-11 04:35:12 -08:00
2021-10-06 15:42:35 +02:00
2020-09-03 11:26:39 +02:00
2021-03-17 17:03:57 +01:00
2021-05-22 11:38:29 +02:00
2020-11-05 11:43:24 +01:00
2020-01-14 20:08:18 +01:00
2020-01-09 10:20:05 +01:00
2020-12-11 13:23:30 +01:00
2020-10-29 09:57:45 +01:00
2021-07-14 16:53:25 +02:00
2020-10-01 13:17:19 +02:00
2021-04-14 08:24:11 +02:00
2020-01-12 12:21:37 +01:00
2020-02-11 04:35:37 -08:00
2020-10-07 08:01:31 +02:00
2021-10-27 09:54:27 +02:00
2021-09-15 09:47:28 +02:00
2019-08-19 11:00:39 -04:00
2022-03-02 11:41:18 +01:00
2020-04-17 10:50:21 +02:00
2022-02-08 18:24:29 +01:00
2019-09-12 21:06:14 -04:00
2021-07-14 16:53:35 +02:00
2020-03-25 08:25:58 +01:00
2021-07-31 08:19:37 +02:00
2022-04-15 14:18:41 +02:00
2019-12-17 19:55:30 +01:00
2019-09-18 16:59:14 -07:00
2020-11-24 13:29:19 +01:00
2020-03-25 08:25:41 +01:00
2019-09-18 16:59:14 -07:00
2020-01-17 19:48:21 +01:00
2022-02-01 17:24:39 +01:00
2021-08-26 08:36:22 -04:00
2020-03-18 07:17:51 +01:00
2021-08-12 13:21:02 +02:00
2020-05-02 08:48:44 +02:00
2021-03-17 17:03:33 +01:00
2019-09-06 21:28:49 +02:00
2020-02-11 04:35:23 -08:00
2021-04-21 12:56:16 +02:00
2022-01-29 10:25:11 +01:00
2021-07-20 16:10:54 +02:00
2021-12-14 14:49:02 +01:00
2019-12-17 19:56:52 +01:00
2022-04-27 13:50:48 +02:00
2019-10-03 14:21:35 -07:00
2022-02-23 11:59:55 +01:00
2021-09-22 12:26:26 +02:00
2020-02-11 04:35:12 -08:00
2020-08-11 15:33:39 +02:00
1b6ad24210