Julia Lawall c0d861afa5 drivers/video/backlight/da903x.c: introduce missing kfree
Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Mike Rapoport <mike@compulab.co.il>
Cc: Richard Purdie <rpurdie@linux.intel.com>
Cc: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-11-19 18:49:59 -08:00
..
2008-10-28 17:46:02 +09:00
2008-11-07 08:25:43 -08:00
2008-11-14 14:10:01 +01:00
2008-11-13 15:37:07 +09:00
2008-11-01 09:49:46 -07:00
2008-11-01 09:50:12 -07:00
2008-10-21 07:48:33 -04:00
2008-11-19 18:49:57 -08:00
2008-10-16 11:21:30 -07:00
2008-10-27 19:15:41 +01:00
2008-11-11 13:33:05 -08:00
2008-11-04 08:18:19 -08:00
2008-11-04 08:18:19 -08:00
2008-11-10 13:50:17 -08:00
2008-11-01 09:49:46 -07:00
2008-11-13 14:45:06 -08:00
2008-11-04 08:18:19 -08:00
2008-10-28 21:47:17 +00:00