Eric W. Biederman c0e3f6df04 proc/fd: In proc_readfd_common use task_lookup_next_fd_rcu
[ Upstream commit 5b17b61870e2f4b0a4fdc5c6039fbdb4ffb796df ]

When discussing[1] exec and posix file locks it was realized that none
of the callers of get_files_struct fundamentally needed to call
get_files_struct, and that by switching them to helper functions
instead it will both simplify their code and remove unnecessary
increments of files_struct.count.  Those unnecessary increments can
result in exec unnecessarily unsharing files_struct which breaking
posix locks, and it can result in fget_light having to fallback to
fget reducing system performance.

Using task_lookup_next_fd_rcu simplifies proc_readfd_common, by moving
the checking for the maximum file descritor into the generic code, and
by remvoing the need for capturing and releasing a reference on
files_struct.

As task_lookup_fd_rcu may update the fd ctx->pos has been changed
to be the fd +2 after task_lookup_fd_rcu returns.

[1] https://lkml.kernel.org/r/20180915160423.GA31461@redhat.com
Suggested-by: Oleg Nesterov <oleg@redhat.com>
Tested-by: Andy Lavr <andy.lavr@gmail.com>
v1: https://lkml.kernel.org/r/20200817220425.9389-10-ebiederm@xmission.com
Link: https://lkml.kernel.org/r/20201120231441.29911-15-ebiederm@xmission.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-21 14:52:49 +02:00
..
2021-09-18 13:40:15 +02:00
2024-04-13 12:58:19 +02:00
2024-02-23 08:42:14 +01:00
2024-06-21 14:52:48 +02:00
2023-09-19 12:20:23 +02:00
2024-03-01 13:16:43 +01:00
2023-09-23 11:01:09 +02:00
2024-06-21 14:52:47 +02:00
2022-06-09 10:21:16 +02:00
2024-06-21 14:52:47 +02:00
2024-06-21 14:52:49 +02:00
2023-12-08 08:46:15 +01:00
2023-01-04 11:39:23 +01:00
2023-01-14 10:16:27 +01:00