iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/block
History
Ye Bin 6a139c9ec5 block: Fix fsync always failed if once failed 
commit 8a7518931baa8ea023700987f3db31cb0a80610b upstream.

We do test with inject error fault base on v4.19, after test some time we found
sync /dev/sda always failed.
[root@localhost] sync /dev/sda
sync: error syncing '/dev/sda': Input/output error

scsi log as follows:
[19069.812296] sd 0:0:0:0: [sda] tag#64 Send: scmd 0x00000000d03a0b6b
[19069.812302] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00
[19069.812533] sd 0:0:0:0: [sda] tag#64 Done: SUCCESS Result: hostbyte=DID_OK driverbyte=DRIVER_OK
[19069.812536] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00
[19069.812539] sd 0:0:0:0: [sda] tag#64 scsi host busy 1 failed 0
[19069.812542] sd 0:0:0:0: Notifying upper driver of completion (result 0)
[19069.812546] sd 0:0:0:0: [sda] tag#64 sd_done: completed 0 of 0 bytes
[19069.812549] sd 0:0:0:0: [sda] tag#64 0 sectors total, 0 bytes done.
[19069.812564] print_req_error: I/O error, dev sda, sector 0

ftrace log as follows:
 rep-306069 [007] .... 19654.923315: block_bio_queue: 8,0 FWS 0 + 0 [rep]
 rep-306069 [007] .... 19654.923333: block_getrq: 8,0 FWS 0 + 0 [rep]
 kworker/7:1H-250   [007] .... 19654.923352: block_rq_issue: 8,0 FF 0 () 0 + 0 [kworker/7:1H]
 <idle>-0     [007] ..s. 19654.923562: block_rq_complete: 8,0 FF () 18446744073709551615 + 0 [0]
 <idle>-0     [007] d.s. 19654.923576: block_rq_complete: 8,0 WS () 0 + 0 [-5]

As 8d6996630c03 introduce 'fq->rq_status', this data only update when 'flush_rq'
reference count isn't zero. If flush request once failed and record error code
in 'fq->rq_status'. If there is no chance to update 'fq->rq_status',then do fsync
will always failed.
To address this issue reset 'fq->rq_status' after return error code to upper layer.

Fixes: 8d6996630c03("block: fix null pointer dereference in blk_mq_rq_timed_out()")
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20211129012659.1553733-1-yebin10@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
[sudip: adjust context]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-03-08 19:04:08 +01:00
..
partitions
partitions/aix: append null character to print data from disk
2018-07-27 09:17:41 -06:00
badblocks.c
badblocks: fix wrong return value in badblocks_set if badblocks are disabled
2017-11-03 11:29:50 -07:00
bfq-cgroup.c
block, bfq: fix overwrite of bfq_group pointer in bfq_find_set_group()
2020-03-25 08:06:08 +01:00
bfq-iosched.c
block/wbt: fix negative inflight counter when remove scsi device
2022-02-23 11:58:40 +01:00
bfq-iosched.h
block, bfq: fix use after free in bfq_bfqq_expire
2021-12-29 12:20:43 +01:00
bfq-wf2q.c
block, bfq: fix use after free in bfq_bfqq_expire
2021-12-29 12:20:43 +01:00
bio-integrity.c
block: bio-integrity: Advance seed correctly for larger interval sizes
2022-02-08 18:23:14 +01:00
bio.c
block: only update parent bi_status when bio fail
2021-04-16 11:49:30 +02:00
blk-cgroup.c
bdi: use bdi_dev_name() to get device name
2021-08-08 08:54:29 +02:00
blk-core.c
block: split .sysfs_lock into two locks
2021-03-04 09:39:30 +01:00
blk-exec.c
blk-mq-sched: remove unused 'can_block' arg from blk_mq_sched_insert_request
2018-01-17 09:49:21 -07:00
blk-flush.c
block: Fix fsync always failed if once failed
2022-03-08 19:04:08 +01:00
blk-integrity.c
block drivers/block: Use octal not symbolic permissions
2018-05-24 13:38:59 -06:00
blk-ioc.c
block: Fix use-after-free issue accessing struct io_cq
2020-04-17 10:48:41 +02:00
blk-iolatency.c
blk-iolatency: error out if blk_get_queue() failed in iolatency_set_limit()
2021-08-12 13:19:40 +02:00
blk-lib.c
block: fix 32 bit overflow in __blkdev_issue_discard()
2020-02-01 09:37:12 +00:00
blk-map.c
block: fix memleak when __blk_rq_map_user_iov() is failed
2020-01-12 12:17:22 +01:00
blk-merge.c
block: don't use bio->bi_vcnt to figure out segment number
2020-01-27 14:50:23 +01:00
blk-mq-cpumap.c
blk-mq: don't keep offline CPUs mapped to hctx 0
2018-04-10 08:38:46 -06:00
blk-mq-debugfs-zoned.c
block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n
2018-07-09 09:07:52 -06:00
blk-mq-debugfs.c
block, scsi: Change the preempt-only flag into a counter
2019-08-04 09:30:57 +02:00
blk-mq-debugfs.h
block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n
2018-07-09 09:07:52 -06:00
blk-mq-pci.c
blk-mq: code clean-up by adding an API to clear set->mq_map
2018-07-09 09:07:53 -06:00
blk-mq-rdma.c
block: Add rdma affinity based queue mapping helper
2017-08-08 14:58:03 -04:00
blk-mq-sched.c
blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART
2020-09-03 11:24:26 +02:00
blk-mq-sched.h
block: mq-deadline: Fix write completion handling
2019-01-13 09:51:07 +01:00
blk-mq-sysfs.c
block: split .sysfs_lock into two locks
2021-03-04 09:39:30 +01:00
blk-mq-tag.c
blk-mq: Allow blocking queue tag iter callbacks
2018-09-25 20:17:59 -06:00
blk-mq-tag.h
Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block
2017-11-14 15:32:19 -08:00
blk-mq-virtio.c
blk-mq: provide a default queue mapping for virtio device
2017-02-27 20:54:05 +02:00
blk-mq.c
blk-mq: Swap two calls in blk_mq_exit_queue()
2021-05-22 10:59:46 +02:00
blk-mq.h
blk-mq: free hw queue's resource in hctx's release handler
2019-09-16 08:22:13 +02:00
blk-rq-qos.c
blk-wbt: fix performance regression in wbt scale_up/scale_down
2019-10-17 13:45:16 -07:00
blk-rq-qos.h
blk-rq-qos: fix first node deletion of rq_qos_del()
2019-10-29 09:20:09 +01:00
blk-settings.c
blk-settings: align max_sectors on "logical_block_size" boundary
2021-03-04 09:39:51 +01:00
blk-softirq.c
block: fix timeout changes for legacy request drivers
2018-06-19 11:27:18 -06:00
blk-stat.c
blk-stat: export helpers for modifying blk_rq_stat
2018-07-09 09:07:54 -06:00
blk-stat.h
block: deactivate blk_stat timer in wbt_disable_default()
2019-01-13 09:51:06 +01:00
blk-sysfs.c
block: don't release queue's sysfs lock during switching elevator
2021-03-04 09:39:30 +01:00
blk-tag.c
for-linus-20180616
2018-06-17 05:37:55 +09:00
blk-throttle.c
blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()
2021-09-26 13:39:49 +02:00
blk-timeout.c
blk-mq: Fix timeout handling in case the timeout handler returns BLK_EH_DONE
2018-06-23 10:25:45 -06:00
blk-wbt.c
blk-wbt: make sure throttle is enabled properly
2021-07-20 16:15:48 +02:00
blk-wbt.h
blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()
2021-07-20 16:15:48 +02:00
blk-zoned.c
blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
2021-09-22 11:47:57 +02:00
blk.h
block: split .sysfs_lock into two locks
2021-03-04 09:39:30 +01:00
bounce.c
block: copy ioprio in __bio_clone_fast() and bounce
2018-12-01 09:37:32 +01:00
bsg-lib.c
block/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path
2018-08-01 09:13:03 -06:00
bsg.c
block: bsg: move atomic_t ref_count variable to refcount API
2018-08-27 19:17:02 -06:00
cfq-iosched.c
cfq: Suppress compiler warnings about comparisons
2018-08-07 17:57:13 -06:00
cmdline-parser.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compat_ioctl.c
compat_ioctl: block: handle BLKREPORTZONE/BLKRESETZONE
2020-01-09 10:19:01 +01:00
deadline-iosched.c
block drivers/block: Use octal not symbolic permissions
2018-05-24 13:38:59 -06:00
elevator.c
block/wbt: fix negative inflight counter when remove scsi device
2022-02-23 11:58:40 +01:00
genhd.c
block: Suppress uevent for hidden device when removed
2021-03-30 14:36:59 +02:00
ioctl.c
block: pass inclusive 'lend' parameter to truncate_inode_pages_range
2018-02-23 15:20:19 -07:00
ioprio.c
block: fix ioprio_get(IOPRIO_WHO_PGRP) vs setuid(2)
2021-12-14 10:18:07 +01:00
Kconfig
block: introduce blk-iolatency io controller
2018-07-09 09:07:54 -06:00
Kconfig.iosched
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
kyber-iosched.c
block: kyber: make kyber more friendly with merging
2018-05-30 10:47:40 -06:00
Makefile
block: introduce blk-iolatency io controller
2018-07-09 09:07:54 -06:00
mq-deadline.c
block: mq-deadline: Fix queue restart handling
2019-10-07 18:57:19 +02:00
noop-iosched.c
block: move existing elevator ops to union
2017-01-17 10:03:33 -07:00
opal_proto.h
block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled
2017-09-11 09:45:52 -06:00
partition-generic.c
block: fix use-after-free on gendisk
2019-05-31 06:46:18 -07:00
scsi_ioctl.c
block: consistently use GFP_NOIO instead of __GFP_NORECLAIM
2018-05-14 08:55:18 -06:00
sed-opal.c
block: sed-opal: fix IOC_OPAL_ENABLE_DISABLE_MBR
2019-05-31 06:46:24 -07:00
t10-pi.c
block: move dif_prepare/dif_complete functions to block layer
2018-07-30 08:27:02 -06:00