linux/sound
Takashi Sakamoto c1839501fe ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case
In a commit 1d717123bb ("ALSA: firewire-lib: Avoid
-Wflex-array-member-not-at-end warning"), DEFINE_FLEX() macro was used to
handle variable length of array for header field in struct fw_iso_packet
structure. The usage of macro has a side effect that the designated
initializer assigns the count of array to the given field. Therefore
CIP_HEADER_QUADLETS (=2) is assigned to struct fw_iso_packet.header,
while the original designated initializer assigns zero to all fields.

With CIP_NO_HEADER flag, the change causes invalid length of header in
isochronous packet for 1394 OHCI IT context. This bug affects all of
devices supported by ALSA fireface driver; RME Fireface 400, 800, UCX, UFX,
and 802.

This commit fixes the bug by replacing it with the alternative version of
macro which corresponds no initializer.

Cc: stable@vger.kernel.org
Fixes: 1d717123bb ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning")
Reported-by: Edmund Raile <edmund.raile@proton.me>
Closes: https://lore.kernel.org/r/rrufondjeynlkx2lniot26ablsltnynfaq2gnqvbiso7ds32il@qk4r6xps7jh2/
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20240725155640.128442-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
2024-07-27 10:28:36 +09:00
..
ac97 ALSA: ac97: bus: Add missing module description 2024-05-09 10:13:07 +02:00
aoa ALSA: aoa: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:08 +02:00
arm ASoC: Updates for v6.10 2024-05-13 11:39:49 +02:00
atmel ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
core ALSA: seq: ump: Fix swapped song position pointer data 2024-05-31 09:51:44 +02:00
drivers ALSA: pcmtest: Add missing module descriptions 2024-05-09 10:13:07 +02:00
firewire ALSA: firewire-lib: fix wrong value as length of header for CIP_NO_HEADER case 2024-07-27 10:28:36 +09:00
hda ALSA/hda: intel-dsp-config: reduce log verbosity 2024-05-28 13:07:51 +02:00
i2c ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
isa ALSA: isa: Use *-y instead of *-objs in Makefile 2024-05-08 18:17:48 +02:00
mips ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
oss sound: oss: dmasound: Add missing module descriptions 2024-05-09 10:13:07 +02:00
parisc ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
pci ALSA: hda/realtek: Adjust G814JZR to use SPI init for amp 2024-05-27 09:29:19 +02:00
pcmcia ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
ppc ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
sh ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
soc ASoC: SOF: ipc4-topology: Fix nhlt configuration blob 2024-05-30 14:33:14 +01:00
sparc ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
spi ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
synth ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
usb ALSA: usb-audio: Fix for sampling rates support for Mbox3 2024-05-16 16:01:55 +02:00
virtio virtio: features, fixes, cleanups 2024-05-23 12:04:36 -07:00
x86 ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
xen ALSA: misc: Use *-y instead of *-objs in Makefile 2024-05-08 18:18:13 +02:00
ac97_bus.c ALSA: ac97: legacy: Add missing module description 2024-05-09 10:13:07 +02:00
Kconfig This pull request contains the following changes for UML: 2023-09-04 11:32:21 -07:00
last.c
Makefile ALSA: core: Use *-y instead of *-objs in Makefile 2024-05-08 18:17:32 +02:00
sound_core.c