Thomas Gleixner 746976a301 NTP: remove clock_was_set() call to prevent deadlock
The clock_was_set() call in seconds_overflow() which happens only when
leap seconds are inserted / deleted is wrong in two aspects:

1. it results in a call to on_each_cpu() with interrupts disabled
2. it is potential deadlock source vs. call_lock in smp_call_function()

The only possible side effect of the removal might be, that an absolute
CLOCK_REALTIME timer fires 1 second too late, in the rare case of leap
second deletion and an absolute CLOCK_REALTIME timer which expires in
the affected time frame. It will never fire too early.

This was probably observed by the reporter of a June 30th -> July 1st
hang: http://lkml.org/lkml/2007/7/3/103

A similar problem was observed by Dave Jones, who provided a screen shot
with a lockdep back trace, which allowed to analyse the problem.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-07-03 13:54:27 -07:00
..
2007-05-11 05:38:25 -04:00
2007-05-11 05:38:26 -04:00
2007-05-23 20:14:11 -07:00
2007-06-24 12:08:53 -07:00
2006-12-07 08:39:36 -08:00
2006-12-04 02:00:22 -05:00
2007-05-09 07:26:28 +02:00
2007-05-09 12:30:56 -07:00
2007-05-21 09:18:19 -07:00
2007-05-11 05:38:25 -04:00
2007-06-28 11:38:18 -07:00
2007-05-11 08:29:35 -07:00
2006-12-07 08:39:25 -08:00
2007-05-09 08:57:56 +02:00