Will Deacon 446a5a8b1e ARM: 6205/1: perf: ensure counter delta is treated as unsigned
Hardware performance counters on ARM are 32-bits wide but atomic64_t
variables are used to represent counter data in the hw_perf_event structure.

The armpmu_event_update function right-shifts a signed 64-bit delta variable
and adds the result to the event count. This can lead to shifting in sign-bits
if the MSB of the 32-bit counter value is set. This results in perf output
such as:

 Performance counter stats for 'sleep 20':

 18446744073460670464  cycles             <-- 0xFFFFFFFFF12A6000
        7783773  instructions             #      0.000 IPC
            465  context-switches
            161  page-faults
        1172393  branches

   20.154242147  seconds time elapsed

This patch ensures that the delta value is treated as unsigned so that the
right shift sets the upper bits to zero.

Cc: <stable@kernel.org>
Acked-by: Jamie Iles <jamie.iles@picochip.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-07-04 23:11:37 +01:00
..
2008-08-12 19:54:09 +01:00
2008-05-30 10:33:49 +02:00
2010-03-12 15:52:32 -08:00
2009-12-11 06:44:29 -05:00
2008-09-06 12:10:45 +01:00
2010-05-20 21:04:21 -05:00
2010-02-25 22:09:41 +00:00
2010-03-12 15:52:38 -08:00
2010-03-12 15:52:38 -08:00
2010-05-17 17:24:04 +01:00
2010-03-12 15:52:32 -08:00
2010-02-15 21:39:14 +00:00