iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/tipc
History
Eric Dumazet 1378817486 tipc: block BH before using dst_cache 
dst_cache_get() documents it must be used with BH disabled.

sysbot reported :

BUG: using smp_processor_id() in preemptible [00000000] code: /21697
caller is dst_cache_get+0x3a/0xb0 net/core/dst_cache.c:68
CPU: 0 PID: 21697 Comm:  Not tainted 5.7.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 check_preemption_disabled lib/smp_processor_id.c:47 [inline]
 debug_smp_processor_id.cold+0x88/0x9b lib/smp_processor_id.c:57
 dst_cache_get+0x3a/0xb0 net/core/dst_cache.c:68
 tipc_udp_xmit.isra.0+0xb9/0xad0 net/tipc/udp_media.c:164
 tipc_udp_send_msg+0x3e6/0x490 net/tipc/udp_media.c:244
 tipc_bearer_xmit_skb+0x1de/0x3f0 net/tipc/bearer.c:526
 tipc_enable_bearer+0xb2f/0xd60 net/tipc/bearer.c:331
 __tipc_nl_bearer_enable+0x2bf/0x390 net/tipc/bearer.c:995
 tipc_nl_bearer_enable+0x1e/0x30 net/tipc/bearer.c:1003
 genl_family_rcv_msg_doit net/netlink/genetlink.c:673 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:718 [inline]
 genl_rcv_msg+0x627/0xdf0 net/netlink/genetlink.c:735
 netlink_rcv_skb+0x15a/0x410 net/netlink/af_netlink.c:2469
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:746
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x537/0x740 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0x882/0xe10 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:672
 ____sys_sendmsg+0x6bf/0x7e0 net/socket.c:2362
 ___sys_sendmsg+0x100/0x170 net/socket.c:2416
 __sys_sendmsg+0xec/0x1b0 net/socket.c:2449
 do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x45ca29

Fixes: e9c1a793210f ("tipc: add dst_cache support for udp media")
Cc: Xin Long <lucien.xin@gmail.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-05-22 15:39:00 -07:00
..
addr.c
tipc: initialise addr_trail_end when setting node addresses
2019-08-11 21:40:04 -07:00
addr.h
tipc: add 128-bit node identifier
2018-03-23 13:12:18 -04:00
bcast.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-12-22 15:15:05 -08:00
bcast.h
tipc: update replicast capability for broadcast send link
2019-11-22 09:29:50 -08:00
bearer.c
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
bearer.h
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
core.c
tipc: fix ordering of tipc module init and exit routine
2019-12-06 12:01:09 -08:00
core.h
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-11-16 21:51:42 -08:00
crypto.c
tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv
2020-04-18 13:17:04 -07:00
crypto.h
tipc: introduce TIPC encryption & authentication
2019-11-08 14:01:59 -08:00
diag.c
tipc: switch to rhashtable iterator
2018-08-29 18:04:54 -07:00
discover.c
tipc: fix use-after-free in tipc_disc_rcv()
2019-12-10 17:45:04 -08:00
discover.h
tipc: some cleanups in the file discover.c
2018-03-23 13:12:17 -04:00
eth_media.c
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
group.c
tipc: clean up skb list lock handling on send path
2019-08-18 14:01:07 -07:00
group.h
tipc: extend sock diag for group communication
2018-06-30 21:05:42 +09:00
ib_media.c
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
Kconfig
tipc: introduce TIPC encryption & authentication
2019-11-08 14:01:59 -08:00
link.c
tipc: fix incorrect increasing of link window
2020-04-15 16:23:33 -07:00
link.h
tipc: introduce variable window congestion control
2019-12-10 17:31:15 -08:00
Makefile
tipc: remove meaningless assignment in Makefile
2020-01-08 12:38:54 -08:00
monitor.c
tipc: add NULL pointer check to prevent kernel oops
2020-03-15 00:07:00 -07:00
monitor.h
tipc: update mon's self addr when node addr generated
2019-11-12 19:45:45 -08:00
msg.c
tipc: simplify trivial boolean return
2020-03-15 00:07:00 -07:00
msg.h
tipc: Add a missing case of TIPC_DIRECT_MSG type
2020-03-26 11:21:02 -07:00
name_distr.c
tipc: improve throughput between nodes in netns
2019-10-29 17:55:38 -07:00
name_distr.h
tipc: permit overlapping service ranges in name table
2018-03-31 22:19:52 -04:00
name_table.c
tipc: fix name table rbtree issues
2019-12-10 17:45:04 -08:00
name_table.h
tipc: support in-order name publication events
2019-11-22 09:29:50 -08:00
net.c
tipc: make legacy address flag readable over netlink
2019-12-20 21:18:42 -08:00
net.h
tipc: make legacy address flag readable over netlink
2019-12-20 21:18:42 -08:00
netlink_compat.c
tipc: eliminate KMSAN: uninit-value in __tipc_nl_compat_dumpit error
2020-01-06 13:24:31 -08:00
netlink.c
tipc: add missing attribute validation for MTU property
2020-03-03 13:28:49 -08:00
netlink.h
net: tipc: allocate attrs locally instead of using genl_family_attrbuf in compat_dumpit()
2019-10-06 15:44:47 +02:00
node.c
tipc: Fix potential tipc_node refcnt leak in tipc_rcv
2020-04-18 13:24:20 -07:00
node.h
tipc: add support for AEAD key setting via netlink
2019-11-08 14:01:59 -08:00
socket.c
tipc: fix large latency in smart Nagle streaming
2020-05-13 12:33:18 -07:00
socket.h
tipc: add trace_events for tipc socket
2018-12-19 11:49:24 -08:00
subscr.c
tipc: fix unbalanced reference counter
2018-04-12 21:46:10 -04:00
subscr.h
tipc: fix failed service subscription deletion
2020-05-13 12:33:19 -07:00
sysctl.c
tipc: introduce TIPC encryption & authentication
2019-11-08 14:01:59 -08:00
topsrv.c
tipc: fix failed service subscription deletion
2020-05-13 12:33:19 -07:00
topsrv.h
tipc: rename tipc_server to tipc_topsrv
2018-02-16 15:26:34 -05:00
trace.c
tipc: remove unneeded semicolon in trace.c
2019-01-17 22:04:43 -08:00
trace.h
tipc: add trace_events for tipc bearer
2018-12-19 11:49:25 -08:00
udp_media.c
tipc: block BH before using dst_cache
2020-05-22 15:39:00 -07:00
udp_media.h
tipc: implement configuration of UDP media MTU
2018-04-20 11:04:05 -04:00