iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/netfilter
History
Florian Westphal c2d421e171 netfilter: nf_nat: fix race when unloading protocol modules 
following oops was reported:
RIP: 0010:[<ffffffffa03227f2>]  [<ffffffffa03227f2>] nf_nat_cleanup_conntrack+0x42/0x70 [nf_nat]
RSP: 0018:ffff880202c63d40  EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff8801ac7bec28 RCX: ffff8801d0eedbe0
RDX: dead000000200200 RSI: 0000000000000011 RDI: ffffffffa03265b8
[..]
Call Trace:
 [..]
 [<ffffffffa02febed>] destroy_conntrack+0xbd/0x110 [nf_conntrack]

Happens when a conntrack timeout expires right after first part
of the nat cleanup has completed (bysrc hash removal), but before
part 2 has completed (re-initialization of nat area).

[ destroy callback tries to delete bysrc again ]

Patrick suggested to just remove the affected conntracks -- the
connections won't work properly anyway without nat transformation.

So, lets do that.

Reported-by: CAI Qian <caiqian@redhat.com>
Cc: Patrick McHardy <kaber@trash.net>
Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2013-04-12 11:46:31 +02:00
..
ipset
netfilter: ipset: hash:*net*: nomatch flag not excluded on set resize
2013-04-09 21:04:16 +02:00
ipvs
ipvs: remove extra rcu lock
2013-03-19 21:21:52 +09:00
core.c
netfilter: kill support for per-af queue backends
2012-12-03 15:07:48 +01:00
Kconfig
Driver core patches for 3.9-rc1
2013-02-21 12:05:51 -08:00
Makefile
netfilter: x_tables: add xt_bpf match
2013-01-21 12:20:19 +01:00
nf_conntrack_acct.c
netfilter: nf_ct_acct: move initialization out of pernet_operations
2013-01-23 12:55:29 +01:00
nf_conntrack_amanda.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_conntrack_broadcast.c
netfilter: nf_conntrack: nf_conntrack snmp helper
2011-01-18 18:12:24 +01:00
nf_conntrack_core.c
netfilter: nf_ct_proto: move initialization out of pernet_operations
2013-01-23 12:56:33 +01:00
nf_conntrack_ecache.c
netfilter: nf_ct_ecache: move initialization out of pernet_operations
2013-01-23 12:55:50 +01:00
nf_conntrack_expect.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
nf_conntrack_extend.c
netfilter: nf_ct_ext: support variable length extensions
2012-06-16 15:08:49 +02:00
nf_conntrack_ftp.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_conntrack_h323_asn1.c
netfilter: h323: bug in parsing of ASN1 SEQOF field
2011-04-04 15:21:02 +02:00
nf_conntrack_h323_main.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_conntrack_h323_types.c
…
nf_conntrack_helper.c
Merge branch 'master' of git://1984.lsi.us.es/nf
2013-03-07 15:20:02 -05:00
nf_conntrack_irc.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_conntrack_l3proto_generic.c
…
nf_conntrack_labels.c
netfilter: nf_ct_labels: move initialization out of pernet_operations
2013-01-23 12:56:23 +01:00
nf_conntrack_netbios_ns.c
netfilter: nf_conntrack: nf_conntrack snmp helper
2011-01-18 18:12:24 +01:00
nf_conntrack_netlink.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
nf_conntrack_pptp.c
netfilter: nf_ct_pptp: Fix comment referring to incorrect RFC
2013-02-05 05:10:02 +01:00
nf_conntrack_proto_dccp.c
netfilter: nf_conntrack: register pernet subsystem before register L4 proto
2013-03-15 12:29:25 +01:00
nf_conntrack_proto_generic.c
netfilter: nf_conntrack: generalize nf_ct_l4proto_net
2012-07-04 19:37:22 +02:00
nf_conntrack_proto_gre.c
netfilter: nf_conntrack: register pernet subsystem before register L4 proto
2013-03-15 12:29:25 +01:00
nf_conntrack_proto_sctp.c
netfilter: nf_conntrack: register pernet subsystem before register L4 proto
2013-03-15 12:29:25 +01:00
nf_conntrack_proto_tcp.c
netfilter: ctnetlink: nla_policy updates
2012-12-03 15:13:10 +01:00
nf_conntrack_proto_udp.c
netfilter: nf_conntrack: generalize nf_ct_l4proto_net
2012-07-04 19:37:22 +02:00
nf_conntrack_proto_udplite.c
netfilter: nf_conntrack: register pernet subsystem before register L4 proto
2013-03-15 12:29:25 +01:00
nf_conntrack_proto.c
netfilter: nf_conntrack: refactor l4proto support for netns
2013-01-23 14:40:53 +01:00
nf_conntrack_sane.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_conntrack_sip.c
netfilter: nf_ct_sip: don't drop packets with offsets pointing outside the packet
2013-04-06 14:03:18 +02:00
nf_conntrack_snmp.c
netfilter: nf_ct_snmp: add include file
2013-01-18 00:28:18 +01:00
nf_conntrack_standalone.c
netfilter: nf_conntrack: fix error return code
2013-03-27 18:31:17 +01:00
nf_conntrack_tftp.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_conntrack_timeout.c
netfilter: nf_ct_timeout: move initialization out of pernet_operations
2013-01-23 12:56:02 +01:00
nf_conntrack_timestamp.c
netfilter: nf_ct_tstamp: move initialization out of pernet_operations
2013-01-23 12:55:39 +01:00
nf_internals.h
netfilter: pass 'nf_hook_ops' instead of 'list_head' to nf_queue()
2012-09-03 13:52:54 +02:00
nf_log.c
various: Fix spelling of "registered" in comments.
2012-11-19 14:29:46 +01:00
nf_nat_amanda.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_nat_core.c
netfilter: nf_nat: fix race when unloading protocol modules
2013-04-12 11:46:31 +02:00
nf_nat_ftp.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_nat_helper.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_irc.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_nat_proto_common.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_proto_dccp.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_proto_sctp.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_proto_tcp.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_proto_udp.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_proto_udplite.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_proto_unknown.c
netfilter: add protocol independent NAT core
2012-08-30 03:00:14 +02:00
nf_nat_sip.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_nat_tftp.c
netfilter: nf_ct_helper: better logging for dropped packets
2013-02-19 02:48:05 +01:00
nf_queue.c
netfilter: kill support for per-af queue backends
2012-12-03 15:07:48 +01:00
nf_sockopt.c
…
nf_tproxy_core.c
netfilter: tproxy: do not assign timewait sockets to skb->sk
2011-02-17 11:32:38 +01:00
nfnetlink_acct.c
netfilter: nfnetlink_acct: return -EINVAL if object name is empty
2013-03-25 14:21:30 +01:00
nfnetlink_cthelper.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
nfnetlink_cttimeout.c
netfilter: cttimeout: fix buffer overflow
2012-11-21 23:50:14 +01:00
nfnetlink_log.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
nfnetlink_queue_core.c
netfilter: nfnetlink_queue: fix error return code in nfnetlink_queue_init()
2013-03-25 14:21:27 +01:00
nfnetlink_queue_ct.c
netfilter: nfnetlink_queue: fix sparse warning due to missing include
2012-06-23 02:13:38 +02:00
nfnetlink.c
netfilter: nfnetlink: silence warning if CONFIG_PROVE_RCU isn't set
2013-03-04 14:45:36 +01:00
x_tables.c
net: proc: change proc_net_remove to remove_proc_entry
2013-02-18 14:53:08 -05:00
xt_addrtype.c
net:netfilter: use IS_ENABLED
2011-12-16 15:49:52 -05:00
xt_AUDIT.c
netfilter: xt_AUDIT: only generate audit log when audit enabled
2013-03-04 14:45:25 +01:00
xt_bpf.c
netfilter: x_tables: add xt_bpf match
2013-01-21 12:20:19 +01:00
xt_CHECKSUM.c
netfilter: add CHECKSUM target
2010-07-15 17:20:46 +02:00
xt_CLASSIFY.c
netfilter: xt_CLASSIFY: add ARP support, allow CLASSIFY target on any table
2010-11-15 13:57:56 +01:00
xt_cluster.c
…
xt_comment.c
…
xt_connbytes.c
Merge branch 'nf-next' of git://1984.lsi.us.es/net-next
2011-12-25 02:21:45 -05:00
xt_connlabel.c
netfilter: add connlabel conntrack extension
2013-01-18 00:28:15 +01:00
xt_connlimit.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
xt_connmark.c
…
xt_CONNSECMARK.c
…
xt_conntrack.c
netfilter: revert a2361c8735e07322023aedc36e4938b35af31eb0
2011-05-10 12:13:36 +02:00
xt_cpu.c
netfilter: xtables: add missing aliases for autoloading via iptables
2011-01-18 06:33:54 +01:00
xt_CT.c
netfilter: xt_CT: add alias flag
2013-02-05 01:49:26 +01:00
xt_dccp.c
…
xt_devgroup.c
netfilter: xtables: add device group match
2011-02-03 00:05:43 +01:00
xt_dscp.c
…
xt_DSCP.c
netfilter: IPv6: fix DSCP mangle code
2011-05-10 10:00:21 +02:00
xt_ecn.c
netfilter: xtables: collapse conditions in xt_ecn
2011-12-27 20:45:25 +01:00
xt_esp.c
…
xt_hashlimit.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
xt_helper.c
…
xt_hl.c
netfilter: Reduce switch/case indent
2011-07-01 16:11:15 -07:00
xt_HL.c
netfilter: Reduce switch/case indent
2011-07-01 16:11:15 -07:00
xt_HMARK.c
ipv6: Move ipv6_find_hdr() out of Netfilter code.
2012-11-09 17:05:07 -08:00
xt_IDLETIMER.c
netfilter: Remove unnecessary OOM logging messages
2011-11-01 09:19:49 +01:00
xt_iprange.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2011-02-04 14:28:58 -08:00
xt_ipvs.c
ipvs: API change to avoid rescan of IPv6 exthdr
2012-09-28 11:34:33 +09:00
xt_LED.c
netfilter: xtables: add missing aliases for autoloading via iptables
2011-01-18 06:33:54 +01:00
xt_length.c
…
xt_limit.c
netfilter: xt_limit: have r->cost != 0 case work
2012-09-26 01:33:16 +02:00
xt_LOG.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2012-10-02 11:11:09 -07:00
xt_mac.c
netfilter: Convert compare_ether_addr to ether_addr_equal
2012-05-09 20:49:18 -04:00
xt_mark.c
…
xt_multiport.c
…
xt_nat.c
netfilter: xt_nat: fix incorrect hooks for SNAT and DNAT targets
2012-10-15 13:39:12 +02:00
xt_NETMAP.c
netfilter: combine ipt_NETMAP and ip6t_NETMAP
2012-09-21 12:11:08 +02:00
xt_nfacct.c
netfilter: xtables: add nfacct match to support extended accounting
2011-12-25 02:43:17 +01:00
xt_NFLOG.c
…
xt_NFQUEUE.c
netfilter: sparse endian fixes
2012-08-20 12:45:57 +02:00
xt_osf.c
netfilter: sparse endian fixes
2012-08-20 12:45:57 +02:00
xt_owner.c
userns: xt_owner: Add basic user namespace support.
2012-08-14 21:55:30 -07:00
xt_physdev.c
…
xt_pkttype.c
…
xt_policy.c
…
xt_quota.c
net: Fix files explicitly needing to include module.h
2011-10-31 19:30:28 -04:00
xt_rateest.c
netfilter: xt_rateest: fix xt_rateest_mt_checkentry()
2011-07-29 16:24:46 +02:00
xt_RATEEST.c
hlist: drop the node parameter from iterators
2013-02-27 19:10:24 -08:00
xt_realm.c
…
xt_recent.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2013-02-26 20:16:07 -08:00
xt_REDIRECT.c
netfilter: combine ipt_REDIRECT and ip6t_REDIRECT
2012-09-21 12:12:05 +02:00
xt_repldata.h
…
xt_sctp.c
…
xt_SECMARK.c
secmark: make secmark object handling generic
2010-10-21 10:12:48 +11:00
xt_set.c
netfilter: ipset: Support to match elements marked with "nomatch"
2012-09-22 22:44:34 +02:00
xt_socket.c
netfilter: xt_socket: fix compilation warnings with gcc 4.7
2012-09-03 13:31:39 +02:00
xt_state.c
…
xt_statistic.c
net: Fix files explicitly needing to include module.h
2011-10-31 19:30:28 -04:00
xt_string.c
…
xt_tcpmss.c
…
xt_TCPMSS.c
net: Convert net_ratelimit uses to net_<level>_ratelimited
2012-05-15 13:45:03 -04:00
xt_TCPOPTSTRIP.c
net:netfilter: use IS_ENABLED
2011-12-16 15:49:52 -05:00
xt_tcpudp.c
…
xt_TEE.c
netfilter: xt_TEE: don't use destination address found in header
2012-10-17 11:00:31 +02:00
xt_time.c
netfilter: xt_time: add support to ignore day transition
2012-09-24 14:29:01 +02:00
xt_TPROXY.c
net: Fix (nearly-)kernel-doc comments for various functions
2012-07-10 23:13:45 -07:00
xt_TRACE.c
…
xt_u32.c
…