iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Hangbin Liu 008369dcc5 net_sched: Fix missing res info when create new tc_index filter 
Li Shuang reported the following warn:

[  733.484610] WARNING: CPU: 6 PID: 21123 at net/sched/sch_cbq.c:1418 cbq_destroy_class+0x5d/0x70 [sch_cbq]
[  733.495190] Modules linked in: sch_cbq cls_tcindex sch_dsmark rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace fscache xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat l
[  733.574155]  syscopyarea sysfillrect sysimgblt fb_sys_fops ttm drm igb ixgbe ahci libahci i2c_algo_bit libata i40e i2c_core dca mdio megaraid_sas dm_mirror dm_region_hash dm_log dm_mod
[  733.592500] CPU: 6 PID: 21123 Comm: tc Not tainted 4.18.0-rc8.latest+ #131
[  733.600169] Hardware name: Dell Inc. PowerEdge R730/0WCJNT, BIOS 2.1.5 04/11/2016
[  733.608518] RIP: 0010:cbq_destroy_class+0x5d/0x70 [sch_cbq]
[  733.614734] Code: e7 d9 d2 48 8b 7b 48 e8 61 05 da d2 48 8d bb f8 00 00 00 e8 75 ae d5 d2 48 39 eb 74 0a 48 89 df 5b 5d e9 16 6c 94 d2 5b 5d c3 <0f> 0b eb b6 0f 1f 44 00 00 66 2e 0f 1f 84
[  733.635798] RSP: 0018:ffffbfbb066bb9d8 EFLAGS: 00010202
[  733.641627] RAX: 0000000000000001 RBX: ffff9cdd17392800 RCX: 000000008010000f
[  733.649588] RDX: ffff9cdd1df547e0 RSI: ffff9cdd17392800 RDI: ffff9cdd0f84c800
[  733.657547] RBP: ffff9cdd0f84c800 R08: 0000000000000001 R09: 0000000000000000
[  733.665508] R10: ffff9cdd0f84d000 R11: 0000000000000001 R12: 0000000000000001
[  733.673469] R13: 0000000000000000 R14: 0000000000000001 R15: ffff9cdd17392200
[  733.681430] FS:  00007f911890a740(0000) GS:ffff9cdd1f8c0000(0000) knlGS:0000000000000000
[  733.690456] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  733.696864] CR2: 0000000000b5544c CR3: 0000000859374002 CR4: 00000000001606e0
[  733.704826] Call Trace:
[  733.707554]  cbq_destroy+0xa1/0xd0 [sch_cbq]
[  733.712318]  qdisc_destroy+0x62/0x130
[  733.716401]  dsmark_destroy+0x2a/0x70 [sch_dsmark]
[  733.721745]  qdisc_destroy+0x62/0x130
[  733.725829]  qdisc_graft+0x3ba/0x470
[  733.729817]  tc_get_qdisc+0x2a6/0x2c0
[  733.733901]  ? cred_has_capability+0x7d/0x130
[  733.738761]  rtnetlink_rcv_msg+0x263/0x2d0
[  733.743330]  ? rtnl_calcit.isra.30+0x110/0x110
[  733.748287]  netlink_rcv_skb+0x4d/0x130
[  733.752576]  netlink_unicast+0x1a3/0x250
[  733.756949]  netlink_sendmsg+0x2ae/0x3a0
[  733.761324]  sock_sendmsg+0x36/0x40
[  733.765213]  ___sys_sendmsg+0x26f/0x2d0
[  733.769493]  ? handle_pte_fault+0x586/0xdf0
[  733.774158]  ? __handle_mm_fault+0x389/0x500
[  733.778919]  ? __sys_sendmsg+0x5e/0xa0
[  733.783099]  __sys_sendmsg+0x5e/0xa0
[  733.787087]  do_syscall_64+0x5b/0x180
[  733.791171]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[  733.796805] RIP: 0033:0x7f9117f23f10
[  733.800791] Code: c3 48 8b 05 82 6f 2c 00 f7 db 64 89 18 48 83 cb ff eb dd 0f 1f 80 00 00 00 00 83 3d 8d d0 2c 00 00 75 10 b8 2e 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8
[  733.821873] RSP: 002b:00007ffe96818398 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
[  733.830319] RAX: ffffffffffffffda RBX: 000000005b71244c RCX: 00007f9117f23f10
[  733.838280] RDX: 0000000000000000 RSI: 00007ffe968183e0 RDI: 0000000000000003
[  733.846241] RBP: 00007ffe968183e0 R08: 000000000000ffff R09: 0000000000000003
[  733.854202] R10: 00007ffe96817e20 R11: 0000000000000246 R12: 0000000000000000
[  733.862161] R13: 0000000000662ee0 R14: 0000000000000000 R15: 0000000000000000
[  733.870121] ---[ end trace 28edd4aad712ddca ]---

This is because we didn't update f->result.res when create new filter. Then in
tcindex_delete() -> tcf_unbind_filter(), we will failed to find out the res
and unbind filter, which will trigger the WARN_ON() in cbq_destroy_class().

Fix it by updating f->result.res when create new filter.

Fixes: 6e0565697a106 ("net_sched: fix another crash in cls_tcindex")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-08-13 19:37:42 -07:00
..
act_api.c
net/sched: user-space can't set unknown tcfa_action values
2018-07-30 09:31:13 -07:00
act_bpf.c
net: sched: act_bpf method rename for grep-ability and consistency
2018-08-13 09:06:16 -07:00
act_connmark.c
net: sched: act_connmark method rename for grep-ability and consistency
2018-08-13 09:06:16 -07:00
act_csum.c
net: sched: act_sum method rename for grep-ability and consistency
2018-08-13 09:06:16 -07:00
act_gact.c
net: sched: act_gact method rename for grep-ability and consistency
2018-08-13 09:06:16 -07:00
act_ife.c
net: sched: act_ife: disable bh when taking ife_mod_lock
2018-08-13 11:45:06 -07:00
act_ipt.c
net: sched: act_ipt method rename for grep-ability and consistency
2018-08-13 09:06:16 -07:00
act_meta_mark.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
act_meta_skbprio.c
net sched actions: change IFE modules alias names
2017-10-12 22:13:20 -07:00
act_meta_skbtcindex.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
act_mirred.c
net: sched: act_mirred method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
act_nat.c
net: sched: act_nat method rename for grep-ability and consistency
2018-08-13 09:06:16 -07:00
act_pedit.c
net: sched: act_pedit method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
act_police.c
net: sched: act_police method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
act_sample.c
net: sched: act_sample: remove dependency on rtnl lock
2018-08-11 12:37:09 -07:00
act_simple.c
net: sched: act_simple method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
act_skbedit.c
net: sched: act_skbedit method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
act_skbmod.c
net: sched: act_skbmod method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
act_tunnel_key.c
net: sched: act_tunnel_key: remove dependency on rtnl lock
2018-08-11 12:37:10 -07:00
act_vlan.c
net: sched: act_vlan method rename for grep-ability and consistency
2018-08-13 09:06:17 -07:00
cls_api.c
net: sched: extend action ops with put_dev callback
2018-08-11 12:37:10 -07:00
cls_basic.c
sched: fix trailing whitespace
2018-07-24 14:10:42 -07:00
cls_bpf.c
cls_bpf: Use kmemdup instead of duplicating it in cls_bpf_prog_from_ops
2018-07-29 13:19:49 -07:00
cls_cgroup.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_flow.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_flower.c
net: sched: cls_flower: set correct offload data in fl_reoffload
2018-08-07 12:35:17 -07:00
cls_fw.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_matchall.c
net: sched: cls_matchall: implement offload tcf_proto_op
2018-06-26 23:21:33 +09:00
cls_route.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_tcindex.c
net_sched: Fix missing res info when create new tc_index filter
2018-08-13 19:37:42 -07:00
cls_u32.c
net: sched: cls_u32: implement offload tcf_proto_op
2018-06-26 23:21:33 +09:00
em_canid.c
net: sched: remove tcf_proto from ematch calls
2014-10-06 18:02:32 -04:00
em_cmp.c
…
em_ipset.c
netfilter: x_tables: move hook state into xt_action_param structure
2016-11-03 10:56:21 +01:00
em_ipt.c
net: sched: add em_ipt ematch for calling xtables matches
2018-02-21 13:15:33 -05:00
em_meta.c
net: convert sock.sk_refcnt from atomic_t to refcount_t
2017-07-01 07:39:08 -07:00
em_nbyte.c
net: sched: em_nbyte: don't add the data offset twice
2018-01-24 14:52:40 -05:00
em_text.c
net: Remove state argument from skb_find_text()
2015-02-22 15:59:54 -05:00
em_u32.c
…
ematch.c
net: sched: ematch: obtain net pointer from blocks
2017-10-16 21:00:40 +01:00
Kconfig
net/sched: add skbprio scheduler
2018-07-24 14:44:00 -07:00
Makefile
net/sched: add skbprio scheduler
2018-07-24 14:44:00 -07:00
sch_api.c
net/sched: Allow creating a Qdisc watchdog with other clocks
2018-07-04 22:30:27 +09:00
sch_atm.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_blackhole.c
net_sched: blackhole: tell upper qdisc about dropped packets
2018-06-17 08:42:33 +09:00
sch_cake.c
sch_cake: Make gso-splitting configurable from userspace
2018-07-27 13:38:20 -07:00
sch_cbq.c
net: sch: sch_cbq: add extack support
2017-12-21 12:32:51 -05:00
sch_cbs.c
cbs: Add support for the graft function
2018-07-26 13:58:30 -07:00
sch_choke.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_codel.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_drr.c
net: sch: sch_drr: add extack support
2017-12-21 12:32:51 -05:00
sch_dsmark.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_etf.c
net/sched: Make etf report drops on error_queue
2018-07-04 22:30:28 +09:00
sch_fifo.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_fq_codel.c
sch_fq_codel: zero q->flows_cnt when fq_codel_init fails
2018-07-12 12:32:09 -07:00
sch_fq.c
net_sched: fq: take care of throttled flows before reuse
2018-05-02 16:37:38 -04:00
sch_generic.c
net: remove bypassed check in sch_direct_xmit()
2018-05-31 13:26:19 -04:00
sch_gred.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_hfsc.c
net_sched: remove a bogus warning in hfsc
2018-06-23 10:58:46 +09:00
sch_hhf.c
treewide: kvzalloc() -> kvcalloc()
2018-06-12 16:19:22 -07:00
sch_htb.c
net_sched: remove unused htb drop_list
2018-06-24 16:42:46 +09:00
sch_ingress.c
net: sched: allow ingress and clsact qdiscs to share filter blocks
2018-01-17 14:53:57 -05:00
sch_mq.c
net: sched: mq: request stats from offloads
2018-05-29 09:49:16 -04:00
sch_mqprio.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_multiq.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_netem.c
netem: slotting with non-uniform distribution
2018-06-28 22:06:24 +09:00
sch_pie.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_plug.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_prio.c
net: sch: prio: Add offload ability for grafting a child
2018-02-28 12:06:01 -05:00
sch_qfq.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_red.c
net: sched: red: avoid hashing NULL child
2018-05-18 13:52:32 -04:00
sch_sfb.c
net: sch: api: add extack support in qdisc_create_dflt
2017-12-21 12:32:51 -05:00
sch_sfq.c
net: sch: api: add extack support in tcf_block_get
2017-12-21 12:32:51 -05:00
sch_skbprio.c
net/sched: add skbprio scheduler
2018-07-24 14:44:00 -07:00
sch_tbf.c
net: sched: red: avoid hashing NULL child
2018-05-18 13:52:32 -04:00
sch_teql.c
net: sched: sch: add extack for init callback
2017-12-21 12:32:50 -05:00