linux

iv/linux

History

Maxim Mikityanskiy f01204ec8b ethtool: Don't omit the netlink reply if no features were changed

The legacy ethtool userspace tool shows an error when no features could
be changed. It's useful to have a netlink reply to be able to show this
error when __netdev_update_features wasn't called, for example:

1. ethtool -k eth0
   large-receive-offload: off
2. ethtool -K eth0 rx-fcs on
3. ethtool -K eth0 lro on
   Could not change any device features
   rx-lro: off [requested on]
4. ethtool -K eth0 lro on
   # The output should be the same, but without this patch the kernel
   # doesn't send the reply, and ethtool is unable to detect the error.

This commit makes ethtool-netlink always return a reply when requested,
and it still avoids unnecessary calls to __netdev_update_features if the
wanted features haven't changed.

Fixes: 0980bfcd6954 ("ethtool: set netdev features with FEATURES_SET request")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

2020-08-18 16:00:24 -07:00

bitset.c

ethtool: add ethnl_parse_bitset() helper

2020-03-12 15:32:32 -07:00

bitset.h

ethtool: add ethnl_parse_bitset() helper

2020-03-12 15:32:32 -07:00

cabletest.c

net: ethtool: Remove PHYLIB direct dependency

2020-07-07 15:41:05 -07:00

channels.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next