7b6b51234d
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes). This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here. We close both issues by
moving to a suitable array in the iio_priv() data with alignment
explicitly requested. This data is allocated with kzalloc() so no
data can leak apart from previous readings.
In this driver, depending on which channels are enabled, the timestamp
can be in a number of locations. Hence we cannot use a structure
to specify the data layout without it being misleading.
Fixes: 77c4ad2d6a ("iio: imu: Add initial support for Bosch BMI160")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200920112742.170751-6-jic23@kernel.org
32 lines
904 B
C
32 lines
904 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef BMI160_H_
|
|
#define BMI160_H_
|
|
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/regulator/consumer.h>
|
|
|
|
struct bmi160_data {
|
|
struct regmap *regmap;
|
|
struct iio_trigger *trig;
|
|
struct regulator_bulk_data supplies[2];
|
|
struct iio_mount_matrix orientation;
|
|
/*
|
|
* Ensure natural alignment for timestamp if present.
|
|
* Max length needed: 2 * 3 channels + 4 bytes padding + 8 byte ts.
|
|
* If fewer channels are enabled, less space may be needed, as
|
|
* long as the timestamp is still aligned to 8 bytes.
|
|
*/
|
|
__le16 buf[12] __aligned(8);
|
|
};
|
|
|
|
extern const struct regmap_config bmi160_regmap_config;
|
|
|
|
int bmi160_core_probe(struct device *dev, struct regmap *regmap,
|
|
const char *name, bool use_spi);
|
|
|
|
int bmi160_enable_irq(struct regmap *regmap, bool enable);
|
|
|
|
int bmi160_probe_trigger(struct iio_dev *indio_dev, int irq, u32 irq_type);
|
|
|
|
#endif /* BMI160_H_ */
|