Eric Dumazet
2750d7641d
netlink: annotate data-races around sk->sk_err ...
commit d0f95894fda7d4f895b29c1097f92d7fee278cb2 upstream.
syzbot caught another data-race in netlink when
setting sk->sk_err.
Annotate all of them for good measure.
BUG: KCSAN: data-race in netlink_recvmsg / netlink_recvmsg
write to 0xffff8881613bb220 of 4 bytes by task 28147 on cpu 0:
netlink_recvmsg+0x448/0x780 net/netlink/af_netlink.c:1994
sock_recvmsg_nosec net/socket.c:1027 [inline]
sock_recvmsg net/socket.c:1049 [inline]
__sys_recvfrom+0x1f4/0x2e0 net/socket.c:2229
__do_sys_recvfrom net/socket.c:2247 [inline]
__se_sys_recvfrom net/socket.c:2243 [inline]
__x64_sys_recvfrom+0x78/0x90 net/socket.c:2243
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
write to 0xffff8881613bb220 of 4 bytes by task 28146 on cpu 1:
netlink_recvmsg+0x448/0x780 net/netlink/af_netlink.c:1994
sock_recvmsg_nosec net/socket.c:1027 [inline]
sock_recvmsg net/socket.c:1049 [inline]
__sys_recvfrom+0x1f4/0x2e0 net/socket.c:2229
__do_sys_recvfrom net/socket.c:2247 [inline]
__se_sys_recvfrom net/socket.c:2243 [inline]
__x64_sys_recvfrom+0x78/0x90 net/socket.c:2243
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
value changed: 0x00000000 -> 0x00000016
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 28146 Comm: syz-executor.0 Not tainted 6.6.0-rc3-syzkaller-00055-g9ed22ae6be81 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20231003183455.3410550-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: yenchia.chen <yenchia.chen@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-05-25 16:20:17 +02:00
2024-01-05 15:13:34 +01:00
2022-12-31 13:14:42 +01:00
2024-02-23 08:54:27 +01:00
2023-12-20 15:17:37 +01:00
2023-12-20 15:17:35 +01:00
2022-06-22 14:22:01 +02:00
2024-04-17 11:15:13 +02:00
2024-05-17 11:50:57 +02:00
2022-12-31 13:14:11 +01:00
2024-05-17 11:50:58 +02:00
2023-03-17 08:48:54 +01:00
2024-02-23 08:55:10 +01:00
2023-10-19 23:05:36 +02:00
2024-05-17 11:51:05 +02:00
2023-08-11 15:13:53 +02:00
2023-11-28 16:56:22 +00:00
2024-01-25 14:52:46 -08:00
2024-04-27 17:05:29 +02:00
2024-05-02 16:24:49 +02:00
2024-01-25 14:52:54 -08:00
2024-03-26 18:21:36 -04:00
2022-11-03 23:59:14 +09:00
2024-01-05 15:13:29 +01:00
2024-05-17 11:50:57 +02:00
2024-05-17 11:50:58 +02:00
2024-03-26 18:21:13 -04:00
2024-03-26 18:21:23 -04:00
2023-08-26 14:23:32 +02:00
2024-05-17 11:50:48 +02:00
2022-04-27 14:38:53 +02:00
2024-02-23 08:54:54 +01:00
2024-05-17 11:50:52 +02:00
2024-04-10 16:18:39 +02:00
2023-10-25 11:58:59 +02:00
2023-02-22 12:57:09 +01:00
2024-05-17 11:51:03 +02:00
2024-01-25 14:52:36 -08:00
2024-05-02 16:24:46 +02:00
2024-01-25 14:52:33 -08:00
2024-05-25 16:20:17 +02:00
2024-03-15 10:48:17 -04:00
2024-04-10 16:19:35 +02:00
2024-05-17 11:50:48 +02:00
2024-05-02 16:24:45 +02:00
2024-03-26 18:21:35 -04:00
2024-05-17 11:50:58 +02:00
2023-12-13 18:36:37 +01:00
2024-01-25 14:52:30 -08:00
2024-04-10 16:19:37 +02:00
2024-01-05 15:13:34 +01:00
2024-01-05 15:13:29 +01:00
2024-02-23 08:54:58 +01:00
2024-04-10 16:19:38 +02:00
2023-10-10 21:59:08 +02:00
2024-04-13 13:01:44 +02:00
2024-05-25 16:20:16 +02:00
2024-05-17 11:51:04 +02:00
2024-05-25 16:20:17 +02:00
2024-05-02 16:24:47 +02:00
2024-01-25 14:52:38 -08:00
2024-05-17 11:50:52 +02:00
2024-03-26 18:21:23 -04:00
2024-04-17 11:15:14 +02:00
2024-05-17 11:50:57 +02:00
2023-06-21 15:59:15 +02:00
2023-06-21 15:59:15 +02:00
2024-01-15 18:51:16 +01:00
2750d7641d