John Starks
04edfa3dc0
mm/gup: fix gup_pud_range() for dax
...
commit fcd0ccd836ffad73d98a66f6fea7b16f735ea920 upstream.
For dax pud, pud_huge() returns true on x86. So the function works as long
as hugetlb is configured. However, dax doesn't depend on hugetlb.
Commit 414fd080d125 ("mm/gup: fix gup_pmd_range() for dax") fixed
devmap-backed huge PMDs, but missed devmap-backed huge PUDs. Fix this as
well.
This fixes the below kernel panic:
general protection fault, probably for non-canonical address 0x69e7c000cc478: 0000 [#1 ] SMP
< snip >
Call Trace:
<TASK>
get_user_pages_fast+0x1f/0x40
iov_iter_get_pages+0xc6/0x3b0
? mempool_alloc+0x5d/0x170
bio_iov_iter_get_pages+0x82/0x4e0
? bvec_alloc+0x91/0xc0
? bio_alloc_bioset+0x19a/0x2a0
blkdev_direct_IO+0x282/0x480
? __io_complete_rw_common+0xc0/0xc0
? filemap_range_has_page+0x82/0xc0
generic_file_direct_write+0x9d/0x1a0
? inode_update_time+0x24/0x30
__generic_file_write_iter+0xbd/0x1e0
blkdev_write_iter+0xb4/0x150
? io_import_iovec+0x8d/0x340
io_write+0xf9/0x300
io_issue_sqe+0x3c3/0x1d30
? sysvec_reschedule_ipi+0x6c/0x80
__io_queue_sqe+0x33/0x240
? fget+0x76/0xa0
io_submit_sqes+0xe6a/0x18d0
? __fget_light+0xd1/0x100
__x64_sys_io_uring_enter+0x199/0x880
? __context_tracking_enter+0x1f/0x70
? irqentry_exit_to_user_mode+0x24/0x30
? irqentry_exit+0x1d/0x30
? __context_tracking_exit+0xe/0x70
do_syscall_64+0x3b/0x90
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fc97c11a7be
< snip >
</TASK>
---[ end trace 48b2e0e67debcaeb ]---
RIP: 0010:internal_get_user_pages_fast+0x340/0x990
< snip >
Kernel panic - not syncing: Fatal exception
Kernel Offset: disabled
Link: https://lkml.kernel.org/r/1670392853-28252-1-git-send-email-ssengar@linux.microsoft.com
Fixes: 414fd080d125 ("mm/gup: fix gup_pmd_range() for dax")
Signed-off-by: John Starks <jostarks@microsoft.com>
Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Yu Zhao <yuzhao@google.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-12-14 11:30:43 +01:00
..
2021-01-27 11:47:53 +01:00
2021-12-14 14:49:00 +01:00
2019-09-04 07:42:01 -04:00
2019-07-12 12:24:03 -07:00
2019-05-14 09:47:45 -07:00
2020-09-03 11:26:51 +02:00
2022-06-14 18:11:46 +02:00
2020-03-05 16:43:51 +01:00
2019-07-12 11:05:46 -07:00
2019-08-30 22:43:58 -07:00
2019-07-12 11:05:43 -07:00
2022-11-25 17:42:22 +01:00
2022-12-08 11:23:06 +01:00
2019-06-19 17:09:52 +02:00
2020-01-09 10:20:00 +01:00
2022-12-14 11:30:43 +01:00
2018-12-28 12:11:47 -08:00
2019-09-07 04:28:04 -03:00
2021-07-14 16:53:47 +02:00
2019-11-15 18:34:00 -08:00
2022-11-03 23:56:54 +09:00
2019-06-03 15:39:40 +02:00
2019-10-19 06:32:32 -04:00
2021-06-30 08:47:52 -04:00
2019-06-19 17:09:08 +02:00
2020-12-16 10:56:59 +01:00
2019-09-24 15:54:08 -07:00
2022-12-14 11:30:42 +01:00
2019-06-05 17:37:06 +02:00
2022-09-15 12:04:49 +02:00
2021-05-19 10:08:27 +02:00
2020-12-11 13:23:31 +01:00
2020-01-17 19:48:40 +01:00
2022-10-05 10:37:43 +02:00
2019-09-24 15:54:10 -07:00
2022-03-02 11:41:18 +01:00
2022-12-14 11:30:43 +01:00
2022-03-08 19:07:49 +01:00
2021-09-22 12:26:43 +02:00
2021-06-23 14:41:23 +02:00
2022-05-15 19:54:47 +02:00
2022-07-29 17:14:16 +02:00
2019-03-05 21:07:20 -08:00
2020-01-09 10:19:56 +01:00
2022-10-05 10:37:43 +02:00
2019-09-25 17:51:41 -07:00
2019-09-25 17:51:41 -07:00
2019-05-21 10:50:45 +02:00
2022-09-20 12:28:00 +02:00
2020-09-03 11:26:51 +02:00
2022-12-14 11:30:42 +01:00
2019-11-06 08:47:50 -08:00
2022-05-15 19:54:46 +02:00
2020-03-12 13:00:19 +01:00
2022-08-25 11:17:20 +02:00
2019-09-25 17:51:41 -07:00
2020-03-25 08:25:58 +01:00
2022-04-27 13:50:48 +02:00
2022-10-05 10:37:43 +02:00
2020-08-21 13:05:27 +02:00
2019-10-14 15:04:00 -07:00
2019-06-29 16:43:45 +08:00
2022-05-12 12:23:48 +02:00
2020-09-23 12:40:47 +02:00
2020-10-29 09:57:52 +01:00
2019-09-24 15:54:08 -07:00
2021-06-30 08:47:55 -04:00
2020-01-23 08:22:41 +01:00
2022-10-15 07:54:36 +02:00
2019-03-13 12:25:31 -07:00
2019-06-05 17:37:16 +02:00
2019-06-05 17:37:16 +02:00
2019-06-05 17:37:16 +02:00
2020-09-23 12:40:45 +02:00
2021-06-30 08:47:52 -04:00
2019-05-30 11:26:32 -07:00
2019-05-21 10:50:45 +02:00
2022-09-05 10:27:46 +02:00
2019-06-05 17:37:17 +02:00
2022-01-27 09:19:29 +01:00
2020-09-03 11:26:51 +02:00
2019-05-14 19:52:48 -07:00
2021-07-25 14:35:14 +02:00
2020-01-23 08:22:40 +01:00
2021-11-26 10:47:21 +01:00
2019-10-07 15:47:20 -07:00
2022-09-28 11:04:04 +02:00
2019-07-18 17:08:07 -07:00
2021-05-14 09:44:32 +02:00
2018-08-22 10:52:44 -07:00
2020-10-01 13:18:08 +02:00
2019-09-25 17:51:41 -07:00
2021-03-07 12:20:49 +01:00
2021-06-30 08:47:53 -04:00
2022-04-15 14:18:30 +02:00
2022-05-15 19:54:47 +02:00
2022-06-22 14:11:17 +02:00
2018-09-13 15:18:04 -10:00
2020-09-03 11:26:52 +02:00
2019-10-07 15:47:19 -07:00
2021-09-22 12:26:37 +02:00
2022-05-15 19:54:46 +02:00
2019-08-13 16:06:52 -07:00
2021-07-14 16:53:47 +02:00
2019-05-21 10:50:45 +02:00
2019-09-24 15:54:12 -07:00
2022-06-06 08:33:50 +02:00
2019-09-24 15:54:12 -07:00