Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-07-22 19:39:14 -04:00
2008-05-22 14:12:39 -04:00
2008-07-22 16:09:13 -04:00
2008-03-26 00:18:44 -04:00
2008-07-21 21:55:03 -07:00
2008-03-17 08:11:03 -04:00
2006-09-13 13:24:59 -04:00
2008-01-28 15:04:05 -08:00
2006-09-13 13:24:59 -04:00
2006-09-13 13:24:59 -04:00
2008-06-10 18:20:17 -04:00
2006-09-13 13:24:59 -04:00
2008-03-26 00:18:43 -04:00
2007-10-10 16:51:43 -07:00
2008-04-29 01:56:14 -04:00
2006-09-13 13:24:59 -04:00
2008-07-18 17:54:17 -07:00
2008-05-16 22:20:27 -07:00
2008-07-18 17:58:57 -07:00
2008-07-18 17:55:11 -07:00
2008-06-23 20:33:36 -07:00
2008-06-23 20:27:26 -07:00
2008-06-23 20:36:51 -07:00
2008-06-23 20:33:01 -07:00
2008-06-23 20:34:36 -07:00
2008-01-04 00:47:04 -08:00
2006-09-13 13:24:59 -04:00
2008-03-26 00:18:43 -04:00
2007-02-09 16:23:17 +00:00
2006-09-13 13:24:59 -04:00
2008-02-01 20:54:03 +11:00
2008-07-22 17:54:07 -04:00
2007-10-10 16:51:13 -07:00
2007-10-10 16:51:13 -07:00
2008-01-28 15:07:59 -08:00
2008-04-29 01:56:01 -04:00
2008-06-17 23:07:29 -04:00
2007-10-19 11:53:42 -07:00
2006-09-13 13:24:59 -04:00
2008-05-01 08:08:36 -07:00
2008-07-22 17:12:37 +10:00
2008-07-22 17:12:37 +10:00
2008-05-22 14:12:40 -04:00
2008-01-28 15:07:12 -08:00
2006-09-13 13:24:59 -04:00
2008-07-22 17:50:44 -04:00
2008-07-22 17:50:44 -04:00
2008-02-03 04:26:12 -08:00
2007-10-10 16:50:46 -07:00
2008-07-17 19:21:30 -07:00
2008-03-17 08:11:41 -04:00
2008-04-25 02:08:51 -04:00
2008-06-11 22:06:31 -04:00
2008-01-28 15:04:05 -08:00
2008-01-28 15:07:12 -08:00
2008-07-22 19:34:21 -04:00
2007-10-19 11:53:42 -07:00
2007-04-28 11:01:05 -04:00
2008-02-03 04:28:10 -08:00
2008-07-22 19:56:37 -04:00
2008-07-22 17:50:44 -04:00
2008-03-17 07:56:33 -04:00
2008-07-22 17:50:44 -04:00
2008-03-26 00:18:04 -04:00
2008-03-26 00:18:00 -04:00
2006-09-13 13:24:59 -04:00
2007-10-23 21:28:40 -04:00
2008-07-17 19:21:17 -07:00
2008-05-30 22:19:22 -04:00
2008-03-05 16:34:41 -06:00
2008-07-20 17:12:34 -07:00
2008-01-28 15:11:27 -08:00
2008-07-20 17:12:34 -07:00
2008-06-20 21:58:02 -07:00
2008-01-28 15:08:00 -08:00
2008-07-22 20:00:01 -04:00
2008-01-28 15:03:59 -08:00
2008-07-17 19:21:07 -07:00
2008-07-11 01:11:40 -04:00
2008-04-16 20:41:44 -04:00
2008-05-30 22:07:17 -04:00
2008-06-28 10:23:33 -04:00
2006-09-13 13:24:59 -04:00
2007-10-16 21:10:29 -04:00
2008-06-17 23:59:39 -04:00
2008-01-28 15:11:27 -08:00
2008-07-20 17:12:34 -07:00
2006-09-13 13:24:59 -04:00
2008-01-28 15:03:59 -08:00
2007-05-04 17:59:08 -07:00
2007-07-16 15:02:47 +02:00
2008-04-16 20:06:50 -04:00
2007-10-10 16:51:13 -07:00
2008-02-03 04:26:15 -08:00
2008-01-28 15:03:46 -08:00
2008-03-23 03:35:12 -07:00
2008-01-28 15:07:10 -08:00
2008-01-28 15:07:09 -08:00
2008-02-03 04:26:14 -08:00
2007-10-10 16:51:34 -07:00
2008-05-29 01:38:46 -07:00
2008-05-30 22:18:02 -04:00
2008-05-30 22:18:02 -04:00
2008-07-22 17:54:17 -04:00