Trond Myklebust c6c15e1ed3 nfsd: Fix slot wake up race in the nfsv4.1 callback code
The currect code for nfsd41_cb_get_slot() and nfsd4_cb_done() has no
locking in order to guarantee atomicity, and so allows for races of
the form.

Task 1                                  Task 2
======                                  ======
if (test_and_set_bit(0) != 0) {
                                        clear_bit(0)
                                        rpc_wake_up_next(queue)
        rpc_sleep_on(queue)
        return false;
}

This patch breaks the race condition by adding a retest of the bit
after the call to rpc_sleep_on().

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
2014-11-19 15:45:44 -05:00
..
2014-10-09 02:39:04 -04:00
2014-08-08 15:57:24 -07:00
2014-10-14 08:40:15 +02:00
2014-11-13 22:19:05 +03:00
2014-10-17 17:17:12 -05:00
2014-08-08 15:57:20 -07:00
2014-10-09 02:38:57 -04:00
2014-08-07 14:40:09 -04:00
2014-10-16 12:53:35 +01:00
2014-11-05 08:49:38 -05:00
2014-10-09 13:06:14 +02:00
2014-11-07 08:33:52 +11:00
2014-09-24 13:31:50 -04:00
2014-08-07 14:40:09 -04:00
2014-10-24 00:14:38 +02:00
2014-10-24 00:14:38 +02:00
2014-10-24 00:14:35 +02:00
2014-08-26 09:35:56 +02:00
2014-08-27 11:17:48 +02:00