Martin K. Petersen b5fc07a5fb scsi: core: Consult supported VPD page list prior to fetching page ... Commit c92a6b5d63 ("scsi: core: Query VPD size before getting full page") removed the logic which checks whether a VPD page is present on the supported pages list before asking for the page itself. That was done because SPC helpfully states "The Supported VPD Pages VPD page list may or may not include all the VPD pages that are able to be returned by the device server". Testing had revealed a few devices that supported some of the 0xBn pages but didn't actually list them in page 0. Julian Sikorski bisected a problem with his drive resetting during discovery to the commit above. As it turns out, this particular drive firmware will crash if we attempt to fetch page 0xB9. Various approaches were attempted to work around this. In the end, reinstating the logic that consults VPD page 0 before fetching any other page was the path of least resistance. A firmware update for the devices which originally compelled us to remove the check has since been released. Link: https://lore.kernel.org/r/20240214221411.2888112-1-martin.petersen@oracle.com Fixes: c92a6b5d63 ("scsi: core: Query VPD size before getting full page") Cc: stable@vger.kernel.org Cc: Bart Van Assche <bvanassche@acm.org> Reported-by: Julian Sikorski <belegdol@gmail.com> Tested-by: Julian Sikorski <belegdol@gmail.com> Reviewed-by: Lee Duncan <lee.duncan@suse.com> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2024-02-15 14:41:26 -05:00
..
fc
fc_frame.h
fcoe_sysfs.h
iscsi_if.h
iscsi_proto.h
iser.h
libfc.h	scsi: core: Declare SCSI host template pointer members const	2023-03-24 19:19:19 -04:00
libfcoe.h	driver core: bus: mark the struct bus_type for sysfs callbacks as constant	2023-03-23 13:20:40 +01:00
libiscsi_tcp.h
libiscsi.h	scsi: iscsi: Declare SCSI host template const	2023-03-24 19:19:57 -04:00
libsas.h	scsi: libsas: Declare sas_discover_end_dev() static	2023-09-13 21:06:44 -04:00
sas_ata.h	scsi: libsas: Factor out sas_ata_add_dev()	2022-12-30 16:59:11 +00:00
sas.h
scsi_bsg_iscsi.h
scsi_cmnd.h	scsi: core: Allow libata to complete successful commands via EH	2023-05-22 17:05:18 -04:00
scsi_common.h	scsi: Add support for block PR read keys/reservation	2023-04-11 21:55:35 -04:00
scsi_dbg.h
scsi_device.h	scsi: core: Consult supported VPD page list prior to fetching page	2024-02-15 14:41:26 -05:00
scsi_devinfo.h	scsi: core: Add BLIST_NO_VPD_SIZE for some VDASD	2023-03-09 20:57:58 -05:00
scsi_dh.h
scsi_driver.h
scsi_eh.h
scsi_host.h	SCSI misc on 20231102	2023-11-02 15:13:50 -10:00
scsi_ioctl.h	scsi: replace the fmode_t argument to scsi_ioctl with a simple bool	2023-06-12 08:04:04 -06:00
scsi_proto.h	scsi: Add support for block PR read keys/reservation	2023-04-11 21:55:35 -04:00
scsi_status.h
scsi_tcq.h
scsi_transport_fc.h	scsi: scsi_transport_fc: Add an additional flag to fc_host_fpin_rcv()	2023-02-21 18:03:29 -05:00
scsi_transport_iscsi.h	scsi: iscsi: Remove unused extern declaration iscsi_lookup_iface()	2023-07-25 21:55:11 -04:00
scsi_transport_sas.h
scsi_transport_spi.h
scsi_transport_srp.h	scsi: core: Change the return type of .eh_timed_out()	2022-10-22 03:25:59 +00:00
scsi_transport.h
scsi.h	scsi: core: ata: Do no try to probe for CDL on old drives	2023-09-21 21:07:23 -04:00
scsicam.h
sg.h	scsi: core: Rename status_byte to sg_status_byte	2022-12-01 03:22:23 +00:00
srp.h
viosrp.h