ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
74 lines
1.8 KiB
C
74 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* cyttsp_i2c.c
|
|
* Cypress TrueTouch(TM) Standard Product (TTSP) I2C touchscreen driver.
|
|
* For use with Cypress Txx4xx parts.
|
|
* Supported parts include:
|
|
* TMA4XX
|
|
* TMA1036
|
|
*
|
|
* Copyright (C) 2009, 2010, 2011 Cypress Semiconductor, Inc.
|
|
* Copyright (C) 2012 Javier Martinez Canillas <javier@dowhile0.org>
|
|
* Copyright (C) 2013 Cypress Semiconductor
|
|
*
|
|
* Contact Cypress Semiconductor at www.cypress.com <ttdrivers@cypress.com>
|
|
*/
|
|
|
|
#include "cyttsp4_core.h"
|
|
|
|
#include <linux/i2c.h>
|
|
#include <linux/input.h>
|
|
|
|
#define CYTTSP4_I2C_DATA_SIZE (3 * 256)
|
|
|
|
static const struct cyttsp4_bus_ops cyttsp4_i2c_bus_ops = {
|
|
.bustype = BUS_I2C,
|
|
.write = cyttsp_i2c_write_block_data,
|
|
.read = cyttsp_i2c_read_block_data,
|
|
};
|
|
|
|
static int cyttsp4_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct cyttsp4 *ts;
|
|
|
|
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
|
|
dev_err(&client->dev, "I2C functionality not Supported\n");
|
|
return -EIO;
|
|
}
|
|
|
|
ts = cyttsp4_probe(&cyttsp4_i2c_bus_ops, &client->dev, client->irq,
|
|
CYTTSP4_I2C_DATA_SIZE);
|
|
|
|
return PTR_ERR_OR_ZERO(ts);
|
|
}
|
|
|
|
static void cyttsp4_i2c_remove(struct i2c_client *client)
|
|
{
|
|
struct cyttsp4 *ts = i2c_get_clientdata(client);
|
|
|
|
cyttsp4_remove(ts);
|
|
}
|
|
|
|
static const struct i2c_device_id cyttsp4_i2c_id[] = {
|
|
{ CYTTSP4_I2C_NAME, 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, cyttsp4_i2c_id);
|
|
|
|
static struct i2c_driver cyttsp4_i2c_driver = {
|
|
.driver = {
|
|
.name = CYTTSP4_I2C_NAME,
|
|
.pm = &cyttsp4_pm_ops,
|
|
},
|
|
.probe = cyttsp4_i2c_probe,
|
|
.remove = cyttsp4_i2c_remove,
|
|
.id_table = cyttsp4_i2c_id,
|
|
};
|
|
|
|
module_i2c_driver(cyttsp4_i2c_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("Cypress TrueTouch(R) Standard Product (TTSP) I2C driver");
|
|
MODULE_AUTHOR("Cypress");
|