iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv4
History
Eric Dumazet ca2fe2956a tcp: add sanity tests in tcp_add_backlog() 
Richard and Bruno both reported that my commit added a bug,
and Bruno was able to determine the problem came when a segment
wih a FIN packet was coalesced to a prior one in tcp backlog queue.

It turns out the header prediction in tcp_rcv_established()
looks back to TCP headers in the packet, not in the metadata
(aka TCP_SKB_CB(skb)->tcp_flags)

The fast path in tcp_rcv_established() is not supposed to
handle a FIN flag (it does not call tcp_fin())

Therefore we need to make sure to propagate the FIN flag,
so that the coalesced packet does not go through the fast path,
the same than a GRO packet carrying a FIN flag.

While we are at it, make sure we do not coalesce packets with
RST or SYN, or if they do not have ACK set.

Many thanks to Richard and Bruno for pinpointing the bad commit,
and to Richard for providing a first version of the fix.

Fixes: 4f693b55c3d2 ("tcp: implement coalescing on backlog queue")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Reported-by: Bruno Prémont <bonbons@sysophe.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-04-29 23:20:37 -04:00
..
bpfilter
net: bpfilter: disallow to remove bpfilter module while being used
2019-01-11 18:05:41 -08:00
netfilter
netfilter: nf_tables: merge ipv4 and ipv6 nat chain types
2019-03-01 14:36:59 +01:00
af_inet.c
gso: validate gso_type on ipip style tunnels
2019-02-20 11:24:27 -08:00
ah4.c
net-ipv4: remove 2 always zero parameters from ipv4_redirect()
2018-09-26 20:30:55 -07:00
arp.c
net: Evict neighbor entries on carrier down
2018-10-12 09:47:39 -07:00
cipso_ipv4.c
netlabel: fix out-of-bounds memory accesses
2019-02-27 21:45:24 -08:00
datagram.c
ipv4: Allow sending multicast packets on specific i/f using VRF socket
2018-10-02 22:28:17 -07:00
devinet.c
net: ignore sysctl_devconf_inherit_init_net without SYSCTL
2019-03-04 13:14:34 -08:00
esp4_offload.c
net: use skb_sec_path helper in more places
2018-12-19 11:21:37 -08:00
esp4.c
esp: Skip TX bytes accounting when sending from a request socket
2019-01-28 11:20:58 +01:00
fib_frontend.c
ipv4: Return error for RTA_VIA attribute
2019-02-26 13:23:17 -08:00
fib_lookup.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fib_notifier.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
fib_rules.c
ipv4: fib_rules: Fix possible infinite loop in fib_empty_table
2018-12-30 12:57:04 -08:00
fib_semantics.c
ipv4: fib: use struct_size() in kzalloc()
2019-02-01 15:12:29 -08:00
fib_trie.c
net: ipv4: Fix memory leak in network namespace dismantle
2019-01-15 13:33:44 -08:00
fou.c
net: fou: do not use guehdr after iptunnel_pull_offloads in gue_udp_recv
2019-04-10 23:02:23 -07:00
gre_demux.c
net: ip_gre: use erspan key field for tunnel lookup
2019-01-22 11:52:17 -08:00
gre_offload.c
Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net
2018-07-03 10:29:26 +09:00
icmp.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-03-02 12:54:35 -08:00
igmp.c
net: remove unneeded switch fall-through
2019-02-21 13:48:00 -08:00
inet_connection_sock.c
inet: minor optimization for backlog setting in listen(2)
2018-11-07 22:31:07 -08:00
inet_diag.c
inet_diag: fix reporting cgroup classid and fallback to priority
2019-02-12 13:35:57 -05:00
inet_fragment.c
net: remove unused struct inet_frag_queue.fragments field
2019-02-26 08:27:05 -08:00
inet_hashtables.c
net: dccp: fix kernel crash on module load
2018-12-24 15:27:56 -08:00
inet_timewait_sock.c
soreuseport: initialise timewait reuseport field
2018-04-07 22:32:32 -04:00
inetpeer.c
net: ipv4: use a dedicated counter for icmp_v4 redirect packets
2019-02-08 21:50:15 -08:00
ip_forward.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-12-20 11:53:36 -08:00
ip_fragment.c
net: remove unused struct inet_frag_queue.fragments field
2019-02-26 08:27:05 -08:00
ip_gre.c
net: ip_gre: fix possible use-after-free in erspan_rcv
2019-04-08 16:16:47 -07:00
ip_input.c
vrf: check accept_source_route on the original netdevice
2019-04-01 10:44:58 -07:00
ip_options.c
vrf: check accept_source_route on the original netdevice
2019-04-01 10:44:58 -07:00
ip_output.c
sk_buff: add skb extension infrastructure
2018-12-19 11:21:37 -08:00
ip_sockglue.c
ip: on queued skb use skb_header_pointer instead of pskb_may_pull
2019-01-10 09:27:20 -05:00
ip_tunnel_core.c
ip_tunnel: Add dst_cache support in lwtunnel_state of ip tunnel
2019-02-24 22:13:49 -08:00
ip_tunnel.c
iptunnel: NULL pointer deref for ip_md_tunnel_xmit
2019-03-06 10:43:06 -08:00
ip_vti.c
vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel
2019-01-09 14:00:37 +01:00
ipcomp.c
net-ipv4: remove 2 always zero parameters from ipv4_redirect()
2018-09-26 20:30:55 -07:00
ipconfig.c
ipconfig: add carrier_timeout kernel parameter
2019-02-01 15:24:13 -08:00
ipip.c
ip_tunnel: Add tnl_update_pmtu in ip_md_tunnel_xmit
2019-01-26 09:43:03 -08:00
ipmr_base.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-10-19 11:03:06 -07:00
ipmr.c
ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs
2019-02-21 13:05:05 -08:00
Kconfig
net: remove blank lines at end of file
2018-07-24 14:10:43 -07:00
Makefile
bpf, sockmap: convert to generic sk_msg interface
2018-10-15 12:23:19 -07:00
metrics.c
net: Add extack argument to ip_fib_metrics_init
2018-11-06 15:00:45 -08:00
netfilter.c
netfilter: ipv4: remove useless export_symbol
2019-01-28 11:32:58 +01:00
netlink.c
ipv4: Add ICMPv6 support when parse route ipproto
2019-03-01 16:41:27 -08:00
ping.c
ipv4: Allow sending multicast packets on specific i/f using VRF socket
2018-10-02 22:28:17 -07:00
proc.c
tcp: implement coalescing on backlog queue
2018-11-30 13:26:54 -08:00
protocol.c
fou, fou6: ICMP error handlers for FoU and GUE
2018-11-08 17:13:08 -08:00
raw_diag.c
…
raw.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-12-20 11:53:36 -08:00
route.c
ipv4: add sanity checks in ipv4_link_failure()
2019-04-24 14:40:41 -07:00
syncookies.c
tcp: handle inet_csk_reqsk_queue_add() failures
2019-03-08 16:05:10 -08:00
sysctl_net_ipv4.c
ipv4: set the tcp_min_rtt_wlen range from 0 to one day
2019-04-17 13:57:11 -07:00
tcp_bbr.c
tcp_bbr: adapt cwnd based on ack aggregation estimation
2019-01-24 22:27:27 -08:00
tcp_bic.c
…
tcp_bpf.c
bpf: sk_msg, sock{map|hash} redirect through ULP
2018-12-20 23:47:09 +01:00
tcp_cdg.c
tcp: cdg: use tcp high resolution clock cache
2018-10-15 22:56:42 -07:00
tcp_cong.c
tcp: Namespace-ify sysctl_tcp_default_congestion_control
2017-11-15 14:09:52 +09:00
tcp_cubic.c
…
tcp_dctcp.c
dctcp: more accurate tracking of packets delivery
2019-04-11 21:31:03 -07:00
tcp_dctcp.h
tcp: refactor DCTCP ECN ACK handling
2018-10-10 22:26:00 -07:00
tcp_diag.c
net: sock: replace sk_state_load with inet_sk_state_load and remove sk_state_store
2017-12-20 14:00:25 -05:00
tcp_fastopen.c
tcp: pause Fast Open globally after third consecutive timeout
2017-12-13 15:51:12 -05:00
tcp_highspeed.c
…
tcp_htcp.c
…
tcp_hybla.c
…
tcp_illinois.c
net/tcp/illinois: replace broken algorithm reference link
2018-02-28 12:03:47 -05:00
tcp_input.c
tcp: tcp_grow_window() needs to respect tcp_space()
2019-04-16 21:47:39 -07:00
tcp_ipv4.c
tcp: add sanity tests in tcp_add_backlog()
2019-04-29 23:20:37 -04:00
tcp_lp.c
…
tcp_metrics.c
mm: convert totalram_pages and totalhigh_pages variables to atomic
2018-12-28 12:11:47 -08:00
tcp_minisocks.c
tcp: use tcp_md5_needed for timewait sockets
2019-02-26 13:16:03 -08:00
tcp_nv.c
tcp_nv: fix potential integer overflow in tcpnv_acked
2018-01-31 10:26:30 -05:00
tcp_offload.c
net: use indirect call wrappers at GRO transport layer
2018-12-15 13:23:02 -08:00
tcp_output.c
tcp: remove tcp_queue argument from tso_fragment()
2019-02-26 13:16:03 -08:00
tcp_rate.c
tcp: introduce tcp_skb_timestamp_us() helper
2018-09-21 19:37:59 -07:00
tcp_recovery.c
tcp: introduce tcp_skb_timestamp_us() helper
2018-09-21 19:37:59 -07:00
tcp_scalable.c
…
tcp_timer.c
tcp: Refactor pingpong code
2019-01-27 13:29:43 -08:00
tcp_ulp.c
tcp, ulp: remove socket lock assertion on ULP cleanup
2018-10-16 12:38:41 -07:00
tcp_vegas.c
tcp: fix under-evaluated ssthresh in TCP Vegas
2017-09-29 06:07:00 +01:00
tcp_vegas.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
tcp_veno.c
…
tcp_westwood.c
…
tcp_yeah.c
…
tcp.c
tcp: do not report TCP_CM_INQ of 0 for closed connections
2019-03-06 11:00:50 -08:00
tunnel4.c
net: Convert protocol error handlers from void to int
2018-11-08 17:13:08 -08:00
udp_diag.c
net: diag: document swapped src/dst in udp_dump_one.
2018-10-28 19:27:21 -07:00
udp_impl.h
udp: add missing rehash callback to udplite
2019-01-17 15:01:08 -08:00
udp_offload.c
udp: fix GRO reception in case of length mismatch
2019-04-27 22:07:24 -04:00
udp_tunnel.c
net/ipv4/udp_tunnel: prefer SO_BINDTOIFINDEX over SO_BINDTODEVICE
2019-01-17 14:55:52 -08:00
udp.c
udp: fix possible user after free in error handler
2019-02-22 16:05:11 -08:00
udplite.c
udp: add missing rehash callback to udplite
2019-01-17 15:01:08 -08:00
xfrm4_input.c
xfrm: reset transport header back to network header after all input transforms ahave been applied
2018-09-04 10:26:30 +02:00
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
xfrm: reset transport header back to network header after all input transforms ahave been applied
2018-09-04 10:26:30 +02:00
xfrm4_mode_tunnel.c
xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h_proto
2018-03-07 10:54:29 +01:00
xfrm4_output.c
net: xfrm: use skb_gso_validate_network_len() to check gso sizes
2018-03-04 17:49:17 -05:00
xfrm4_policy.c
net: Drop pernet_operations::async
2018-03-27 13:18:09 -04:00
xfrm4_protocol.c
net: Convert protocol error handlers from void to int
2018-11-08 17:13:08 -08:00
xfrm4_state.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xfrm4_tunnel.c
…