linux

iv/linux

History

Paul Menage 6c826818ff /proc/sysvipc/shm: fix 32-bit truncation of segment sizes

sysvipc_shm_proc_show() picks between format strings (based on the
expected maximum length of a SHM segment) in a way that prevents gcc from
performing format checks on the seq_printf() parameters.  This hid two
format errors - shp->shm_segsz and shp->shm_nattach are both unsigned
long, but were being printed as unsigned int and signed int respectively.
This leads to 32-bit truncation of SHM segment sizes reported in
/proc/sysvipc/shm.  (And for nattach, but that's less of a problem for
most users).

This patch makes the format string directly visible to gcc's format
specifier checker, and fixes the two broken format specifiers.

Signed-off-by: Paul Menage <menage@google.com>
Cc: Nadia Derbey <Nadia.Derbey@bull.net>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Pierre Peiffer <peifferp@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2008-06-12 18:05:41 -07:00

compat_mq.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

compat.c

fix logic error in ipc compat semctl()

2007-07-06 10:23:43 -07:00

ipc_sysctl.c

ipc: re-enable msgmni automatic recomputing msgmni if set to negative

2008-04-29 08:06:13 -07:00

ipcns_notifier.c

ipc: re-enable msgmni automatic recomputing msgmni if set to negative