Meng Li 69bef19d6b gpiolib: cdev: Set lineevent_state::irq after IRQ register successfully
When running gpio test on nxp-ls1028 platform with below command
gpiomon --num-events=3 --rising-edge gpiochip1 25
There will be a warning trace as below:
Call trace:
free_irq+0x204/0x360
lineevent_free+0x64/0x70
gpio_ioctl+0x598/0x6a0
__arm64_sys_ioctl+0xb4/0x100
invoke_syscall+0x5c/0x130
......
el0t_64_sync+0x1a0/0x1a4
The reason of this issue is that calling request_threaded_irq()
function failed, and then lineevent_free() is invoked to release
the resource. Since the lineevent_state::irq was already set, so
the subsequent invocation of free_irq() would trigger the above
warning call trace. To fix this issue, set the lineevent_state::irq
after the IRQ register successfully.

Fixes: 468242724143 ("gpiolib: cdev: refactor lineevent cleanup into lineevent_free")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
Reviewed-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
2022-09-21 09:32:11 +02:00
..
2022-01-11 12:31:35 -08:00
2021-04-14 10:19:22 +01:00
2022-08-04 18:34:05 -07:00
2021-05-05 16:07:41 +02:00
2022-06-23 23:18:13 +02:00
2022-06-21 18:01:11 +03:00
2022-06-06 14:09:16 +03:00
2022-04-01 10:26:09 -07:00
2021-11-08 11:55:21 -08:00
2022-01-14 18:50:52 -05:00
2022-08-04 18:34:05 -07:00
2022-08-04 18:34:05 -07:00
2022-06-05 09:12:28 -07:00