0ff375759f
The object ops i915_GEM_OBJECT_HAS_IOMEM and the object I915_BO_ALLOC_STRUCT_PAGE flags are considered immutable by much of our code. Introduce a new mem_flags member to hold these and make sure checks for these flags being set are either done under the object lock or with pages properly pinned. The flags will change during migration under the object lock. Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com> Signed-off-by: Matthew Auld <matthew.auld@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210624084240.270219-2-thomas.hellstrom@linux.intel.com
88 lines
1.9 KiB
C
88 lines
1.9 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2016 Intel Corporation
|
|
*/
|
|
|
|
#include "i915_selftest.h"
|
|
|
|
#include "selftests/mock_gem_device.h"
|
|
|
|
static int mock_phys_object(void *arg)
|
|
{
|
|
struct drm_i915_private *i915 = arg;
|
|
struct drm_i915_gem_object *obj;
|
|
int err;
|
|
|
|
/* Create an object and bind it to a contiguous set of physical pages,
|
|
* i.e. exercise the i915_gem_object_phys API.
|
|
*/
|
|
|
|
obj = i915_gem_object_create_shmem(i915, PAGE_SIZE);
|
|
if (IS_ERR(obj)) {
|
|
err = PTR_ERR(obj);
|
|
pr_err("i915_gem_object_create failed, err=%d\n", err);
|
|
goto out;
|
|
}
|
|
|
|
i915_gem_object_lock(obj, NULL);
|
|
if (!i915_gem_object_has_struct_page(obj)) {
|
|
i915_gem_object_unlock(obj);
|
|
err = -EINVAL;
|
|
pr_err("shmem has no struct page\n");
|
|
goto out_obj;
|
|
}
|
|
|
|
err = i915_gem_object_attach_phys(obj, PAGE_SIZE);
|
|
i915_gem_object_unlock(obj);
|
|
if (err) {
|
|
pr_err("i915_gem_object_attach_phys failed, err=%d\n", err);
|
|
goto out_obj;
|
|
}
|
|
|
|
if (i915_gem_object_has_struct_page(obj)) {
|
|
pr_err("i915_gem_object_attach_phys did not create a phys object\n");
|
|
err = -EINVAL;
|
|
goto out_obj;
|
|
}
|
|
|
|
if (!atomic_read(&obj->mm.pages_pin_count)) {
|
|
pr_err("i915_gem_object_attach_phys did not pin its phys pages\n");
|
|
err = -EINVAL;
|
|
goto out_obj;
|
|
}
|
|
|
|
/* Make the object dirty so that put_pages must do copy back the data */
|
|
i915_gem_object_lock(obj, NULL);
|
|
err = i915_gem_object_set_to_gtt_domain(obj, true);
|
|
i915_gem_object_unlock(obj);
|
|
if (err) {
|
|
pr_err("i915_gem_object_set_to_gtt_domain failed with err=%d\n",
|
|
err);
|
|
goto out_obj;
|
|
}
|
|
|
|
out_obj:
|
|
i915_gem_object_put(obj);
|
|
out:
|
|
return err;
|
|
}
|
|
|
|
int i915_gem_phys_mock_selftests(void)
|
|
{
|
|
static const struct i915_subtest tests[] = {
|
|
SUBTEST(mock_phys_object),
|
|
};
|
|
struct drm_i915_private *i915;
|
|
int err;
|
|
|
|
i915 = mock_gem_device();
|
|
if (!i915)
|
|
return -ENOMEM;
|
|
|
|
err = i915_subtests(tests, i915);
|
|
|
|
mock_destroy_device(i915);
|
|
return err;
|
|
}
|