iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/xfs
History
Eric Sandeen cc07eed833 xfs: ensure committed is initialized in xfs_trans_roll 
__xfs_trans_roll() can return without setting the
*committed argument; this was a problem for xfs_bmap_finish():

        int       committed;/* xact committed or not */
...
        error = __xfs_trans_roll(tp, ip, &committed);
        if (error) {
...
                if (committed) {

and we tested an uninitialized "committed" variable on the
error path.  No caller is preserving "committed" state across
calls to __xfs_trans_roll(), so just initialize committed inside
the function to avoid future errors like this.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-03-15 11:42:47 +11:00
..
libxfs
xfs: borrow indirect blocks from freed extent when available
2016-03-15 11:42:47 +11:00
Kconfig
xfs: require 64-bit sector_t
2014-07-30 09:12:05 +10:00
kmem.c
xfs: more info from kmem deadlocks and high-level error msgs
2015-10-12 16:04:45 +11:00
kmem.h
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
Makefile
xfs: stats are no longer dependent on CONFIG_PROC_FS
2015-10-19 08:42:46 +11:00
mrlock.h
…
uuid.c
…
uuid.h
…
xfs_acl.c
xfs: Change how listxattr generates synthetic attributes
2015-12-06 21:34:16 -05:00
xfs_acl.h
xfs: Change how listxattr generates synthetic attributes
2015-12-06 21:34:16 -05:00
xfs_aops.c
xfs: debug mode forced buffered write failure
2016-03-15 11:42:44 +11:00
xfs_aops.h
xfs: DAX does not use IO completion callbacks
2015-11-03 12:37:02 +11:00
xfs_attr_inactive.c
Merge branch 'xfs-misc-fixes-for-4.2-3' into for-next
2015-06-23 08:49:01 +10:00
xfs_attr_list.c
xfs: per-filesystem stats counter implementation
2015-10-12 18:21:22 +11:00
xfs_attr.h
…
xfs_bmap_util.c
xfs: eliminate committed arg from xfs_bmap_finish
2016-01-11 11:34:01 +11:00
xfs_bmap_util.h
xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate
2015-03-25 15:08:56 +11:00
xfs_buf_item.c
Merge branch 'xfs-misc-fixes-for-4.3-3' into for-next
2015-08-25 10:13:35 +10:00
xfs_buf_item.h
xfs: fix non-debug build warnings
2015-08-25 10:05:13 +10:00
xfs_buf.c
xfs: Update 2 for 4.5-rc1
2016-01-22 10:54:13 -08:00
xfs_buf.h
xfs: print name of verifier if it fails
2016-01-04 16:10:19 +11:00
xfs_dir2_readdir.c
xfs: per-filesystem stats counter implementation
2015-10-12 18:21:22 +11:00
xfs_discard.c
xfs: pass mp to XFS_WANT_CORRUPTED_GOTO
2015-02-23 22:39:08 +11:00
xfs_discard.h
…
xfs_dquot_item.c
xfs: move most of xfs_sb.h to xfs_format.h
2014-11-28 14:27:09 +11:00
xfs_dquot_item.h
…
xfs_dquot.c
xfs: eliminate committed arg from xfs_bmap_finish
2016-01-11 11:34:01 +11:00
xfs_dquot.h
xfs: fix implicit bool to int conversion
2015-01-09 10:48:58 +11:00
xfs_error.c
xfs: print name of verifier if it fails
2016-01-04 16:10:19 +11:00
xfs_error.h
xfs: remove inst_t
2015-06-22 09:44:02 +10:00
xfs_export.c
VFS: normal filesystems (and lustre): d_inode() annotations
2015-04-15 15:06:57 -04:00
xfs_export.h
…
xfs_extent_busy.c
xfs: merge xfs_ag.h into xfs_format.h
2014-11-28 14:25:04 +11:00
xfs_extent_busy.h
…
xfs_extfree_item.c
xfs: add helper to conditionally remove items from the AIL
2015-08-19 10:01:08 +10:00
xfs_extfree_item.h
xfs: fix efi/efd error handling to avoid fs shutdown hangs
2015-08-19 09:51:16 +10:00
xfs_file.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-01-23 12:24:56 -08:00
xfs_filestream.c
xfs: clean up XFS_MIN_FREELIST macros
2015-06-22 10:13:30 +10:00
xfs_filestream.h
xfs: add filestream allocator tracepoints
2014-04-23 07:11:52 +10:00
xfs_fsops.c
xfs: growfs not aware of sb_meta_uuid
2015-08-19 10:31:41 +10:00
xfs_fsops.h
…
xfs_globals.c
xfs: export log_recovery_delay to delay mount time log recovery
2014-09-09 11:56:13 +10:00
xfs_icache.c
xfs: per-filesystem stats counter implementation
2015-10-12 18:21:22 +11:00
xfs_icache.h
xfs: merge xfs_ag.h into xfs_format.h
2014-11-28 14:25:04 +11:00
xfs_icreate_item.c
xfs: move most of xfs_sb.h to xfs_format.h
2014-11-28 14:27:09 +11:00
xfs_icreate_item.h
…
xfs_inode_item.c
xfs: optimise away log forces on timestamp updates for fdatasync
2015-11-03 13:14:59 +11:00
xfs_inode_item.h
xfs: optimise away log forces on timestamp updates for fdatasync
2015-11-03 13:14:59 +11:00
xfs_inode.c
Merge branch 'xfs-setxattr-promotion' into for-next
2016-01-19 08:16:08 +11:00
xfs_inode.h
xfs: clean up inode lockdep annotations
2015-08-19 10:32:49 +10:00
xfs_ioctl32.c
xfs: prefix XATTR_LIST_MAX with XFS_
2015-10-12 16:02:56 +11:00
xfs_ioctl32.h
xfs: compat_xfs_bstat does not have forkoff
2014-10-02 09:17:58 +10:00
xfs_ioctl.c
xfs: introduce per-inode DAX enablement
2016-01-04 16:44:15 +11:00
xfs_ioctl.h
…
xfs_iomap.c
Merge branch 'xfs-misc-fixes-for-4.5-2' into for-next
2016-01-12 07:04:30 +11:00
xfs_iomap.h
xfs: pass a 64-bit count argument to xfs_iomap_write_unwritten
2015-01-09 10:48:12 +11:00
xfs_iops.c
xfs: Update 2 for 4.5-rc1
2016-01-22 10:54:13 -08:00
xfs_iops.h
xfs: inodes are new until the dentry cache is set up
2015-02-23 22:38:08 +11:00
xfs_itable.c
xfs: fix btree cursor error cleanups
2015-08-19 10:00:53 +10:00
xfs_itable.h
xfs: bulkstat chunk formatting cursor is broken
2014-11-07 08:30:30 +11:00
xfs_linux.h
xfs: pass xfsstats structures to handlers and macros
2015-10-12 05:19:45 +11:00
xfs_log_cil.c
xfs: close xc_cil list_empty() races with cil commit sequence
2015-07-29 11:51:01 +10:00
xfs_log_priv.h
xfs: debug mode log record crc error injection
2016-01-05 07:41:16 +11:00
xfs_log_recover.c
Merge branch 'xfs-misc-fixes-for-4.5-2' into for-next
2016-01-12 07:04:30 +11:00
xfs_log.c
Merge branch 'xfs-misc-fixes-for-4.5' into for-next
2016-01-05 08:08:35 +11:00
xfs_log.h
xfs: validate metadata LSNs against log on v5 superblocks
2015-10-12 15:59:25 +11:00
xfs_message.c
xfs: more info from kmem deadlocks and high-level error msgs
2015-10-12 16:04:45 +11:00
xfs_message.h
…
xfs_mount.c
Merge branch 'xfs-misc-fixes-for-4.4-2' into for-next
2015-11-03 13:27:58 +11:00
xfs_mount.h
xfs: debug mode forced buffered write failure
2016-03-15 11:42:44 +11:00
xfs_mru_cache.c
xfs: xfs_mru_cache_insert() should use GFP_NOFS
2015-03-25 14:57:53 +11:00
xfs_mru_cache.h
xfs: embedd mru_elem into parent structure
2014-04-23 07:11:51 +10:00
xfs_pnfs.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
xfs_pnfs.h
xfs: unlock i_mutex in xfs_break_layouts
2015-04-13 11:38:29 +10:00
xfs_qm_bhv.c
xfs: move most of xfs_sb.h to xfs_format.h
2014-11-28 14:27:09 +11:00
xfs_qm_syscalls.c
xfs: saner xfs_trans_commit interface
2015-06-04 13:48:08 +10:00
xfs_qm.c
xfs: updates for 4.4-rc1
2015-11-11 20:18:48 -08:00
xfs_qm.h
xfs: Convert to using ->get_state callback
2015-03-04 16:06:36 +01:00
xfs_quota.h
xfs: fix quota block reservation leak when tp allocates and frees blocks
2015-06-01 07:15:37 +10:00
xfs_quotaops.c
xfs: Add support for Q_SETINFO
2015-03-04 16:06:38 +01:00
xfs_rtalloc.c
xfs: eliminate committed arg from xfs_bmap_finish
2016-01-11 11:34:01 +11:00
xfs_rtalloc.h
xfs: combine xfs_rtmodify_summary and xfs_rtget_summary
2014-09-09 11:58:42 +10:00
xfs_stats.c
xfs: stats are no longer dependent on CONFIG_PROC_FS
2015-10-19 08:42:46 +11:00
xfs_stats.h
xfs: per-filesystem stats counter implementation
2015-10-12 18:21:22 +11:00
xfs_super.c
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
xfs_super.h
xfs: Remove icsb infrastructure
2015-02-23 21:22:31 +11:00
xfs_symlink.c
xfs: eliminate committed arg from xfs_bmap_finish
2016-01-11 11:34:01 +11:00
xfs_symlink.h
…
xfs_sysctl.c
xfs: pass xfsstats structures to handlers and macros
2015-10-12 05:19:45 +11:00
xfs_sysctl.h
xfs: export log_recovery_delay to delay mount time log recovery
2014-09-09 11:56:13 +10:00
xfs_sysfs.c
xfs: debug mode forced buffered write failure
2016-03-15 11:42:44 +11:00
xfs_sysfs.h
xfs: create global stats and stats_clear in sysfs
2015-10-12 05:15:45 +11:00
xfs_trace.c
xfs: move most of xfs_sb.h to xfs_format.h
2014-11-28 14:27:09 +11:00
xfs_trace.h
xfs: add tracepoints to readpage calls
2016-01-08 11:28:35 +11:00
xfs_trans_ail.c
Revert "xfs: clear PF_NOFREEZE for xfsaild kthread"
2016-01-19 08:21:46 +11:00
xfs_trans_buf.c
xfs: only trace buffer items if they exist
2015-02-10 09:23:40 +11:00
xfs_trans_dquot.c
xfs: send warning of project quota to userspace via netlink
2016-01-04 16:10:42 +11:00
xfs_trans_extfree.c
xfs: ensure EFD trans aborts on log recovery extent free failure
2015-08-19 09:51:43 +10:00
xfs_trans_inode.c
xfs: optimise away log forces on timestamp updates for fdatasync
2015-11-03 13:14:59 +11:00
xfs_trans_priv.h
xfs: add helper to conditionally remove items from the AIL
2015-08-19 10:01:08 +10:00
xfs_trans.c
xfs: ensure committed is initialized in xfs_trans_roll
2016-03-15 11:42:47 +11:00
xfs_trans.h
xfs: ensure EFD trans aborts on log recovery extent free failure
2015-08-19 09:51:43 +10:00
xfs_xattr.c
xfs: Change how listxattr generates synthetic attributes
2015-12-06 21:34:16 -05:00
xfs.h
…