linux

iv/linux

History

Zhang Changzhong cc6596fc72 net: ll_temac: Fix potential NULL dereference in temac_probe()

platform_get_resource() may fail and in this case a NULL dereference
will occur.

Fix it to use devm_platform_ioremap_resource() instead of calling
platform_get_resource() and devm_ioremap().

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Esben Haabendal <esben@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2020-12-08 16:15:46 -08:00

Kconfig

treewide: replace '---help---' in Kconfig files with 'help'

2020-06-14 01:57:21 +09:00

ll_temac_main.c

net: ll_temac: Fix potential NULL dereference in temac_probe()

2020-12-08 16:15:46 -08:00

ll_temac_mdio.c

net: ll_temac: Prepare indirect register access for multicast support

2019-05-23 09:33:57 -07:00

ll_temac.h

net: ll_temac: Add ethtool support for coalesce parameters