iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
ccaea61a8d
linux/sound/soc/qcom/qdsp6
History
Nathan Chancellor 9b7493468f
ASoC: q6dsp: Undo buggy warning fix 
This reverts commit 5f1b95d08d.

The warnings that commit 5f1b95d08d ("ASoC: q6dsp: q6afe: remove
unneeded dead-store initialization") was trying to fix were already
fixed in commit 12900bacb4 ("ASoC: qcom: q6afe: remove useless
assignments"). With both commits in the tree, port_id is uninitialized,
as pointed out by clang:

sound/soc/qcom/qdsp6/q6afe.c:1213:18: warning: variable 'port_id' is
uninitialized when used here [-Wuninitialized]
        stop->port_id = port_id;
                        ^~~~~~~
sound/soc/qcom/qdsp6/q6afe.c:1186:13: note: initialize the variable
'port_id' to silence this warning
        int port_id;
                   ^
                    = 0
1 warning generated.

Bring back the initialization so that everything works as intended.

Fixes: 5f1b95d08d ("ASoC: q6dsp: q6afe: remove unneeded dead-store initialization")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20210511190306.2418917-1-nathan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-05-12 13:02:52 +01:00
..
Makefile ASoC: q6afe-clocks: add q6afe clock controller 2020-09-17 16:13:13 +01:00
q6adm.c ASoC: qcom: qdsp6: make use of devm_of_platform_populate 2020-10-27 14:13:34 +00:00
q6adm.h ASoC: qdsp6: q6adm: Add q6adm driver 2018-05-21 16:40:24 +01:00
q6afe-clocks.c ASoC: q6afe-clocks: fix reprobing of the driver 2021-03-30 12:42:52 +01:00
q6afe-dai.c Merge series "ASoC: qcom: remove cppcheck warnings" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>: 2021-03-10 13:07:23 +00:00
q6afe.c ASoC: q6dsp: Undo buggy warning fix 2021-05-12 13:02:52 +01:00
q6afe.h ASoC: q6afe-clocks: fix reprobing of the driver 2021-03-30 12:42:52 +01:00
q6asm-dai.c ASoC: qcom: qdsp6: Move frontend AIFs to q6asm-dai 2021-01-13 11:36:14 +00:00
q6asm.c ASoC: q6asm: fix 'physical' typos 2021-01-27 13:06:53 +00:00
q6asm.h ASoC: qcom: q6asm: align function prototypes 2021-03-10 13:01:54 +00:00
q6core.c ASoC: qdsp6: add ifdef CONFIG_OF around of_device_id 2020-09-25 18:36:58 +01:00
q6core.h
q6dsp-common.c
q6dsp-common.h
q6dsp-errno.h
q6routing.c ASoC: qcom: qdsp6: Move frontend AIFs to q6asm-dai 2021-01-13 11:36:14 +00:00
q6routing.h ASoC: qdsp6: q6routing: Add q6routing driver 2018-05-21 16:41:48 +01:00