iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Nikita Zhandarovich cde76b3af2 do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak 
[ Upstream commit 3948abaa4e2be938ccdfc289385a27342fb13d43 ]

syzbot identified a kernel information leak vulnerability in
do_sys_name_to_handle() and issued the following report [1].

[1]
"BUG: KMSAN: kernel-infoleak in instrument_copy_to_user include/linux/instrumented.h:114 [inline]
BUG: KMSAN: kernel-infoleak in _copy_to_user+0xbc/0x100 lib/usercopy.c:40
 instrument_copy_to_user include/linux/instrumented.h:114 [inline]
 _copy_to_user+0xbc/0x100 lib/usercopy.c:40
 copy_to_user include/linux/uaccess.h:191 [inline]
 do_sys_name_to_handle fs/fhandle.c:73 [inline]
 __do_sys_name_to_handle_at fs/fhandle.c:112 [inline]
 __se_sys_name_to_handle_at+0x949/0xb10 fs/fhandle.c:94
 __x64_sys_name_to_handle_at+0xe4/0x140 fs/fhandle.c:94
 ...

Uninit was created at:
 slab_post_alloc_hook+0x129/0xa70 mm/slab.h:768
 slab_alloc_node mm/slub.c:3478 [inline]
 __kmem_cache_alloc_node+0x5c9/0x970 mm/slub.c:3517
 __do_kmalloc_node mm/slab_common.c:1006 [inline]
 __kmalloc+0x121/0x3c0 mm/slab_common.c:1020
 kmalloc include/linux/slab.h:604 [inline]
 do_sys_name_to_handle fs/fhandle.c:39 [inline]
 __do_sys_name_to_handle_at fs/fhandle.c:112 [inline]
 __se_sys_name_to_handle_at+0x441/0xb10 fs/fhandle.c:94
 __x64_sys_name_to_handle_at+0xe4/0x140 fs/fhandle.c:94
 ...

Bytes 18-19 of 20 are uninitialized
Memory access of size 20 starts at ffff888128a46380
Data copied to user address 0000000020000240"

Per Chuck Lever's suggestion, use kzalloc() instead of kmalloc() to
solve the problem.

Fixes: 990d6c2d7aee ("vfs: Add name to file handle conversion support")
Suggested-by: Chuck Lever III <chuck.lever@oracle.com>
Reported-and-tested-by: <syzbot+09b349b3066c2e0b1e96@syzkaller.appspotmail.com>
Signed-off-by: Nikita Zhandarovich <n.zhandarovich@fintech.ru>
Link: https://lore.kernel.org/r/20240119153906.4367-1-n.zhandarovich@fintech.ru
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-03-26 18:21:47 -04:00
..
9p
9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"
2022-06-22 14:13:12 +02:00
adfs
…
affs
affs: initialize fsdata in affs_truncate()
2023-02-01 08:23:11 +01:00
afs
afs: Fix endless loop in directory parsing
2024-03-06 14:37:49 +00:00
autofs
autofs: fix memory leak of waitqueues in autofs_catatonic_mode
2023-09-23 11:01:04 +02:00
befs
…
bfs
bfs: don't use WARNING: string when it's just info.
2021-01-06 14:56:52 +01:00
btrfs
btrfs: dev-replace: properly validate device names
2024-03-06 14:37:49 +00:00
cachefiles
cachefiles: fix memory leak in cachefiles_add_cache()
2024-03-06 14:37:50 +00:00
ceph
ceph: prevent use-after-free in encode_cap_msg()
2024-02-23 08:42:29 +01:00
cifs
cifs: add a warning when the in-flight count goes negative
2024-03-01 13:16:46 +01:00
coda
coda: Avoid partial allocation of sig_inputArgs
2023-03-11 16:39:51 +01:00
configfs
Revert "configfs: fix a race in configfs_lookup()"
2023-09-21 09:45:15 +02:00
cramfs
…
crypto
fscrypt: fix keyring memory leak on mount failure
2022-11-10 18:14:25 +01:00
debugfs
debugfs: fix automount d_fsdata usage
2024-01-25 14:37:36 -08:00
devpts
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:25:39 +01:00
dlm
dlm: fix plock lookup when using multiple lockspaces
2023-09-19 12:20:22 +02:00
ecryptfs
ecryptfs: Reject casefold directory inodes
2024-02-23 08:42:05 +01:00
efivarfs
efivarfs: force RO when remounting if SetVariable is not supported
2024-01-25 14:37:40 -08:00
efs
…
erofs
erofs: fix lz4 inplace decompression
2024-03-01 13:16:48 +01:00
exfat
exfat: support handle zero-size directory
2023-11-28 16:54:52 +00:00
exportfs
…
ext2
ext2: fix datatype of block number in ext2_xattr_set2()
2023-09-23 11:01:07 +02:00
ext4
ext4: convert to exclusive lock while inserting delalloc extents
2024-03-15 10:48:21 -04:00
f2fs
f2fs: fix write pointers on zoned device after roll forward
2024-02-23 08:42:11 +01:00
fat
fat: add ratelimit to fat*_ent_bread()
2022-06-09 10:20:58 +02:00
freevxfs
…
fscache
fscache: Fix cookie key hashing
2021-09-18 13:40:15 +02:00
fuse
fuse: dax: set fc->dax to NULL in fuse_dax_conn_free()
2023-12-20 15:44:30 +01:00
gfs2
gfs2: Fix kernel NULL pointer dereference in gfs2_rgrp_dump
2024-01-25 14:37:42 -08:00
hfs
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-11 16:39:55 +01:00
hfsplus
fs: hfsplus: remove WARN_ON() from hfsplus_cat_{read,write}_inode()
2023-05-30 12:57:47 +01:00
hostfs
hostfs: fix memory handling in follow_link()
2021-04-14 08:42:06 +02:00
hpfs
…
hugetlbfs
mm: hugetlb pages should not be reserved by shmat() if SHM_NORESERVE
2024-03-15 10:48:22 -04:00
iomap
xfs: use current->journal_info for detecting transaction recursion
2022-07-07 17:52:19 +02:00
isofs
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 14:58:33 +01:00
jbd2
jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint
2024-03-01 13:16:47 +01:00
jffs2
jffs2: reduce stack usage in jffs2_build_xattr_subsystem()
2023-07-27 08:44:13 +02:00
jfs
jfs: fix array-index-out-of-bounds in diNewExt
2024-02-23 08:42:04 +01:00
kernfs
fs/kernfs/dir: obey S_ISGID
2024-02-23 08:42:14 +01:00
lockd
fs: lockd: avoid possible wrong NULL parameter
2023-09-19 12:20:15 +02:00
minix
minix: fix bug when opening a file with O_DIRECT
2022-04-13 21:01:01 +02:00
nfs
NFSv4.1/pnfs: Ensure we handle the error NFS4ERR_RETURNCONFLICT
2024-01-25 14:37:43 -08:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:53:45 +01:00
nfsd
nfsd: lock_rename() needs both directories to live on the same fs
2023-12-08 08:46:10 +01:00
nilfs2
nilfs2: replace WARN_ONs for invalid DAT metadata block requests
2024-02-23 08:42:32 +01:00
nls
fs/nls: make load_nls() take a const parameter
2023-09-19 12:20:04 +02:00
notify
fanotify: disallow mount/sb marks on kernel internal pseudo fs
2023-07-27 08:44:15 +02:00
ntfs
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-25 17:45:57 +01:00
ocfs2
fs: ocfs2: namei: check return value of ocfs2_add_entry()
2023-09-19 12:20:09 +02:00
omfs
…
openpromfs
…
orangefs
orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()
2023-01-14 10:16:20 +01:00
overlayfs
ima: detect changes to the backing overlay file
2023-11-28 16:54:57 +00:00
proc
watchdog: move softlockup_panic back to early_param
2023-11-28 16:54:56 +00:00
pstore
pstore/ram: Fix crash when setting number of cpus to an odd number
2024-02-23 08:42:04 +01:00
qnx4
qnx4: work around gcc false positive warning bug
2021-09-30 10:11:08 +02:00
qnx6
…
quota
quota: explicitly forbid quota files from being encrypted
2023-11-28 16:54:58 +00:00
ramfs
shmem: use ramfs_kill_sb() for kill_sb method of ramfs-based tmpfs
2023-07-27 08:44:13 +02:00
reiserfs
reiserfs: Check the return value from __getblk()
2023-09-19 12:20:06 +02:00
romfs
…
squashfs
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:55:56 +01:00
sysfs
…
sysv
fs/sysv: Null check to prevent null-ptr-deref bug
2023-08-11 11:57:53 +02:00
tracefs
tracefs: Add missing lockdown check to tracefs_create_dir()
2023-09-23 11:01:10 +02:00
ubifs
ubifs: ubifs_symlink: Fix memleak of inode->i_link in error path
2024-02-23 08:41:54 +01:00
udf
udf: initialize newblock to 0
2023-09-19 12:20:23 +02:00
ufs
…
unicode
…
vboxsf
vboxfs: fix broken legacy mount signature checking
2021-10-17 10:43:33 +02:00
verity
fsverity: skip PKCS#7 parser when keyring is empty
2023-09-19 12:20:22 +02:00
xfs
xfs: verify buffer contents when we skip log replay
2023-06-14 11:09:59 +02:00
zonefs
zonefs: Improve error handling
2024-03-01 13:16:43 +01:00
aio.c
fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio
2024-03-01 13:16:51 +01:00
anon_inodes.c
…
attr.c
attr: block mode changes of symlinks
2023-09-23 11:01:09 +02:00
bad_inode.c
…
binfmt_aout.c
…
binfmt_elf_fdpic.c
fs: binfmt_elf_efpic: fix personality for ELF-FDPIC
2023-10-10 21:53:35 +02:00
binfmt_elf.c
fs/binfmt_elf: Fix memory leak in load_elf_binary()
2022-11-03 23:57:49 +09:00
binfmt_em86.c
…
binfmt_flat.c
binfmt_flat: do not stop relocating GOT entries prematurely on riscv
2022-06-09 10:20:47 +02:00
binfmt_misc.c
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2023-01-14 10:16:13 +01:00
binfmt_script.c
…
block_dev.c
block: Don't invalidate pagecache for invalid falloc modes
2024-01-15 18:48:03 +01:00
buffer.c
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-25 17:45:56 +01:00
char_dev.c
chardev: fix error handling in cdev_device_add()
2023-01-14 10:15:59 +01:00
compat_binfmt_elf.c
…
coredump.c
coredump: Limit what can interrupt coredumps
2023-01-04 11:39:22 +01:00
d_path.c
…
dax.c
dax: fix cache flush on PMD-mapped pages
2022-06-09 10:21:16 +02:00
dcache.c
fast_dput(): handle underflows gracefully
2024-02-23 08:42:10 +01:00
dcookies.c
…
direct-io.c
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:41:58 +02:00
drop_caches.c
…
eventfd.c
eventfd: prevent underflow for eventfd semaphores
2023-09-19 12:20:06 +02:00
eventpoll.c
epoll: ep_autoremove_wake_function should use list_del_init_careful
2023-06-21 15:45:37 +02:00
exec.c
exec: Fix error handling in begin_new_exec()
2024-02-23 08:41:58 +01:00
fcntl.c
fcntl: fix potential deadlocks for &fown_struct.lock
2022-10-30 09:41:18 +01:00
fhandle.c
do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak
2024-03-26 18:21:47 -04:00
file_table.c
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()
2022-05-18 10:23:48 +02:00
file.c
file: reinstate f_pos locking optimization for regular files
2023-08-11 11:57:53 +02:00
filesystems.c
…
fs_context.c
fs: avoid empty option when generating legacy mount string
2023-07-27 08:44:13 +02:00
fs_parser.c
…
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
writeback: fix call of incorrect macro
2023-05-17 11:48:10 +02:00
fsopen.c
…
init.c
…
inode.c
fs: add ctime accessors infrastructure
2023-12-08 08:46:15 +01:00
internal.h
fs: Establish locking order for unrelated directories
2023-07-27 08:44:13 +02:00
ioctl.c
lsm: new security_file_ioctl_compat() hook
2024-02-23 08:41:53 +01:00
Kconfig
tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha
2021-02-17 11:02:21 +01:00
Kconfig.binfmt
…
kernel_read_file.c
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-27 09:56:51 +02:00
libfs.c
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2023-01-14 10:15:19 +01:00
locks.c
locks: fix KASAN: use-after-free in trace_event_raw_event_filelock_lock
2023-09-23 11:01:04 +02:00
Makefile
io_uring: import 5.15-stable io_uring
2023-01-04 11:39:23 +01:00
mbcache.c
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-14 10:16:50 +01:00
mount.h
…
mpage.c
…
namei.c
rename(): fix the locking of subdirectories
2024-02-23 08:41:54 +01:00
namespace.c
fs: indicate request originates from old mount API
2024-01-25 14:37:42 -08:00
no-block.c
…
nsfs.c
…
open.c
open: make RESOLVE_CACHED correctly test for O_TMPFILE
2023-08-11 11:57:53 +02:00
pipe.c
pipe: wakeup wr_wait after setting max_usage
2024-02-23 08:42:00 +01:00
pnode.c
pnode: terminate at peers of source
2023-01-14 10:16:27 +01:00
pnode.h
mount: fix mounting of detached mounts onto targets that reside on shared mounts
2021-03-17 17:06:13 +01:00
posix_acl.c
…
proc_namespace.c
proc mountinfo: make splice available again
2020-12-30 11:54:02 +01:00
read_write.c
vfs: fix copy_file_range() averts filesystem freeze protection
2022-12-19 12:27:30 +01:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-21 13:00:54 +02:00
remap_range.c
fs/remap: constrain dedupe of EOF blocks
2022-07-21 21:20:01 +02:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:26:11 +01:00
seq_file.c
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:05:59 +02:00
signalfd.c
io_uring: disable polling pollfree files
2022-09-05 10:28:58 +02:00
splice.c
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-17 17:26:07 +02:00
stack.c
…
stat.c
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 13:53:54 +02:00
statfs.c
statfs: enforce statfs[64] structure initialization
2023-05-30 12:57:55 +01:00
super.c
fs: Protect reconfiguration of sb read-write from racing writes
2023-08-11 11:57:54 +02:00
sync.c
vfs: make sync_filesystem return errors from ->sync_fs
2022-08-31 17:15:14 +02:00
timerfd.c
…
userfaultfd.c
userfaultfd: open userfaultfds with O_RDONLY
2022-10-26 13:25:17 +02:00
utimes.c
…
xattr.c
fs: don't audit the capability check in simple_xattr_list()
2023-01-14 10:15:16 +01:00