6340dcbd61
The commit b37a466837 ("netdevice: add the case if dev is NULL") changed
the way how the NULL check for net_devices have to be handled when trying
to reduce its reference counter. Before this commit, it was the
responsibility of the caller to check whether the object is NULL or not.
But it was changed to behave more like kfree. Now the callee has to handle
the NULL-case.
The batman-adv code was scanned via cocinelle for similar places. These
were changed to use the paradigm
@@
identifier E, T, R, C;
identifier put;
@@
void put(struct T *E)
{
+ if (!E)
+ return;
kref_put(&E->C, R);
}
Functions which were used in other sources files were moved to the header
to allow the compiler to inline the NULL check and the kref_put call.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
75 lines
2.8 KiB
C
75 lines
2.8 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (C) B.A.T.M.A.N. contributors:
|
|
*
|
|
* Marek Lindner, Simon Wunderlich, Antonio Quartulli
|
|
*/
|
|
|
|
#ifndef _NET_BATMAN_ADV_TRANSLATION_TABLE_H_
|
|
#define _NET_BATMAN_ADV_TRANSLATION_TABLE_H_
|
|
|
|
#include "main.h"
|
|
|
|
#include <linux/kref.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/netlink.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/types.h>
|
|
|
|
int batadv_tt_init(struct batadv_priv *bat_priv);
|
|
bool batadv_tt_local_add(struct net_device *soft_iface, const u8 *addr,
|
|
unsigned short vid, int ifindex, u32 mark);
|
|
u16 batadv_tt_local_remove(struct batadv_priv *bat_priv,
|
|
const u8 *addr, unsigned short vid,
|
|
const char *message, bool roaming);
|
|
int batadv_tt_local_dump(struct sk_buff *msg, struct netlink_callback *cb);
|
|
int batadv_tt_global_dump(struct sk_buff *msg, struct netlink_callback *cb);
|
|
void batadv_tt_global_del_orig(struct batadv_priv *bat_priv,
|
|
struct batadv_orig_node *orig_node,
|
|
s32 match_vid, const char *message);
|
|
struct batadv_tt_global_entry *
|
|
batadv_tt_global_hash_find(struct batadv_priv *bat_priv, const u8 *addr,
|
|
unsigned short vid);
|
|
void batadv_tt_global_entry_release(struct kref *ref);
|
|
int batadv_tt_global_hash_count(struct batadv_priv *bat_priv,
|
|
const u8 *addr, unsigned short vid);
|
|
struct batadv_orig_node *batadv_transtable_search(struct batadv_priv *bat_priv,
|
|
const u8 *src, const u8 *addr,
|
|
unsigned short vid);
|
|
void batadv_tt_free(struct batadv_priv *bat_priv);
|
|
bool batadv_is_my_client(struct batadv_priv *bat_priv, const u8 *addr,
|
|
unsigned short vid);
|
|
bool batadv_is_ap_isolated(struct batadv_priv *bat_priv, u8 *src, u8 *dst,
|
|
unsigned short vid);
|
|
void batadv_tt_local_commit_changes(struct batadv_priv *bat_priv);
|
|
bool batadv_tt_global_client_is_roaming(struct batadv_priv *bat_priv,
|
|
u8 *addr, unsigned short vid);
|
|
bool batadv_tt_local_client_is_roaming(struct batadv_priv *bat_priv,
|
|
u8 *addr, unsigned short vid);
|
|
void batadv_tt_local_resize_to_mtu(struct net_device *soft_iface);
|
|
bool batadv_tt_add_temporary_global_entry(struct batadv_priv *bat_priv,
|
|
struct batadv_orig_node *orig_node,
|
|
const unsigned char *addr,
|
|
unsigned short vid);
|
|
bool batadv_tt_global_is_isolated(struct batadv_priv *bat_priv,
|
|
const u8 *addr, unsigned short vid);
|
|
|
|
int batadv_tt_cache_init(void);
|
|
void batadv_tt_cache_destroy(void);
|
|
|
|
/**
|
|
* batadv_tt_global_entry_put() - decrement the tt_global_entry refcounter and
|
|
* possibly release it
|
|
* @tt_global_entry: tt_global_entry to be free'd
|
|
*/
|
|
static inline void
|
|
batadv_tt_global_entry_put(struct batadv_tt_global_entry *tt_global_entry)
|
|
{
|
|
if (!tt_global_entry)
|
|
return;
|
|
|
|
kref_put(&tt_global_entry->common.refcount,
|
|
batadv_tt_global_entry_release);
|
|
}
|
|
|
|
#endif /* _NET_BATMAN_ADV_TRANSLATION_TABLE_H_ */
|