João Paulo Rechi Vita
cf48bf9eee
platform/x86: asus-wmi: Fix NULL pointer dereference ...
Do not perform the rfkill cleanup routine when
(asus->driver->wlan_ctrl_by_user && ashs_present()) is true, since
nothing is registered with the rfkill subsystem in that case. Doing so
leads to the following kernel NULL pointer dereference:
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [<ffffffff816c7348>] __mutex_lock_slowpath+0x98/0x120
PGD 1a3aa8067
PUD 1a3b3d067
PMD 0
Oops: 0002 [#1 ] PREEMPT SMP
Modules linked in: bnep ccm binfmt_misc uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_core hid_a4tech videodev x86_pkg_temp_thermal intel_powerclamp coretemp ath3k btusb btrtl btintel bluetooth kvm_intel snd_hda_codec_hdmi kvm snd_hda_codec_realtek snd_hda_codec_generic irqbypass crc32c_intel arc4 i915 snd_hda_intel snd_hda_codec ath9k ath9k_common ath9k_hw ath i2c_algo_bit snd_hwdep mac80211 ghash_clmulni_intel snd_hda_core snd_pcm snd_timer cfg80211 ehci_pci xhci_pci drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm xhci_hcd ehci_hcd asus_nb_wmi(-) asus_wmi sparse_keymap r8169 rfkill mxm_wmi serio_raw snd mii mei_me lpc_ich i2c_i801 video soundcore mei i2c_smbus wmi i2c_core mfd_core
CPU: 3 PID: 3275 Comm: modprobe Not tainted 4.9.34-gentoo #34
Hardware name: ASUSTeK COMPUTER INC. K56CM/K56CM, BIOS K56CM.206 08/21/2012
task: ffff8801a639ba00 task.stack: ffffc900014cc000
RIP: 0010:[<ffffffff816c7348>] [<ffffffff816c7348>] __mutex_lock_slowpath+0x98/0x120
RSP: 0018:ffffc900014cfce0 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff8801a54315b0 RCX: 00000000c0000100
RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff8801a54315b4
RBP: ffffc900014cfd30 R08: 0000000000000000 R09: 0000000000000002
R10: 0000000000000000 R11: 0000000000000000 R12: ffff8801a54315b4
R13: ffff8801a639ba00 R14: 00000000ffffffff R15: ffff8801a54315b8
FS: 00007faa254fb700(0000) GS:ffff8801aef80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 00000001a3b1b000 CR4: 00000000001406e0
Stack:
ffff8801a54315b8 0000000000000000 ffffffff814733ae ffffc900014cfd28
ffffffff8146a28c ffff8801a54315b0 0000000000000000 ffff8801a54315b0
ffff8801a66f3820 0000000000000000 ffffc900014cfd48 ffffffff816c73e7
Call Trace:
[<ffffffff814733ae>] ? acpi_ut_release_mutex+0x5d/0x61
[<ffffffff8146a28c>] ? acpi_ns_get_node+0x49/0x52
[<ffffffff816c73e7>] mutex_lock+0x17/0x30
[<ffffffffa00a3bb4>] asus_rfkill_hotplug+0x24/0x1a0 [asus_wmi]
[<ffffffffa00a4421>] asus_wmi_rfkill_exit+0x61/0x150 [asus_wmi]
[<ffffffffa00a49f1>] asus_wmi_remove+0x61/0xb0 [asus_wmi]
[<ffffffff814a5128>] platform_drv_remove+0x28/0x40
[<ffffffff814a2901>] __device_release_driver+0xa1/0x160
[<ffffffff814a29e3>] device_release_driver+0x23/0x30
[<ffffffff814a1ffd>] bus_remove_device+0xfd/0x170
[<ffffffff8149e5a9>] device_del+0x139/0x270
[<ffffffff814a5028>] platform_device_del+0x28/0x90
[<ffffffff814a50a2>] platform_device_unregister+0x12/0x30
[<ffffffffa00a4209>] asus_wmi_unregister_driver+0x19/0x30 [asus_wmi]
[<ffffffffa00da0ea>] asus_nb_wmi_exit+0x10/0xf26 [asus_nb_wmi]
[<ffffffff8110c692>] SyS_delete_module+0x192/0x270
[<ffffffff810022b2>] ? exit_to_usermode_loop+0x92/0xa0
[<ffffffff816ca560>] entry_SYSCALL_64_fastpath+0x13/0x94
Code: e8 5e 30 00 00 8b 03 83 f8 01 0f 84 93 00 00 00 48 8b 43 10 4c 8d 7b 08 48 89 63 10 41 be ff ff ff ff 4c 89 3c 24 48 89 44 24 08 <48> 89 20 4c 89 6c 24 10 eb 1d 4c 89 e7 49 c7 45 08 02 00 00 00
RIP [<ffffffff816c7348>] __mutex_lock_slowpath+0x98/0x120
RSP <ffffc900014cfce0>
CR2: 0000000000000000
---[ end trace 8d484233fa7cb512 ]---
note: modprobe[3275] exited with preempt_count 2
https://bugzilla.kernel.org/show_bug.cgi?id=196467
Reported-by: red.f0xyz@gmail.com
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
2018-05-31 15:19:16 +03:00
2018-04-12 11:04:35 -07:00
2018-04-03 17:42:25 -07:00
2018-04-01 19:49:34 -04:00
2018-04-11 10:28:31 -07:00
2018-04-13 15:15:15 -07:00
2018-04-01 21:43:02 +03:00
2018-04-06 18:31:06 -07:00
2018-04-10 10:22:27 -07:00
2018-04-13 15:51:06 -07:00
2018-04-05 21:21:08 -07:00
2018-04-10 08:40:45 +02:00
2018-04-09 11:54:57 +02:00
2018-04-07 19:04:02 +09:00
2018-04-10 10:25:57 -07:00
2018-04-10 12:14:37 -07:00
2018-04-05 14:21:13 -07:00
2018-04-04 20:07:20 -07:00
2018-04-13 16:32:16 -07:00
2018-04-05 21:03:42 -07:00
2018-04-12 20:56:10 -07:00
2018-04-05 11:53:34 -07:00
2018-04-09 11:42:31 -07:00
2018-04-09 19:59:54 -07:00
2018-04-04 20:07:20 -07:00
2018-04-11 23:33:46 +02:00
2018-04-05 14:27:02 -07:00
2018-04-05 09:51:41 -07:00
2018-04-06 17:35:43 -07:00
2018-04-13 16:20:36 -07:00
2018-04-11 18:50:41 -07:00
2018-04-11 18:50:41 -07:00
2018-04-03 14:04:18 -07:00
2018-03-29 17:29:09 -06:00
2018-04-07 12:08:19 -07:00
2018-04-10 10:25:57 -07:00
2018-04-10 12:09:27 -07:00
2018-04-10 22:25:07 -07:00
2018-04-12 10:21:19 -07:00
2018-04-12 10:59:03 -07:00
2018-04-11 16:39:34 -07:00
2018-04-12 11:09:05 -07:00
2018-04-10 10:25:57 -07:00
2018-04-12 09:58:27 -06:00
2018-04-04 20:07:20 -07:00
2018-04-15 17:21:30 -07:00
2018-03-29 15:07:48 -04:00
2018-03-27 18:52:22 +02:00
2018-04-04 20:07:20 -07:00
2018-04-11 08:46:50 -05:00
2018-04-09 09:26:36 -07:00
2018-04-05 21:29:35 -07:00
2018-04-05 21:21:08 -07:00
2018-04-05 09:51:41 -07:00
2018-05-31 15:19:16 +03:00
2018-04-05 21:21:08 -07:00
2018-04-13 15:46:21 -07:00
2018-04-11 10:28:37 -07:00
2018-03-28 10:33:53 +08:00
2018-04-05 22:53:16 -07:00
2018-03-27 21:54:37 -07:00
2018-04-10 10:22:27 -07:00
2018-04-13 09:43:20 -07:00
2018-04-01 20:07:00 -04:00
2018-04-15 17:24:12 -07:00
2018-04-13 15:51:06 -07:00
2018-04-03 12:06:21 -07:00
2018-04-11 10:28:39 -07:00
2018-04-05 14:27:02 -07:00
2018-04-13 14:11:53 +08:00
2018-04-09 09:04:10 -07:00
2018-04-07 11:11:41 -07:00
2018-04-06 19:44:27 -07:00
2018-04-11 10:54:06 -04:00
2018-04-10 10:20:00 -07:00
2018-04-11 18:58:27 -07:00
2018-04-13 15:43:50 -07:00
2018-04-12 11:04:35 -07:00
2018-03-29 13:38:10 +03:00
cf48bf9eee