iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Andrea Righi d0520df724 ext4: properly check for dirty state in ext4_inode_datasync_dirty() 
ext4_inode_datasync_dirty() needs to return 'true' if the inode is
dirty, 'false' otherwise, but the logic seems to be incorrectly changed
by commit aa75f4d3daae ("ext4: main fast-commit commit path").

This introduces a problem with swap files that are always failing to be
activated, showing this error in dmesg:

 [   34.406479] swapon: file is not committed

Simple test case to reproduce the problem:

  # fallocate -l 8G swapfile
  # chmod 0600 swapfile
  # mkswap swapfile
  # swapon swapfile

Fix the logic to return the proper state of the inode.

Link: https://lore.kernel.org/lkml/20201024131333.GA32124@xps-13-7390
Fixes: 8016e29f4362 ("ext4: fast commit recovery path")
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201027044915.2553163-1-harshadshirwadkar@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
2020-10-28 13:41:23 -04:00
..
9p
9p pull request for inclusion in 5.10
2020-10-22 09:33:20 -07:00
adfs
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
affs
affs: fix basic permission bits to actually work
2020-08-31 12:20:31 +02:00
afs
afs fixes
2020-10-16 15:22:41 -07:00
autofs
autofs: harden ioctl table
2020-10-16 11:11:22 -07:00
befs
block: move struct block_device to blk_types.h
2020-06-24 09:16:02 -06:00
bfs
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
btrfs
block-5.10-2020-10-12
2020-10-13 12:12:44 -07:00
cachefiles
cachefiles: switch to kernel_write
2020-07-08 08:27:56 +02:00
ceph
ceph: comment cleanups and clarifications
2020-10-12 15:29:27 +02:00
cifs
cifs: Fix incomplete memory allocation on setxattr path
2020-10-10 15:52:54 -07:00
coda
docs: filesystems: convert coda.txt to ReST
2020-05-05 09:22:21 -06:00
configfs
fs: configfs: delete repeated words in comments
2020-10-16 11:11:19 -07:00
cramfs
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
crypto
fscrypt: export fscrypt_d_revalidate()
2020-09-28 14:44:51 -07:00
debugfs
debugfs: Fix module state check condition
2020-09-04 18:12:52 +02:00
devpts
…
dlm
networking changes for the 5.10 merge window
2020-10-15 18:42:13 -07:00
ecryptfs
mm, treewide: rename kzfree() to kfree_sensitive()
2020-08-07 11:33:22 -07:00
efivarfs
efivarfs: Replace invalid slashes with exclamation marks in dentries.
2020-09-25 23:29:04 +02:00
efs
block: move struct block_device to blk_types.h
2020-06-24 09:16:02 -06:00
erofs
erofs: remove unnecessary enum entries
2020-10-09 10:37:42 +08:00
exfat
exfat: remove useless check in exfat_move_file()
2020-10-22 08:29:12 +09:00
exportfs
…
ext2
\n
2020-10-15 14:56:15 -07:00
ext4
ext4: properly check for dirty state in ext4_inode_datasync_dirty()
2020-10-28 13:41:23 -04:00
f2fs
f2fs-for-5.10-rc1
2020-10-16 15:14:43 -07:00
fat
fat: fix fat_ra_init() for data clusters == 0
2020-08-12 10:58:01 -07:00
freevxfs
…
fscache
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-06-03 16:27:18 -07:00
fuse
fuse update for 5.10
2020-10-19 14:28:30 -07:00
gfs2
Fix memory leak on filesystem withdraw
2020-08-28 10:41:00 -07:00
hfs
block: move block-related definitions out of fs.h
2020-06-24 09:16:02 -06:00
hfsplus
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
hostfs
hostfs: Use kasprintf() instead of fixed buffer formatting
2020-03-29 23:23:00 +02:00
hpfs
hpfs: fix warning due to superfluous semicolon
2020-06-06 10:08:17 -07:00
hugetlbfs
hugetlbfs: prevent filesystem stacking of hugetlbfs
2020-08-12 10:57:56 -07:00
iomap
iomap: Call inode_dio_end() before generic_write_sync()
2020-09-28 08:51:08 -07:00
isofs
Remove uninitialized_var() macro for v5.9-rc1
2020-08-04 13:49:43 -07:00
jbd2
jbd2: fast commit recovery path
2020-10-21 23:22:37 -04:00
jffs2
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
jfs
fs: Introduce i_blocks_per_page
2020-09-21 08:59:26 -07:00
kernfs
fsnotify: pass dir and inode arguments to fsnotify()
2020-07-27 23:15:48 +02:00
lockd
The one new feature this time, from Anna Schumaker, is READ_PLUS, which
2020-10-22 09:44:27 -07:00
minix
fs/minix: remove expected error message in block_to_path()
2020-08-12 10:58:00 -07:00
nfs
The one new feature this time, from Anna Schumaker, is READ_PLUS, which
2020-10-22 09:44:27 -07:00
nfs_common
NFSv4.2: Fix NFS4ERR_STALE error when doing inter server copy
2020-10-21 10:31:20 -04:00
nfsd
The one new feature this time, from Anna Schumaker, is READ_PLUS, which
2020-10-22 09:44:27 -07:00
nilfs2
nilfs2: fix some kernel-doc warnings for nilfs2
2020-10-16 11:11:22 -07:00
nls
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
notify
mm, memcg: rework remote charging API to support nesting
2020-10-18 09:27:09 -07:00
ntfs
ntfs: add check for mft record size in superblock
2020-10-13 18:38:27 -07:00
ocfs2
The siginificant new ext4 feature this time around is Harshad's new
2020-10-22 10:31:08 -07:00
omfs
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
openpromfs
…
orangefs
orangefs: remove unnecessary assignment to variable ret
2020-08-04 15:01:58 -04:00
overlayfs
ovl: use generic vfs_ioc_setflags_prepare() helper
2020-10-06 15:38:15 +02:00
proc
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-22 09:59:21 -07:00
pstore
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
qnx4
…
qnx6
fs: convert mpage_readpages to mpage_readahead
2020-06-02 10:59:07 -07:00
quota
\n
2020-10-15 14:56:15 -07:00
ramfs
ramfs: fix nommu mmap with gaps in the page cache
2020-10-16 11:11:22 -07:00
reiserfs
reiserfs: Fix oops during mount
2020-10-01 11:15:31 +02:00
romfs
ROMFS: support inode blocks calculation
2020-10-16 11:11:22 -07:00
squashfs
squashfs: avoid bio_alloc() failure with 1Mbyte blocks
2020-08-21 09:52:53 -07:00
sysfs
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
2020-10-02 12:02:30 +02:00
sysv
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
tracefs
…
ubifs
This pull request contains fixes for UBI and UBIFS
2020-10-18 09:56:50 -07:00
udf
udf: Limit sparing table size
2020-09-29 17:21:54 +02:00
ufs
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
unicode
unicode: Add utf8_casefold_hash
2020-09-10 14:03:31 -07:00
vboxsf
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2020-10-15 15:11:56 -07:00
verity
fs-verity: use smp_load_acquire() for ->i_verity_info
2020-07-21 16:02:41 -07:00
xfs
Recalling the first round of new code for 5.10, in which we added:
2020-10-19 14:38:46 -07:00
zonefs
zonefs: open/close zone on file open/close
2020-09-15 18:32:52 +09:00
aio.c
Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-12 16:35:51 -07:00
anon_inodes.c
…
attr.c
…
bad_inode.c
fs: move the fiemap definitions out of fs.h
2020-06-03 23:16:55 -04:00
binfmt_aout.c
exec: Rename flush_old_exec begin_new_exec
2020-05-07 16:55:47 -05:00
binfmt_elf_fdpic.c
binfmt_elf, binfmt_elf_fdpic: use a VMA list snapshot
2020-10-16 11:11:21 -07:00
binfmt_elf.c
binfmt_elf: take the mmap lock around find_extend_vma()
2020-10-18 09:27:09 -07:00
binfmt_em86.c
Merge branch 'akpm' (patches from Andrew)
2020-06-04 19:18:29 -07:00
binfmt_flat.c
binfmt_flat: revert "binfmt_flat: don't offset the data start"
2020-08-24 08:49:13 +10:00
binfmt_misc.c
Merge branch 'akpm' (patches from Andrew)
2020-06-04 19:18:29 -07:00
binfmt_script.c
Merge branch 'akpm' (patches from Andrew)
2020-06-04 19:18:29 -07:00
block_dev.c
block: add a bdget_part helper
2020-10-05 10:38:33 -06:00
buffer.c
mm, memcg: rework remote charging API to support nesting
2020-10-18 09:27:09 -07:00
char_dev.c
vfs: allow unprivileged whiteout creation
2020-05-14 16:44:23 +02:00
compat_binfmt_elf.c
Split the old READ_IMPLIES_EXEC workaround from executable PT_GNU_STACK
2020-06-05 13:45:21 -07:00
coredump.c
binfmt_elf, binfmt_elf_fdpic: use a VMA list snapshot
2020-10-16 11:11:21 -07:00
d_path.c
fs: fix NULL dereference due to data race in prepend_path()
2020-10-14 14:54:45 -07:00
dax.c
fuse update for 5.10
2020-10-19 14:28:30 -07:00
dcache.c
vfs: Use sequence counter with associated spinlock
2020-07-29 16:14:27 +02:00
dcookies.c
…
direct-io.c
\n
2020-10-15 15:03:10 -07:00
drop_caches.c
sysctl: pass kernel pointers to ->proc_handler
2020-04-27 02:07:40 -04:00
eventfd.c
eventfd: convert to f_op->read_iter()
2020-05-06 22:33:43 -04:00
eventpoll.c
ep_create_wakeup_source(): dentry name can change under you...
2020-09-24 19:41:58 -04:00
exec.c
powerpc updates for 5.10
2020-10-16 12:21:15 -07:00
fcntl.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
fhandle.c
…
file_table.c
Revert "fs: Do not check if there is a fsnotify watcher on pseudo inodes"
2020-06-29 09:40:55 -07:00
file.c
io_uring: don't rely on weak ->files references
2020-09-30 20:32:32 -06:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-10 15:36:22 -07:00
fs_context.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
fs_parser.c
fs_parse: mark fs_param_bad_value() as static
2020-10-13 18:38:27 -07:00
fs_pin.c
…
fs_struct.c
vfs: Use sequence counter with associated spinlock
2020-07-29 16:14:27 +02:00
fs_types.c
…
fs-writeback.c
block-5.10-2020-10-12
2020-10-13 12:12:44 -07:00
fsopen.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
init.c
init: add an init_dup helper
2020-08-04 21:02:38 -04:00
inode.c
fs: add a filesystem flag for THPs
2020-10-16 11:11:15 -07:00
internal.h
fs: remove compat_sys_mount
2020-09-22 23:45:57 -04:00
io_uring.c
io_uring-5.10-2020-10-20
2020-10-20 13:19:30 -07:00
io-wq.c
io-wq: inherit audit loginuid and sessionid
2020-10-17 09:25:47 -06:00
io-wq.h
io_uring: move io identity items into separate struct
2020-10-17 09:25:45 -06:00
ioctl.c
fs: remove ksys_ioctl
2020-07-31 08:16:01 +02:00
Kconfig
tmpfs: support 64-bit inums per-sb
2020-08-07 11:33:24 -07:00
Kconfig.binfmt
treewide: replace '---help---' in Kconfig files with 'help'
2020-06-14 01:57:21 +09:00
kernel_read_file.c
fs/kernel_file_read: Add "offset" arg for partial reads
2020-10-05 13:37:04 +02:00
libfs.c
fs: Add standard casefolding support
2020-09-10 14:03:31 -07:00
locks.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
Makefile
Char/Misc driver patches for 5.10-rc1
2020-10-15 10:01:51 -07:00
mbcache.c
…
mount.h
proc/mounts: add cursor
2020-05-14 16:44:24 +02:00
mpage.c
fs: convert mpage_readpages to mpage_readahead
2020-06-02 10:59:07 -07:00
namei.c
fs: remove the unused SB_I_MULTIROOT flag
2020-09-24 13:43:38 -06:00
namespace.c
Merge branch 'compat.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-12 16:44:57 -07:00
no-block.c
…
nsfs.c
nsproxy: attach to namespaces via pidfds
2020-05-13 11:41:22 +02:00
open.c
exec: move S_ISREG() check earlier
2020-08-12 10:58:01 -07:00
pipe.c
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-11 11:11:35 -07:00
pnode.c
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-04-27 10:37:14 -04:00
pnode.h
…
posix_acl.c
vfs: clean up posix_acl_permission() logic aroudn MAY_NOT_BLOCK
2020-06-08 11:04:19 -07:00
proc_namespace.c
Merge branch 'proc-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
2020-06-04 13:54:34 -07:00
read_write.c
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-22 09:59:21 -07:00
readdir.c
fs: remove ksys_getdents64
2020-07-31 08:16:00 +02:00
select.c
pselect6() and friends: take handling the combined 6th/7th args into helper
2020-05-29 19:10:42 -04:00
seq_file.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
signalfd.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
splice.c
Merge branch 'work.set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2020-10-22 09:59:21 -07:00
stack.c
…
stat.c
New code for 5.8:
2020-06-02 19:45:12 -07:00
statfs.c
…
super.c
bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag
2020-09-24 13:43:39 -06:00
sync.c
overlayfs update for 5.8
2020-06-09 15:40:50 -07:00
timerfd.c
…
userfaultfd.c
mm: remove the now-unnecessary mmget_still_valid() hack
2020-10-16 11:11:22 -07:00
utimes.c
fs: expose utimes_common
2020-07-31 08:16:01 +02:00
xattr.c
fs/xattr.c: fix kernel-doc warnings for setxattr & removexattr
2020-10-13 18:38:27 -07:00