iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/mm
History
Wei Yang 18e19f195c mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM 
When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page()
doesn't work before sparse_init_one_section() is called.

This leads to a crash when hotplug memory:

    BUG: unable to handle page fault for address: 0000000006400000
    #PF: supervisor write access in kernel mode
    #PF: error_code(0x0002) - not-present page
    PGD 0 P4D 0
    Oops: 0002 [#1] SMP PTI
    CPU: 3 PID: 221 Comm: kworker/u16:1 Tainted: G        W         5.5.0-next-20200205+ #343
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015
    Workqueue: kacpi_hotplug acpi_hotplug_work_fn
    RIP: 0010:__memset+0x24/0x30
    Code: cc cc cc cc cc cc 0f 1f 44 00 00 49 89 f9 48 89 d1 83 e2 07 48 c1 e9 03 40 0f b6 f6 48 b8 01 01 01 01 01 01 01 01 48 0f af c6 <f3> 48 ab 89 d1 f3 aa 4c 89 c8 c3 90 49 89 f9 40 88 f0 48 89 d1 f3
    RSP: 0018:ffffb43ac0373c80 EFLAGS: 00010a87
    RAX: ffffffffffffffff RBX: ffff8a1518800000 RCX: 0000000000050000
    RDX: 0000000000000000 RSI: 00000000000000ff RDI: 0000000006400000
    RBP: 0000000000140000 R08: 0000000000100000 R09: 0000000006400000
    R10: 0000000000000000 R11: 0000000000000002 R12: 0000000000000000
    R13: 0000000000000028 R14: 0000000000000000 R15: ffff8a153ffd9280
    FS:  0000000000000000(0000) GS:ffff8a153ab00000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: 0000000006400000 CR3: 0000000136fca000 CR4: 00000000000006e0
    DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
    Call Trace:
     sparse_add_section+0x1c9/0x26a
     __add_pages+0xbf/0x150
     add_pages+0x12/0x60
     add_memory_resource+0xc8/0x210
     __add_memory+0x62/0xb0
     acpi_memory_device_add+0x13f/0x300
     acpi_bus_attach+0xf6/0x200
     acpi_bus_scan+0x43/0x90
     acpi_device_hotplug+0x275/0x3d0
     acpi_hotplug_work_fn+0x1a/0x30
     process_one_work+0x1a7/0x370
     worker_thread+0x30/0x380
     kthread+0x112/0x130
     ret_from_fork+0x35/0x40

We should use memmap as it did.

On x86 the impact is limited to x86_32 builds, or x86_64 configurations
that override the default setting for SPARSEMEM_VMEMMAP.

Other memory hotplug archs (arm64, ia64, and ppc) also default to
SPARSEMEM_VMEMMAP=y.

[dan.j.williams@intel.com: changelog update]
{rppt@linux.ibm.com: changelog update]
Link: http://lkml.kernel.org/r/20200219030454.4844-1-bhe@redhat.com
Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug")
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Signed-off-by: Baoquan He <bhe@redhat.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@linux.ibm.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-02-21 11:22:15 -08:00
..
kasan
RISC-V Patches for the 5.6 Merge Window, Part 1
2020-01-31 11:23:29 -08:00
backing-dev.c
memcg: fix a crash in wb_workfn when a device disappears
2020-01-31 10:30:36 -08:00
balloon_compaction.c
mm/balloon_compaction: suppress allocation warnings
2019-09-04 07:42:01 -04:00
cleancache.c
Driver Core and debugfs changes for 5.3-rc1
2019-07-12 12:24:03 -07:00
cma_debug.c
mm/cma_debug.c: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
2019-12-01 12:59:09 -08:00
cma.c
mm/cma.c: switch to bitmap_zalloc() for cma bitmap allocation
2019-12-01 12:59:09 -08:00
cma.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
compaction.c
mm, compaction: fix wrong pfn handling in __reset_isolation_pfn()
2019-10-14 15:04:01 -07:00
debug_page_ref.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
debug.c
mm/hotplug: silence a lockdep splat with printk()
2020-01-31 10:30:39 -08:00
dmapool.c
mm: security: introduce init_on_alloc=1 and init_on_free=1 boot options
2019-07-12 11:05:46 -07:00
early_ioremap.c
mm/early_ioremap.c: use %pa to print resource_size_t variables
2020-01-31 10:30:38 -08:00
fadvise.c
fs: Export generic_fadvise()
2019-08-30 22:43:58 -07:00
failslab.c
mm/failslab.c: by default, do not fail allocations with direct reclaim only
2019-07-12 11:05:43 -07:00
filemap.c
mm/filemap.c: clean up filemap_write_and_wait()
2020-01-31 10:30:37 -08:00
frame_vector.c
mm: untag user pointers in get_vaddr_frames
2019-09-25 17:51:41 -07:00
frontswap.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482
2019-06-19 17:09:52 +02:00
gup_benchmark.c
mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1"
2020-01-31 10:30:38 -08:00
gup.c
asm-generic/tlb: rename HAVE_RCU_TABLE_FREE
2020-02-04 03:05:26 +00:00
highmem.c
mm, x86/mm: Untangle address space layout definitions from basic pgtable type definitions
2019-12-10 10:12:55 +01:00
hmm.c
mm: pagewalk: add 'depth' parameter to pte_hole
2020-02-04 03:05:25 +00:00
huge_memory.c
Merge branch 'akpm' (patches from Andrew)
2020-01-31 12:16:36 -08:00
hugetlb_cgroup.c
mm: hugetlb controller for cgroups v2
2019-12-16 12:41:40 -08:00
hugetlb.c
mm/hugetlb: defer freeing of huge pages if in non-task context
2020-01-04 13:55:09 -08:00
hwpoison-inject.c
mm/hwpoison-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
2019-12-01 12:59:09 -08:00
init-mm.c
mm/init-mm.c: include <linux/mman.h> for vm_committed_as_batch
2019-10-19 06:32:32 -04:00
internal.h
mm, pcpu: make zone pcp updates and reset internal to the mm
2019-12-01 12:59:06 -08:00
interval_tree.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 248
2019-06-19 17:09:08 +02:00
Kconfig
mm/Kconfig: fix trivial help text punctuation
2019-12-01 12:59:10 -08:00
Kconfig.debug
mm: add generic ptdump
2020-02-04 03:05:25 +00:00
khugepaged.c
mm/thp: flush file for !is_shmem PageDirty() case in collapse_file()
2019-12-01 12:59:09 -08:00
kmemleak-test.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
kmemleak.c
mm/kmemleak: turn kmemleak_lock and object->lock to raw_spinlock_t
2020-01-31 10:30:36 -08:00
ksm.c
* PPC secure guest support
2019-12-04 11:08:30 -08:00
list_lru.c
mm: memcg/slab: stop setting page->mem_cgroup pointer for slab pages
2019-07-12 11:05:44 -07:00
maccess.c
uaccess: Add strict non-pagefault kernel-space read function
2019-11-02 12:39:12 -07:00
madvise.c
mm: make do_madvise() available internally
2020-01-20 17:04:02 -07:00
Makefile
mm: add generic ptdump
2020-02-04 03:05:25 +00:00
mapping_dirty_helpers.c
mm: Add write-protect and clean utilities for address space ranges
2019-11-06 13:03:36 +01:00
memblock.c
memblock: Use __func__ in remaining memblock_dbg() call sites
2020-01-31 10:30:38 -08:00
memcontrol.c
mm/memcontrol.c: lost css_put in memcg_expand_shrinker_maps()
2020-02-21 11:22:15 -08:00
memfd.c
mm: page cache: store only head pages in i_pages
2019-09-24 15:54:08 -07:00
memory_hotplug.c
mm/memory_hotplug: drop valid_start/valid_end from test_pages_in_a_zone()
2020-02-04 03:05:23 +00:00
memory-failure.c
mm/memory-failure.c: use page_shift() in add_to_kill()
2019-12-01 12:59:04 -08:00
memory.c
drm ttm/mm changes for 5.6-rc1
2020-02-04 07:21:04 +00:00
mempolicy.c
mm/mempolicy.c: fix out of bounds write in mpol_parse_str()
2020-01-31 10:30:36 -08:00
mempool.c
docs/core-api/mm: fix return value descriptions in mm/
2019-03-05 21:07:20 -08:00
memremap.c
mm/memory_hotplug: poison memmap in remove_pfn_range_from_zone()
2020-02-04 03:05:23 +00:00
memtest.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
migrate.c
mm: pagewalk: add 'depth' parameter to pte_hole
2020-02-04 03:05:25 +00:00
mincore.c
mm: pagewalk: add 'depth' parameter to pte_hole
2020-02-04 03:05:25 +00:00
mlock.c
mm: untag user pointers passed to memory syscalls
2019-09-25 17:51:41 -07:00
mm_init.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
mmap.c
mm/mmap.c: get rid of odd jump labels in find_mergeable_anon_vma()
2020-01-31 10:30:39 -08:00
mmu_context.c
…
mmu_gather.c
asm-generic/tlb: provide MMU_GATHER_TABLE_FREE
2020-02-04 03:05:26 +00:00
mmu_notifier.c
mm/mmu_notifiers: Use 'interval_sub' as the variable for mmu_interval_notifier
2020-01-14 11:54:47 -04:00
mmzone.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mprotect.c
autonuma: reduce cache footprint when scanning page tables
2019-12-01 12:59:09 -08:00
mremap.c
mm/mmap.c: use IS_ERR_VALUE to check return value of get_unmapped_area
2019-12-01 06:29:19 -08:00
msync.c
mm: untag user pointers passed to memory syscalls
2019-09-25 17:51:41 -07:00
nommu.c
mm/mmap.c: rb_parent is not necessary in __vma_link_list()
2019-12-01 06:29:19 -08:00
oom_kill.c
mm, oom: dump stack of victim when reaping failed
2020-01-31 10:30:38 -08:00
page_alloc.c
mm/memmap_init: update variable name in memmap_init_zone
2020-02-04 03:05:23 +00:00
page_counter.c
memcg: introduce memory.min
2018-06-07 17:34:36 -07:00
page_ext.c
mm, page_owner: fix off-by-one error in __set_page_owner_handle()
2019-10-14 15:04:00 -07:00
page_idle.c
mm/page_idle.c: fix oops because end_pfn is larger than max_pfn
2019-06-29 16:43:45 +08:00
page_io.c
fs: Enable bmap() function to properly return errors
2020-02-03 08:05:37 -05:00
page_isolation.c
mm/page_isolation: fix potential warning from user
2020-01-31 10:30:39 -08:00
page_owner.c
mm/page_owner: don't access uninitialized memmaps when reading /proc/pagetypeinfo
2019-10-19 06:32:31 -04:00
page_poison.c
mm/page_poison.c: fix a typo in a comment
2019-09-24 15:54:08 -07:00
page_vma_mapped.c
mm/page_vma_mapped.c: explicitly compare pfn for normal, hugetlbfs and THP page
2020-01-31 10:30:38 -08:00
page-writeback.c
mm/page-writeback.c: improve arithmetic divisions
2020-01-13 18:19:02 -08:00
pagewalk.c
x86: mm: avoid allocating struct mm_struct on the stack
2020-02-04 03:05:25 +00:00
percpu-internal.h
percpu: convert chunk hints to be based on pcpu_block_md
2019-03-13 12:25:31 -07:00
percpu-km.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
percpu-stats.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
percpu-vm.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
percpu.c
bitmap: genericize percpu bitmap region iterators
2020-01-20 16:40:56 +01:00
pgtable-generic.c
asm-generic/mm: stub out p{4,u}d_clear_bad() if __PAGETABLE_P{4,U}D_FOLDED
2019-12-01 06:29:19 -08:00
process_vm_access.c
mm, tree-wide: rename put_user_page*() to unpin_user_page*()
2020-01-31 10:30:38 -08:00
ptdump.c
x86: mm: avoid allocating struct mm_struct on the stack
2020-02-04 03:05:25 +00:00
readahead.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
rmap.c
mm, thp: do not queue fully unmapped pages for deferred split
2019-12-01 12:59:09 -08:00
rodata_test.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
shmem.c
tmpfs: switch to use of invalfc()
2020-02-07 14:48:44 -05:00
shuffle.c
mm: fix -Wmissing-prototypes warnings
2019-10-07 15:47:19 -07:00
shuffle.h
mm: maintain randomization of page free lists
2019-05-14 19:52:48 -07:00
slab_common.c
proc: convert everything to "struct proc_ops"
2020-02-04 03:05:26 +00:00
slab.c
mm, debug_pagealloc: don't rely on static keys too early
2020-01-13 18:19:02 -08:00
slab.h
mm: clean up and clarify lruvec lookup procedure
2019-12-01 12:59:06 -08:00
slob.c
mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)
2019-10-07 15:47:20 -07:00
slub.c
mm/slub.c: avoid slub allocation while holding list_lock
2020-01-31 10:30:36 -08:00
sparse-vmemmap.c
mm/sparsemem: convert kmalloc_section_memmap() to populate_section_memmap()
2019-07-18 17:08:07 -07:00
sparse.c
mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM
2020-02-21 11:22:15 -08:00
swap_cgroup.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
swap_slots.c
mm, swap, get_swap_pages: use entry_size instead of cluster in parameter
2018-08-22 10:52:44 -07:00
swap_state.c
mm: page cache: store only head pages in i_pages
2019-09-24 15:54:08 -07:00
swap.c
mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages
2020-01-31 10:30:37 -08:00
swapfile.c
mm/swapfile.c: fix a comment in sys_swapon()
2020-02-21 11:22:15 -08:00
truncate.c
mm/thp: allow dropping THP from page cache
2019-10-19 06:32:33 -04:00
usercopy.c
usercopy: Avoid HIGHMEM pfn warning
2019-09-17 15:20:17 -07:00
userfaultfd.c
mm: fix typos in comments when calling __SetPageUptodate()
2019-12-01 12:59:10 -08:00
util.c
mm/mmap.c: rb_parent is not necessary in __vma_link_list()
2019-12-01 06:29:19 -08:00
vmacache.c
mm: get rid of vmacache_flush_all() entirely
2018-09-13 15:18:04 -10:00
vmalloc.c
Linux 5.5-rc7
2020-01-20 08:05:16 +01:00
vmpressure.c
mm/vmpressure.c: fix a signedness bug in vmpressure_register_event()
2019-10-07 15:47:19 -07:00
vmscan.c
mm/vmscan.c: don't round up scan size for online memory cgroup
2020-02-21 11:22:15 -08:00
vmstat.c
mm/memcontrol: use vmstat names for printing statistics
2019-12-04 19:44:11 -08:00
workingset.c
mm: vmscan: detect file thrashing at the reclaim root
2019-12-01 12:59:07 -08:00
z3fold.c
mm/z3fold.c: add inter-page compaction
2019-12-01 12:59:07 -08:00
zbud.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
zpool.c
zpool: add malloc_support_movable to zpool_driver
2019-09-24 15:54:12 -07:00
zsmalloc.c
mm/zsmalloc.c: fix the migrated zspage statistics.
2020-01-04 13:55:09 -08:00
zswap.c
zswap: potential NULL dereference on error in init_zswap()
2020-01-31 10:30:39 -08:00