iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/kernel/trace
History
Takeshi Misawa d122ed6288 tracing: Fix memory leak in tracing_err_log_open() 
When tracing_err_log_open() calls seq_open(), allocated memory is not freed.

kmemleak report:

unreferenced object 0xffff92c0781d1100 (size 128):
  comm "tail", pid 15116, jiffies 4295163855 (age 22.704s)
  hex dump (first 32 bytes):
    00 f0 08 e5 c0 92 ff ff 00 10 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000000d0687d5>] kmem_cache_alloc+0x11f/0x1e0
    [<000000003e3039a8>] seq_open+0x2f/0x90
    [<000000008dd36b7d>] tracing_err_log_open+0x67/0x140
    [<000000005a431ae2>] do_dentry_open+0x1df/0x3a0
    [<00000000a2910603>] vfs_open+0x2f/0x40
    [<0000000038b0a383>] path_openat+0x2e8/0x1690
    [<00000000fe025bda>] do_filp_open+0x9b/0x110
    [<00000000483a5091>] do_sys_open+0x1ba/0x260
    [<00000000c558b5fd>] __x64_sys_openat+0x20/0x30
    [<000000006881ec07>] do_syscall_64+0x5a/0x130
    [<00000000571c2e94>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

Fix this by calling seq_release() in tracing_err_log_fops.release().

Link: http://lkml.kernel.org/r/20190628105640.GA1863@DESKTOP

Fixes: 8a062902be725 ("tracing: Add tracing error log")
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Takeshi Misawa <jeliantsurux@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
2019-06-28 14:57:23 -04:00
..
blktrace.c
blkcg: annotate implicit fall through
2019-03-13 14:31:12 -06:00
bpf_trace.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2019-05-07 22:03:58 -07:00
fgraph.c
tracing: Fix ftrace_graph_get_ret_stack() to use task and not current
2018-12-22 08:21:03 -05:00
ftrace_internal.h
ftrace: Create new ftrace_internal.h header
2018-12-08 20:54:06 -05:00
ftrace.c
ftrace/x86: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()
2019-06-28 14:20:25 -04:00
Kconfig
tracing: stop making gpio tracing configurable
2019-04-08 15:11:48 +02:00
Makefile
tracing: Add unified dynamic event framework
2018-12-08 20:54:09 -05:00
power-traces.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
preemptirq_delay_test.c
tracing: Use trace_clock_local() for looping in preemptirq_delay_test.c
2018-10-17 15:35:33 -04:00
ring_buffer_benchmark.c
ring-buffer: Fix mispelling of Calculate
2019-05-08 12:15:12 -04:00
ring_buffer.c
The major changes in this tracing update includes:
2019-05-15 16:05:47 -07:00
rpm-traces.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace_benchmark.c
rcu: Rename cond_resched_rcu_qs() to cond_resched_tasks_rcu_qs()
2018-05-15 10:27:29 -07:00
trace_benchmark.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_branch.c
x86/uaccess, ftrace: Fix ftrace_likely_update() vs. SMAP
2019-04-03 11:02:24 +02:00
trace_clock.c
tracing: Add SPDX License format tags to tracing files
2018-08-16 19:08:06 -04:00
trace_dynevent.c
tracing: initialize variable in create_dyn_event()
2019-03-26 08:35:36 -04:00
trace_dynevent.h
tracing: Add unified dynamic event framework
2018-12-08 20:54:09 -05:00
trace_entries.h
tracing: Change the function format to display function names by perf
2019-02-11 14:53:43 -05:00
trace_event_perf.c
tracing/perf: Use strndup_user() instead of buggy open-coded version
2019-02-21 10:35:10 -05:00
trace_events_filter_test.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_events_filter.c
tracing: Avoid memory leak in predicate_parse()
2019-05-28 16:27:58 -04:00
trace_events_hist.c
tracing: Add a check_val() check before updating cond_snapshot() track_val
2019-05-21 12:48:07 -04:00
trace_events_trigger.c
tracing: Add trace_array parameter to create_event_filter()
2019-04-08 09:22:28 -04:00
trace_events.c
tracing: Fix partial reading of trace event's id file
2019-05-08 12:15:12 -04:00
trace_export.c
tracing: Add trigger file for trace_markers tracefs/ftrace/print
2018-05-29 08:28:53 -04:00
trace_functions_graph.c
tracing: Put a margin between flags and duration for wakeup tracers
2019-02-06 11:56:19 -05:00
trace_functions.c
tracing: Update stack trace skipping for ORC unwinder
2018-01-23 15:57:00 -05:00
trace_hwlat.c
tracing: Add SPDX License format tags to tracing files
2018-08-16 19:08:06 -04:00
trace_irqsoff.c
The biggest change for this release is in the histogram code.
2019-03-11 17:01:32 -07:00
trace_kdb.c
tracing: Silence GCC 9 array bounds warning
2019-05-25 23:04:30 -04:00
trace_kprobe_selftest.c
selftest/ftrace: Move kprobe selftest function to separate compile unit
2018-07-30 18:41:04 -04:00
trace_kprobe_selftest.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_kprobe.c
tracing: Use tracing error_log with probe events
2019-04-02 18:24:07 -04:00
trace_mmiotrace.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace_nop.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace_output.c
tracing: Fix out-of-range read in trace_stack_print()
2019-06-14 16:28:42 -04:00
trace_output.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_preemptirq.c
kprobes: Prohibit probing on hardirq tracers
2019-02-13 08:16:40 +01:00
trace_printk.c
tracing: Trivia spelling fix containerof() -> container_of()
2018-09-26 12:21:00 +03:00
trace_probe_tmpl.h
tracing: probeevent: Do not accumulate on ret variable
2019-05-08 12:15:11 -04:00
trace_probe.c
tracing: Replace kzalloc with kcalloc
2019-05-08 12:15:12 -04:00
trace_probe.h
tracing: uprobes: Re-enable $comm support for uprobe events
2019-05-08 12:15:11 -04:00
trace_sched_switch.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace_sched_wakeup.c
tracing: Add conditional snapshot
2019-02-20 13:51:06 -05:00
trace_selftest_dynamic.c
ftrace: Mark function tracer test functions noinline/noclone
2018-01-23 15:57:29 -05:00
trace_selftest.c
function_graph: Have selftest also emulate tr->reset() as it did with tr->init()
2019-04-21 19:46:56 -04:00
trace_seq.c
tracing: Add SPDX License format tags to tracing files
2018-08-16 19:08:06 -04:00
trace_stack.c
tracing: Remove the last struct stack_trace usage
2019-04-29 12:37:56 +02:00
trace_stat.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
trace_stat.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_syscalls.c
syscalls: Remove start and number from syscall_get_arguments() args
2019-04-05 09:26:43 -04:00
trace_uprobe.c
tracing/uprobe: Fix obsolete comment on trace_uprobe_create()
2019-06-14 17:00:36 -04:00
trace.c
tracing: Fix memory leak in tracing_err_log_open()
2019-06-28 14:57:23 -04:00
trace.h
tracing: Silence GCC 9 array bounds warning
2019-05-25 23:04:30 -04:00
tracing_map.c
tracing: Add SPDX License format tags to tracing files
2018-08-16 19:08:06 -04:00
tracing_map.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00