Baokun Li d13f996327 ext4: turn quotas off if mount failed after enabling quotas ... Yi found during a review of the patch "ext4: don't BUG on inconsistent journal feature" that when ext4_mark_recovery_complete() returns an error value, the error handling path does not turn off the enabled quotas, which triggers the following kmemleak: ================================================================ unreferenced object 0xffff8cf68678e7c0 (size 64): comm "mount", pid 746, jiffies 4294871231 (age 11.540s) hex dump (first 32 bytes): 00 90 ef 82 f6 8c ff ff 00 00 00 00 41 01 00 00 ............A... c7 00 00 00 bd 00 00 00 0a 00 00 00 48 00 00 00 ............H... backtrace: [<00000000c561ef24>] __kmem_cache_alloc_node+0x4d4/0x880 [<00000000d4e621d7>] kmalloc_trace+0x39/0x140 [<00000000837eee74>] v2_read_file_info+0x18a/0x3a0 [<0000000088f6c877>] dquot_load_quota_sb+0x2ed/0x770 [<00000000340a4782>] dquot_load_quota_inode+0xc6/0x1c0 [<0000000089a18bd5>] ext4_enable_quotas+0x17e/0x3a0 [ext4] [<000000003a0268fa>] __ext4_fill_super+0x3448/0x3910 [ext4] [<00000000b0f2a8a8>] ext4_fill_super+0x13d/0x340 [ext4] [<000000004a9489c4>] get_tree_bdev+0x1dc/0x370 [<000000006e723bf1>] ext4_get_tree+0x1d/0x30 [ext4] [<00000000c7cb663d>] vfs_get_tree+0x31/0x160 [<00000000320e1bed>] do_new_mount+0x1d5/0x480 [<00000000c074654c>] path_mount+0x22e/0xbe0 [<0000000003e97a8e>] do_mount+0x95/0xc0 [<000000002f3d3736>] __x64_sys_mount+0xc4/0x160 [<0000000027d2140c>] do_syscall_64+0x3f/0x90 ================================================================ To solve this problem, we add a "failed_mount10" tag, and call ext4_quota_off_umount() in this tag to release the enabled qoutas. Fixes: 11215630aa ("ext4: don't BUG on inconsistent journal feature") Cc: stable@kernel.org Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Signed-off-by: Baokun Li <libaokun1@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230327141630.156875-2-libaokun1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>		2023-06-26 19:36:30 -04:00
..
.kunitconfig
acl.c	fs: port acl to mnt_idmap	2023-01-19 09:24:28 +01:00
acl.h	fs: port ->set_acl() to pass mnt_idmap	2023-01-19 09:24:27 +01:00
balloc.c	ext4: drop the call to ext4_error() from ext4_get_group_info()	2023-06-14 22:24:05 -04:00
bitmap.c	ext4: remove useless conditional branch code	2023-04-19 23:39:08 -04:00
block_validity.c	ext4: add ext4_sb_block_valid() refactored out of ext4_inode_block_valid()	2022-02-25 21:34:56 -05:00
crypto.c	ext4: refactor and move ext4_ioctl_get_encryption_pwsalt()	2022-05-21 22:24:24 -04:00
dir.c	ext4: fix spelling errors in comments	2022-05-11 15:19:06 -04:00
ext4_extents.h
ext4_jbd2.c	ext4: split ext4_journal_start trace for debug	2022-12-01 10:46:54 -05:00
ext4_jbd2.h	ext4: split ext4_journal_start trace for debug	2022-12-01 10:46:54 -05:00
ext4.h	ext4: clean up mballoc criteria comments	2023-06-26 19:35:12 -04:00
extents_status.c	ext4: make ext4_es_insert_extent() return void	2023-06-26 19:35:12 -04:00
extents_status.h	ext4: make ext4_es_insert_extent() return void	2023-06-26 19:35:12 -04:00
extents.c	ext4: make ext4_zeroout_es() return void	2023-06-26 19:35:12 -04:00
fast_commit.c	ext4: use ext4_fc_tl_mem in fast-commit replay path	2023-02-09 10:43:23 -05:00
fast_commit.h	ext4: add missing validation of fast-commit record lengths	2022-12-08 21:49:24 -05:00
file.c	ext4: allow concurrent unaligned dio overwrites	2023-06-26 19:35:12 -04:00
fsmap.c	ext4: fix another off-by-one fsmap error on 1k block filesystems	2023-03-07 20:20:48 -05:00
fsmap.h
fsync.c	ext4: fix fsync for non-directories	2023-05-30 15:33:57 -04:00
hash.c	ext4: improve error handling from ext4_dirhash()	2023-05-13 18:05:05 -04:00
ialloc.c	ext4: allow ext4_get_group_info() to fail	2023-05-13 18:02:46 -04:00
indirect.c	ext4: only update i_reserved_data_blocks on successful block allocation	2023-06-26 19:34:56 -04:00
inline.c	ext4: make ext4_es_remove_extent() return void	2023-06-26 19:35:12 -04:00
inode-test.c
inode.c	ext4: make ext4_es_insert_extent() return void	2023-06-26 19:35:12 -04:00
ioctl.c	Bug fixes and regressions for ext4, the most serious of which is a	2023-03-12 08:55:55 -07:00
Kconfig
Makefile	ext4: move ext4 crypto code to its own file crypto.c	2022-05-21 22:24:24 -04:00
mballoc.c	ext4: clean up mballoc criteria comments	2023-06-26 19:35:12 -04:00
mballoc.h	ext4: Give symbolic names to mballoc criterias	2023-06-26 19:34:56 -04:00
migrate.c	ext4: avoid deadlock in fs reclaim with page writeback	2023-05-13 18:05:04 -04:00
mmp.c	ext4: fix lockdep warning when enabling MMP	2023-05-07 21:11:18 -04:00
move_extent.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
namei.c	ext4: improve error handling from ext4_dirhash()	2023-05-13 18:05:05 -04:00
orphan.c	ext4: remove trailing newline from ext4_msg() message	2022-12-08 21:49:23 -05:00
page-io.c	ext4: remove unneeded check of nr_to_submit	2023-04-19 23:38:33 -04:00
readpage.c	ext4: Call fsverity_verify_folio()	2023-06-15 00:02:10 -04:00
resize.c	ext4: remove unused group parameter in ext4_block_bitmap_csum_set	2023-03-23 23:00:08 -04:00
super.c	ext4: turn quotas off if mount failed after enabling quotas	2023-06-26 19:36:30 -04:00
symlink.c	fs: port ->getattr() to pass mnt_idmap	2023-01-19 09:24:25 +01:00
sysfs.c	ext4: Give symbolic names to mballoc criterias	2023-06-26 19:34:56 -04:00
truncate.h
verity.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
xattr_hurd.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_security.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_trusted.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_user.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr.c	ext4: only check dquot_initialize_needed() when debugging	2023-06-08 10:06:40 -04:00
xattr.h	ext4: remove EA inode entry from mbcache on inode eviction	2022-08-02 23:56:25 -04:00