Eric Dumazet d1f496fd8f bpf: restore skb->sk before pskb_trim() call
While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE()
in skb_try_coalesce() reported by Andrey, I found that we had an skb
with skb->sk set but no skb->destructor.

This invalidated heuristic found in commit 158f323b9868 ("net: adjust
skb->truesize in pskb_expand_head()") and in cited patch.

Considering the BUG_ON(skb->sk) we have in skb_orphan(), we should
restrain the temporary setting to a minimal section.

[1] https://patchwork.ozlabs.org/patch/755570/
    net: adjust skb->truesize in ___pskb_trim()

Fixes: 8f917bba0042 ("bpf: pass sk to helper functions")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-04-30 22:23:16 -04:00
..
2017-03-12 23:47:16 -07:00
2017-02-07 13:07:47 -05:00
2017-04-14 10:05:36 +02:00
2017-04-27 16:35:57 -04:00
2017-04-03 19:04:48 -07:00
2017-04-25 13:33:49 -04:00
2015-04-02 14:04:59 -04:00
2015-11-22 11:54:10 -05:00
2017-04-25 13:33:49 -04:00
2017-04-13 13:58:20 -04:00
2015-10-26 22:24:22 -07:00
2017-03-24 13:27:19 -07:00