Yintian Tao
d2790e10d3
drm/amdgpu: no need to clean debugfs at amdgpu ...
drm_minor_unregister will invoke drm_debugfs_cleanup
to clean all the child node under primary minor node.
We don't need to invoke amdgpu_debugfs_fini and
amdgpu_debugfs_regs_cleanup to clean agian.
Otherwise, it will raise the NULL pointer like below.
[ 45.046029] BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8
[ 45.047256] PGD 0 P4D 0
[ 45.047713] Oops: 0002 [#1 ] SMP PTI
[ 45.048198] CPU: 0 PID: 2796 Comm: modprobe Tainted: G W OE 4.18.0-15-generic #16~18.04.1-Ubuntu
[ 45.049538] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
[ 45.050651] RIP: 0010:down_write+0x1f/0x40
[ 45.051194] Code: 90 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 53 48 89 fb e8 ce d9 ff ff 48 ba 01 00 00 00 ff ff ff ff 48 89 d8 <f0> 48 0f c1 10 85 d2 74 05 e8 53 1c ff ff 65 48 8b 04 25 00 5c 01
[ 45.053702] RSP: 0018:ffffad8f4133fd40 EFLAGS: 00010246
[ 45.054384] RAX: 00000000000000a8 RBX: 00000000000000a8 RCX: ffffa011327dd814
[ 45.055349] RDX: ffffffff00000001 RSI: 0000000000000001 RDI: 00000000000000a8
[ 45.056346] RBP: ffffad8f4133fd48 R08: 0000000000000000 R09: ffffffffc0690a00
[ 45.057326] R10: ffffad8f4133fd58 R11: 0000000000000001 R12: ffffa0113cff0300
[ 45.058266] R13: ffffa0113c0a0000 R14: ffffffffc0c02a10 R15: ffffa0113e5c7860
[ 45.059221] FS: 00007f60d46f9540(0000) GS:ffffa0113fc00000(0000) knlGS:0000000000000000
[ 45.060809] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 45.061826] CR2: 00000000000000a8 CR3: 0000000136250004 CR4: 00000000003606f0
[ 45.062913] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 45.064404] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 45.065897] Call Trace:
[ 45.066426] debugfs_remove+0x36/0xa0
[ 45.067131] amdgpu_debugfs_ring_fini+0x15/0x20 [amdgpu]
[ 45.068019] amdgpu_debugfs_fini+0x2c/0x50 [amdgpu]
[ 45.068756] amdgpu_pci_remove+0x49/0x70 [amdgpu]
[ 45.069439] pci_device_remove+0x3e/0xc0
[ 45.070037] device_release_driver_internal+0x18a/0x260
[ 45.070842] driver_detach+0x3f/0x80
[ 45.071325] bus_remove_driver+0x59/0xd0
[ 45.071850] driver_unregister+0x2c/0x40
[ 45.072377] pci_unregister_driver+0x22/0xa0
[ 45.073043] amdgpu_exit+0x15/0x57c [amdgpu]
[ 45.073683] __x64_sys_delete_module+0x146/0x280
[ 45.074369] do_syscall_64+0x5a/0x120
[ 45.074916] entry_SYSCALL_64_after_hwframe+0x44/0xa9
v2: remove all debugfs cleanup/fini code at amdgpu
v3: squash in unused variable removal
Signed-off-by: Yintian Tao <yttao@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2020-02-28 16:59:22 -05:00
2020-02-11 23:26:15 +01:00
2020-01-29 18:53:37 -08:00
2020-02-06 06:11:50 +00:00
2020-01-28 16:02:33 -08:00
2020-02-08 14:04:19 -08:00
2020-01-28 16:02:33 -08:00
2020-02-08 13:26:41 -08:00
2020-01-24 19:57:53 +01:00
2020-02-15 10:33:19 -08:00
2020-02-16 13:05:46 -08:00
2020-02-08 14:17:27 -08:00
2020-02-08 14:17:27 -08:00
2020-02-14 10:40:48 +01:00
2020-02-08 14:04:19 -08:00
2020-01-28 16:02:33 -08:00
2020-01-16 09:52:27 -08:00
2020-01-16 19:14:49 +09:00
2020-02-08 13:58:44 -08:00
2020-02-17 10:27:25 +01:00
2020-02-13 13:29:41 +01:00
2020-01-06 09:45:59 +01:00
2020-02-08 14:04:19 -08:00
2020-01-10 12:51:56 -08:00
2020-02-10 13:54:17 +01:00
2020-02-28 16:59:22 -05:00
2020-01-30 08:04:01 -08:00
2020-02-03 14:42:03 +00:00
2020-02-12 12:43:01 -08:00
2020-01-21 16:16:36 -08:00
2020-01-14 15:38:28 +01:00
2020-02-07 12:54:13 -08:00
2020-01-13 10:00:05 +01:00
2020-02-04 03:05:26 +00:00
2020-02-03 11:57:18 +01:00
2020-02-04 07:17:41 +00:00
2020-02-14 15:21:52 -04:00
2020-02-15 16:49:25 -08:00
2020-01-07 09:30:09 +02:00
2020-02-05 17:49:54 +00:00
2020-01-06 09:45:59 +01:00
2020-02-09 15:47:37 -08:00
2020-02-04 03:05:26 +00:00
2020-01-22 21:08:24 +01:00
2020-02-04 13:06:46 +00:00
2020-01-08 10:41:52 +01:00
2020-02-16 12:35:52 -08:00
2020-02-04 07:17:41 +00:00
2020-01-16 10:45:44 -08:00
2020-01-19 22:10:04 +01:00
2020-02-04 07:17:41 +00:00
2020-02-07 12:54:13 -08:00
2020-01-27 13:03:00 -08:00
2020-02-04 03:05:27 +00:00
2020-02-14 07:05:17 -08:00
2020-01-19 22:10:04 +01:00
2020-01-31 10:30:37 -08:00
2020-02-16 12:35:52 -08:00
2020-02-07 12:54:13 -08:00
2020-02-08 14:04:19 -08:00
2020-01-27 13:03:00 -08:00
2020-01-13 13:19:38 -05:00
2020-02-04 03:05:26 +00:00
2020-02-06 14:17:38 +00:00
2020-02-10 18:14:46 +00:00
2020-02-04 03:05:27 +00:00
2020-02-04 03:05:24 +00:00
2020-02-04 07:24:48 +00:00
2020-02-04 03:05:26 +00:00
2020-02-08 13:55:25 -08:00
2020-01-13 10:32:19 +01:00
2020-01-19 22:10:04 +01:00
2020-01-20 15:40:49 +01:00
2020-02-03 14:51:57 +00:00
2020-01-24 09:34:07 -08:00
2020-01-10 22:20:37 -08:00
2020-01-20 10:29:56 -08:00
2020-02-04 07:17:41 +00:00
2020-02-11 20:14:28 +01:00
2020-02-08 17:24:41 -08:00
2020-01-06 09:45:59 +01:00
2020-01-14 21:46:53 +01:00
2020-01-14 21:46:48 +01:00
2020-02-11 15:00:15 -08:00
2020-01-16 17:34:38 +05:30
2020-02-04 03:05:27 +00:00
2020-02-10 13:16:04 +01:00
2020-01-06 09:45:59 +01:00
2020-02-04 03:05:26 +00:00
2020-01-29 18:16:16 -08:00
2020-01-31 11:28:31 -08:00
2020-02-08 14:04:19 -08:00
2020-01-31 14:39:21 -08:00
2020-01-14 15:37:41 +01:00
2020-02-09 16:05:50 -08:00
2020-01-14 15:27:51 +01:00
2020-02-08 13:26:41 -08:00
2020-02-03 22:22:05 +00:00
2020-02-26 13:31:18 +02:00
2020-02-06 03:40:27 -05:00
2020-01-14 15:30:35 +01:00
2020-01-29 10:35:54 -08:00
2020-01-29 10:35:54 -08:00
2020-02-07 12:30:16 -08:00
2020-02-05 17:44:14 +00:00
2020-02-09 16:05:50 -08:00
d2790e10d3