iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Davide Caratti 275c44aa19 net/sched: cls_u32: fix refcount leak in the error path of u32_change() 
when users replace cls_u32 filters with new ones having wrong parameters,
so that u32_change() fails to validate them, the kernel doesn't roll-back
correctly, and leaves semi-configured rules.

Fix this in u32_walk(), avoiding a call to the walker function on filters
that don't have a match rule connected. The side effect is, these "empty"
filters are not even dumped when present; but that shouldn't be a problem
as long as we are restoring the original behaviour, where semi-configured
filters were not even added in the error path of u32_change().

Fixes: 6676d5e416ee ("net: sched: set dedicated tcf_walker flag when tp is empty")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-12-19 17:53:05 -08:00
..
act_api.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_bpf.c
net: sched: update action implementations to support flags
2019-10-30 18:07:51 -07:00
act_connmark.c
net: sched: update action implementations to support flags
2019-10-30 18:07:51 -07:00
act_csum.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_ct.c
act_ct: support asymmetric conntrack
2019-12-04 16:31:15 -08:00
act_ctinfo.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_gact.c
net: sched: update action implementations to support flags
2019-10-30 18:07:51 -07:00
act_ife.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_ipt.c
net: sched: update action implementations to support flags
2019-10-30 18:07:51 -07:00
act_meta_mark.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
act_mirred.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_mpls.c
net: Fixed updating of ethertype in skb_mpls_push()
2019-12-04 17:11:25 -08:00
act_nat.c
icmp: remove duplicate code
2019-11-05 14:03:11 -08:00
act_pedit.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-11-22 16:27:24 -08:00
act_police.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_sample.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_simple.c
net_sched: extend packet counter to 64bit
2019-11-05 18:20:55 -08:00
act_skbedit.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_skbmod.c
net: sched: update action implementations to support flags
2019-10-30 18:07:51 -07:00
act_tunnel_key.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
act_vlan.c
Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-11-26 15:42:43 -08:00
cls_api.c
net_sched: validate TCA_KIND attribute in tc_chain_tmplt_add()
2019-12-07 12:04:16 -08:00
cls_basic.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_bpf.c
net: cls_bpf: fix NULL deref on offload filter removal
2019-11-01 15:16:01 -07:00
cls_cgroup.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_flow.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_flower.c
cls_flower: Fix the behavior using port ranges with hw-offload
2019-12-03 11:55:46 -08:00
cls_fw.c
net: sched: remove NET_CLS_IND config option
2019-06-15 14:06:13 -07:00
cls_matchall.c
net: sched: cls_matchall: cleanup flow_action before deallocating
2019-08-30 15:12:05 -07:00
cls_route.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_rsvp.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
cls_tcindex.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
cls_u32.c
net/sched: cls_u32: fix refcount leak in the error path of u32_change()
2019-12-19 17:53:05 -08:00
em_canid.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11
2019-05-21 11:28:45 +02:00
em_cmp.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_ipset.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
em_ipt.c
net: sched: em_ipt: add support for addrtype matching
2019-06-29 11:15:12 -07:00
em_meta.c
net: annotate lockless accesses to sk->sk_max_ack_backlog
2019-11-06 16:14:48 -08:00
em_nbyte.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_text.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
em_u32.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ematch.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
Kconfig
net/sched: Set default of CONFIG_NET_TC_SKB_EXT to N
2019-09-27 20:08:28 +02:00
Makefile
net/sched: Introduce action ct
2019-07-09 12:11:59 -07:00
sch_api.c
net_sched: fix backward compatibility for TCA_KIND
2019-10-08 16:21:58 -07:00
sch_atm.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
sch_blackhole.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_cake.c
sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
2019-12-02 12:33:00 -08:00
sch_cbq.c
sch_cbq: validate TCA_CBQ_WRROPT to avoid crash
2019-09-30 11:07:46 -07:00
sch_cbs.c
net: sched: cbs: Avoid division by zero when calculating the port rate
2019-10-01 09:51:39 -07:00
sch_choke.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sch_codel.c
net: sched: Fix a possible null-pointer dereference in dequeue_func()
2019-07-29 09:46:58 -07:00
sch_drr.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sch_dsmark.c
sch_dsmark: fix potential NULL deref in dsmark_init()
2019-10-04 18:28:30 -07:00
sch_etf.c
sched: etf: Fix ordering of packets with same txtime
2019-10-15 20:32:04 -07:00
sch_fifo.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_fq_codel.c
fq_codel: do not include <linux/jhash.h>
2019-10-22 15:31:42 -07:00
sch_fq.c
net_sched: sch_fq: remove one obsolete check in fq_dequeue()
2019-10-15 20:19:20 -07:00
sch_generic.c
net/sched: annotate lockless accesses to qdisc->empty
2019-11-08 12:21:55 -08:00
sch_gred.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_hfsc.c
netlink: make validation more configurable for future strictness
2019-04-27 17:07:21 -04:00
sch_hhf.c
net/flow_dissector: switch to siphash
2019-10-23 20:13:22 -07:00
sch_htb.c
net: sched: sch_htb: don't call qdisc_put() while holding tree lock
2019-09-27 12:13:55 +02:00
sch_ingress.c
net: flow_offload: rename TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_*
2019-07-09 14:38:50 -07:00
sch_mq.c
net: sched: fix dump qlen for sch_mq/sch_mqprio with NOLOCK subqueues
2019-12-03 11:53:55 -08:00
sch_mqprio.c
mqprio: Fix out-of-bounds access in mqprio_dump
2019-12-06 11:58:45 -08:00
sch_multiq.c
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-11-30 10:38:40 -08:00
sch_netem.c
net: netem: correct the parent's backlog when corrupted packet was dropped
2019-10-19 12:12:36 -07:00
sch_pie.c
net: sched: pie: enable timestamp based delay calculation
2019-11-20 12:31:45 -08:00
sch_plug.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_prio.c
net: sched: fix tc -s class show no bstats on class with nolock subqueues
2019-11-30 10:38:40 -08:00
sch_qfq.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
sch_red.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_sfb.c
net/flow_dissector: switch to siphash
2019-10-23 20:13:22 -07:00
sch_sfq.c
net/flow_dissector: switch to siphash
2019-10-23 20:13:22 -07:00
sch_skbprio.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_taprio.c
taprio: don't reject same mqprio settings
2019-11-19 15:23:15 -08:00
sch_tbf.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sch_teql.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00