Ye Bin
890d738f56
ext4: fix warning in 'ext4_da_release_space' ...
commit 1b8f787ef547230a3249bcf897221ef0cc78481b upstream.
Syzkaller report issue as follows:
EXT4-fs (loop0): Free/Dirty block details
EXT4-fs (loop0): free_blocks=0
EXT4-fs (loop0): dirty_blocks=0
EXT4-fs (loop0): Block reservation details
EXT4-fs (loop0): i_reserved_data_blocks=0
EXT4-fs warning (device loop0): ext4_da_release_space:1527: ext4_da_release_space: ino 18, to_free 1 with only 0 reserved data blocks
------------[ cut here ]------------
WARNING: CPU: 0 PID: 92 at fs/ext4/inode.c:1528 ext4_da_release_space+0x25e/0x370 fs/ext4/inode.c:1524
Modules linked in:
CPU: 0 PID: 92 Comm: kworker/u4:4 Not tainted 6.0.0-syzkaller-09423-g493ffd6605b2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
Workqueue: writeback wb_workfn (flush-7:0)
RIP: 0010:ext4_da_release_space+0x25e/0x370 fs/ext4/inode.c:1528
RSP: 0018:ffffc900015f6c90 EFLAGS: 00010296
RAX: 42215896cd52ea00 RBX: 0000000000000000 RCX: 42215896cd52ea00
RDX: 0000000000000000 RSI: 0000000080000001 RDI: 0000000000000000
RBP: 1ffff1100e907d96 R08: ffffffff816aa79d R09: fffff520002bece5
R10: fffff520002bece5 R11: 1ffff920002bece4 R12: ffff888021fd2000
R13: ffff88807483ecb0 R14: 0000000000000001 R15: ffff88807483e740
FS: 0000000000000000(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00005555569ba628 CR3: 000000000c88e000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
ext4_es_remove_extent+0x1ab/0x260 fs/ext4/extents_status.c:1461
mpage_release_unused_pages+0x24d/0xef0 fs/ext4/inode.c:1589
ext4_writepages+0x12eb/0x3be0 fs/ext4/inode.c:2852
do_writepages+0x3c3/0x680 mm/page-writeback.c:2469
__writeback_single_inode+0xd1/0x670 fs/fs-writeback.c:1587
writeback_sb_inodes+0xb3b/0x18f0 fs/fs-writeback.c:1870
wb_writeback+0x41f/0x7b0 fs/fs-writeback.c:2044
wb_do_writeback fs/fs-writeback.c:2187 [inline]
wb_workfn+0x3cb/0xef0 fs/fs-writeback.c:2227
process_one_work+0x877/0xdb0 kernel/workqueue.c:2289
worker_thread+0xb14/0x1330 kernel/workqueue.c:2436
kthread+0x266/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
</TASK>
Above issue may happens as follows:
ext4_da_write_begin
ext4_create_inline_data
ext4_clear_inode_flag(inode, EXT4_INODE_EXTENTS);
ext4_set_inode_flag(inode, EXT4_INODE_INLINE_DATA);
__ext4_ioctl
ext4_ext_migrate -> will lead to eh->eh_entries not zero, and set extent flag
ext4_da_write_begin
ext4_da_convert_inline_data_to_extent
ext4_da_write_inline_data_begin
ext4_da_map_blocks
ext4_insert_delayed_block
if (!ext4_es_scan_clu(inode, &ext4_es_is_delonly, lblk))
if (!ext4_es_scan_clu(inode, &ext4_es_is_mapped, lblk))
ext4_clu_mapped(inode, EXT4_B2C(sbi, lblk)); -> will return 1
allocated = true;
ext4_es_insert_delayed_block(inode, lblk, allocated);
ext4_writepages
mpage_map_and_submit_extent(handle, &mpd, &give_up_on_write); -> return -ENOSPC
mpage_release_unused_pages(&mpd, give_up_on_write); -> give_up_on_write == 1
ext4_es_remove_extent
ext4_da_release_space(inode, reserved);
if (unlikely(to_free > ei->i_reserved_data_blocks))
-> to_free == 1 but ei->i_reserved_data_blocks == 0
-> then trigger warning as above
To solve above issue, forbid inode do migrate which has inline data.
Cc: stable@kernel.org
Reported-by: syzbot+c740bb18df70ad00952e@syzkaller.appspotmail.com
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20221018022701.683489-1-yebin10@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-11-10 17:46:55 +01:00
2022-06-25 11:48:57 +02:00
2019-08-06 19:06:49 +02:00
2021-03-04 09:39:55 +01:00
2022-07-02 16:27:33 +02:00
2019-12-13 08:51:01 +01:00
2018-12-01 09:37:27 +01:00
2022-11-10 17:46:54 +01:00
2020-11-05 11:08:54 +01:00
2022-10-26 13:19:18 +02:00
2022-09-28 11:02:52 +02:00
2019-08-06 19:06:51 +02:00
2022-03-02 11:38:13 +01:00
2018-11-13 11:08:55 -08:00
2021-09-22 11:47:56 +02:00
2022-09-15 12:17:05 +02:00
2019-03-23 20:09:59 +01:00
2022-10-26 13:19:21 +02:00
2021-05-26 11:48:34 +02:00
2020-12-02 08:48:12 +01:00
2019-12-05 09:20:32 +01:00
2020-01-27 14:50:02 +01:00
2022-08-25 11:14:58 +02:00
2022-11-10 17:46:55 +01:00
2022-10-26 13:19:35 +02:00
2022-06-14 16:59:18 +02:00
2021-09-22 11:48:02 +02:00
2022-08-25 11:14:55 +02:00
2022-05-18 09:42:48 +02:00
2021-07-31 08:22:38 +02:00
2021-05-22 10:59:45 +02:00
2021-06-03 08:38:12 +02:00
2021-11-12 14:40:50 +01:00
2022-08-25 11:15:19 +02:00
2022-06-14 16:59:33 +02:00
2022-06-14 16:59:17 +02:00
2022-11-03 23:52:29 +09:00
2020-12-30 11:25:59 +01:00
2022-04-15 14:15:03 +02:00
2022-11-10 17:46:51 +01:00
2020-12-30 11:26:02 +01:00
2022-10-26 13:19:36 +02:00
2022-10-26 13:19:22 +02:00
2022-06-14 16:59:20 +02:00
2022-10-05 10:36:44 +02:00
2022-11-03 23:52:24 +09:00
2022-01-27 09:04:13 +01:00
2022-08-25 11:14:54 +02:00
2022-11-03 23:52:27 +09:00
2021-03-04 09:39:54 +01:00
2021-10-06 15:31:20 +02:00
2022-10-26 13:19:21 +02:00
2020-10-30 10:38:21 +01:00
2021-08-12 13:19:44 +02:00
2020-08-26 10:30:59 +02:00
2021-05-22 10:59:45 +02:00
2022-03-23 09:10:42 +01:00
2018-12-17 09:24:30 +01:00
2022-09-20 12:26:48 +02:00
2022-04-15 14:15:00 +02:00
2022-02-08 18:23:03 +01:00
2020-08-21 11:05:38 +02:00
2022-07-12 16:29:02 +02:00
2021-12-14 10:18:07 +01:00
2022-08-25 11:14:53 +02:00
2021-10-06 15:31:24 +02:00
2022-06-14 16:59:13 +02:00
2021-03-17 16:43:51 +01:00
2019-11-06 13:05:37 +01:00
2021-05-22 10:59:49 +02:00
2020-11-05 11:08:46 +01:00
2020-01-14 20:06:57 +01:00
2020-01-09 10:19:07 +01:00
2020-05-14 07:57:21 +02:00
2022-06-14 16:59:24 +02:00
2020-11-05 11:08:35 +01:00
2021-04-14 08:22:32 +02:00
2020-01-12 12:17:20 +01:00
2020-02-11 04:34:08 -08:00
2020-10-07 08:00:09 +02:00
2022-06-06 08:24:21 +02:00
2021-09-22 11:47:50 +02:00
2021-12-08 08:50:13 +01:00
2022-03-02 11:38:15 +01:00
2020-04-17 10:48:51 +02:00
2022-06-14 16:59:27 +02:00
2022-10-26 13:19:16 +02:00
2019-05-31 06:46:05 -07:00
2018-11-21 09:19:14 +01:00
2021-05-22 10:59:50 +02:00
2020-11-24 13:27:23 +01:00
2020-01-09 10:19:00 +01:00
2022-08-25 11:14:53 +02:00
2022-05-15 19:41:59 +02:00
2019-05-25 18:23:26 +02:00
2020-03-18 07:14:21 +01:00
2021-08-12 13:19:43 +02:00
2020-05-02 17:26:01 +02:00
2019-12-01 09:17:04 +01:00
2021-04-28 13:16:50 +02:00
2022-01-29 10:19:18 +01:00
2021-07-20 16:16:16 +02:00
2021-12-14 10:18:07 +01:00
2022-10-26 13:19:21 +02:00
2022-04-27 13:39:44 +02:00
2019-10-11 18:21:39 +02:00
2022-02-23 11:58:38 +01:00
2021-09-22 11:48:02 +02:00
2020-08-11 15:32:34 +02:00
890d738f56