iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Filipe Manana d4b450cd4b Btrfs: fix race between transaction commit and empty block group removal 
Committing a transaction can race with automatic removal of empty block
groups (cleaner kthread), leading to a BUG_ON() in the transaction
commit code while running btrfs_finish_extent_commit(). The following
sequence diagram shows how it can happen:

           CPU 1                                       CPU 2

btrfs_commit_transaction()
  fs_info->running_transaction = NULL
  btrfs_finish_extent_commit()
    find_first_extent_bit()
      -> found range for block group X
         in fs_info->freed_extents[]

                                               btrfs_delete_unused_bgs()
                                                 -> found block group X

                                                 Removed block group X's range
                                                 from fs_info->freed_extents[]

                                                 btrfs_remove_chunk()
                                                    btrfs_remove_block_group(bg X)

    unpin_extent_range(bg X range)
       btrfs_lookup_block_group(bg X)
          -> returns NULL
            -> BUG_ON()

The trace that results from the BUG_ON() is:

[48665.187808] ------------[ cut here ]------------
[48665.188032] kernel BUG at fs/btrfs/extent-tree.c:5675!
[48665.188032] invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC
[48665.188032] Modules linked in: dm_flakey dm_mod crc32c_generic btrfs xor raid6_pq nfsd auth_rpcgss oid_registry nfs_acl nfs lockd grace fscache sunrpc loop parport_pc evdev microcode
[48665.197388] CPU: 2 PID: 31211 Comm: kworker/u32:16 Tainted: G        W      3.19.0-rc5-btrfs-next-4+ #1
[48665.197388] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.7.5-0-ge51488c-20140602_164612-nilsson.home.kraxel.org 04/01/2014
[48665.197388] Workqueue: events_unbound btrfs_async_reclaim_metadata_space [btrfs]
[48665.197388] task: ffff880222011810 ti: ffff8801b56a4000 task.ti: ffff8801b56a4000
[48665.197388] RIP: 0010:[<ffffffffa0350d05>]  [<ffffffffa0350d05>] unpin_extent_range+0x6a/0x1ba [btrfs]
[48665.197388] RSP: 0018:ffff8801b56a7b88  EFLAGS: 00010246
[48665.197388] RAX: 0000000000000000 RBX: ffff8802143a6000 RCX: ffff8802220120c8
[48665.197388] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffff8800a3c140b0
[48665.197388] RBP: ffff8801b56a7bd8 R08: 0000000000000003 R09: 0000000000000000
[48665.197388] R10: 0000000000000000 R11: 000000000000bbac R12: 0000000012e8e000
[48665.197388] R13: ffff8800a3c14000 R14: 0000000000000000 R15: 0000000000000000
[48665.197388] FS:  0000000000000000(0000) GS:ffff88023ec40000(0000) knlGS:0000000000000000
[48665.197388] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[48665.197388] CR2: 00007f065e42f270 CR3: 0000000206f70000 CR4: 00000000000006e0
[48665.197388] Stack:
[48665.197388]  ffff8801b56a7bd8 0000000012ea0000 01ff8800a3c14138 0000000012e9ffff
[48665.197388]  ffff880141df3dd8 ffff8802143a6000 ffff8800a3c14138 ffff880141df3df0
[48665.197388]  ffff880141df3dd8 0000000000000000 ffff8801b56a7c08 ffffffffa0354227
[48665.197388] Call Trace:
[48665.197388]  [<ffffffffa0354227>] btrfs_finish_extent_commit+0xb0/0xd9 [btrfs]
[48665.197388]  [<ffffffffa0366b4b>] btrfs_commit_transaction+0x791/0x92c [btrfs]
[48665.197388]  [<ffffffffa0352432>] flush_space+0x43d/0x452 [btrfs]
[48665.197388]  [<ffffffff814295c3>] ? _raw_spin_unlock+0x28/0x33
[48665.197388]  [<ffffffffa035255f>] btrfs_async_reclaim_metadata_space+0x118/0x164 [btrfs]
[48665.197388]  [<ffffffff81059917>] ? process_one_work+0x14b/0x3ab
[48665.197388]  [<ffffffff810599ac>] process_one_work+0x1e0/0x3ab
[48665.197388]  [<ffffffff81079fa9>] ? trace_hardirqs_off+0xd/0xf
[48665.197388]  [<ffffffff8105a55b>] worker_thread+0x210/0x2d0
[48665.197388]  [<ffffffff8105a34b>] ? rescuer_thread+0x2c3/0x2c3
[48665.197388]  [<ffffffff8105e5c0>] kthread+0xef/0xf7
[48665.197388]  [<ffffffff81429682>] ? _raw_spin_unlock_irq+0x2d/0x39
[48665.197388]  [<ffffffff8105e4d1>] ? __kthread_parkme+0xad/0xad
[48665.197388]  [<ffffffff81429dec>] ret_from_fork+0x7c/0xb0
[48665.197388]  [<ffffffff8105e4d1>] ? __kthread_parkme+0xad/0xad
[48665.197388] Code: 85 f6 74 14 49 8b 06 49 03 46 09 49 39 c4 72 1d 4c 89 f7 e8 83 ec ff ff 4c 89 e6 4c 89 ef e8 1e f1 ff ff 48 85 c0 49 89 c6 75 02 <0f> 0b 49 8b 1e 49 03 5e 09 48 8b
[48665.197388] RIP  [<ffffffffa0350d05>] unpin_extent_range+0x6a/0x1ba [btrfs]
[48665.197388]  RSP <ffff8801b56a7b88>
[48665.272246] ---[ end trace b9c6ab9957521376 ]---

Fix this by ensuring that unpining the block group's range in
btrfs_finish_extent_commit() is done in a synchronized fashion
with removing the block group's range from freed_extents[]
in btrfs_delete_unused_bgs()

This race got introduced with the change:

    Btrfs: remove empty block groups automatically
    commit 47ab2a6c689913db23ccae38349714edf8365e0a

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
2015-02-02 19:24:48 -08:00
..
9p
assorted conversions to %p[dD]
2014-11-19 13:01:20 -05:00
adfs
adfs: add __printf verification, fix format/argument mismatches
2014-08-08 15:57:24 -07:00
affs
fs/affs/file.c: remove obsolete pagesize check
2014-12-13 12:42:52 -08:00
afs
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2014-12-11 14:27:06 -08:00
autofs4
assorted conversions to %p[dD]
2014-11-19 13:01:20 -05:00
befs
befs: remove dead code
2014-12-13 12:42:51 -08:00
bfs
fs/bfs: use bfs prefix for dump_imap
2014-08-08 15:57:24 -07:00
btrfs
Btrfs: fix race between transaction commit and empty block group removal
2015-02-02 19:24:48 -08:00
cachefiles
assorted conversions to %p[dD]
2014-11-19 13:01:20 -05:00
ceph
ceph: use %zu for len in ceph_fill_inline_data()
2015-01-08 20:36:56 +03:00
cifs
cifs: make new inode cache when file type is different
2014-12-22 14:16:21 -06:00
coda
coda_venus_readdir(): use file_inode()
2014-12-11 16:28:12 -05:00
configfs
assorted conversions to %p[dD]
2014-11-19 13:01:20 -05:00
cramfs
fs/cramfs/inode.c: use linux/uaccess.h
2014-08-08 15:57:25 -07:00
debugfs
Driver core patches for 3.19-rc1
2014-12-14 16:10:09 -08:00
devpts
…
dlm
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-12-10 16:10:49 -08:00
ecryptfs
Fixes for filename decryption and encrypted view plus a cleanup
2014-12-19 18:15:12 -08:00
efivarfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-12-10 16:10:49 -08:00
efs
fs/efs/namei.c: return is not a function
2014-08-08 15:57:18 -07:00
exofs
Boaz Harrosh - Fix broken email address
2014-10-19 20:22:32 +03:00
exportfs
move d_rcu from overlapping d_child to overlapping d_alias
2014-11-03 15:20:29 -05:00
ext2
ext2: Convert to private i_dquot field
2014-11-10 10:06:10 +01:00
ext3
ext3: Convert to private i_dquot field
2014-11-10 10:06:10 +01:00
ext4
Revert a potential seek_data/hole regression which shows up when using
2015-01-06 14:05:40 -08:00
f2fs
f2fs: avoid to ra unneeded blocks in recover flow
2014-12-08 14:19:09 -08:00
fat
fat: fix data past EOF resulting from fsx testsuite
2014-12-13 12:42:51 -08:00
freevxfs
…
fscache
fs/fscache/object-list.c: use __seq_open_private()
2014-10-13 17:52:21 +01:00
fuse
fuse: add memory barrier to INIT
2015-01-06 10:45:35 +01:00
gfs2
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-12-10 16:10:49 -08:00
hfs
fs/hfs/catalog.c: fix comparison bug in hfs_cat_keycmp
2014-12-10 17:41:16 -08:00
hfsplus
hfsplus: fix longname handling
2014-12-18 19:08:10 -08:00
hostfs
hostfs: support rename flags
2014-08-07 14:40:09 -04:00
hpfs
fs/hpfs/dnode.c: fix suspect code indent
2014-08-08 15:57:22 -07:00
hppfs
vfs: make first argument of dir_context.actor typed
2014-10-31 17:48:54 -04:00
hugetlbfs
mm: convert i_mmap_mutex to rwsem
2014-12-13 12:42:45 -08:00
isofs
isofs: Fix unchecked printing of ER records
2014-12-19 11:29:24 +01:00
jbd
jbd: Deletion of an unnecessary check before the function call "iput"
2014-11-18 10:15:29 +01:00
jbd2
Lots of bugs fixes, including Zheng and Jan's extent status shrinker
2014-12-12 09:28:03 -08:00
jffs2
jffs2: Drop bogus if in comment
2014-11-28 18:23:44 -08:00
jfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-12-10 16:10:49 -08:00
kernfs
kernfs: Fix kernfs_name_compare
2015-01-09 15:51:08 -08:00
lockd
LOCKD: Fix a race when initialising nlmsvc_timeout
2015-01-05 19:40:53 -08:00
logfs
fs/logfs/readwrite.c: kernel-doc warning fixes
2014-08-06 18:01:12 -07:00
minix
minix zmap block counts calculation fix
2014-08-08 15:57:20 -07:00
ncpfs
Merge branch 'akpm' (patchbomb from Andrew)
2014-12-10 18:34:42 -08:00
nfs
NFSv4: Remove incorrect check in can_open_delegated()
2015-01-05 19:40:54 -08:00
nfs_common
lockd: move lockd's grace period handling into its own module
2014-09-17 16:33:11 -04:00
nfsd
nfsd: fix fi_delegees leak when fi_had_conflict returns true
2015-01-07 13:38:21 -05:00
nilfs2
nilfs2: fix the nilfs_iget() vs. nilfs_new_inode() races
2014-12-10 17:41:16 -08:00
nls
…
notify
sched, fanotify: Deal with nested sleeps
2015-01-09 11:18:12 +01:00
ntfs
assorted conversions to %p[dD]
2014-11-19 13:01:20 -05:00
ocfs2
ocfs2: fix the wrong directory passed to ocfs2_lookup_ino_from_name() when link file
2015-01-08 15:10:51 -08:00
omfs
FS/OMFS: block number sanity check during fill_super operation
2014-10-14 02:18:22 +02:00
openpromfs
…
overlayfs
Merge branch 'iov_iter' into for-next
2014-12-08 20:39:29 -05:00
proc
Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-19 13:26:08 -08:00
pstore
Driver core patches for 3.19-rc1
2014-12-14 16:10:09 -08:00
qnx4
…
qnx6
fs/qnx6: update debugging to current functions
2014-08-08 15:57:26 -07:00
quota
vfs: Remove i_dquot field from inode
2014-11-10 10:06:18 +01:00
ramfs
fs/ramfs/file-nommu.c: replace count*size kzalloc by kcalloc
2014-08-08 15:57:18 -07:00
reiserfs
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2014-12-16 15:46:01 -08:00
romfs
fs/romfs/super.c: add blank line after declarations
2014-08-08 15:57:25 -07:00
squashfs
Squashfs: Add LZ4 compression configuration option
2014-11-27 18:48:44 +00:00
sysfs
sysfs/kernfs: make read requests on pre-alloc files use the buffer.
2014-11-07 10:54:38 -08:00
sysv
…
ubifs
UBIFS: fix a couple bugs in UBIFS xattr length calculation
2014-11-07 12:32:22 +02:00
udf
udf: Reduce repeated dereferences
2014-12-21 22:42:37 +01:00
ufs
fs/ufs/balloc.c: remove unused variable
2014-10-14 02:18:20 +02:00
xfs
xfs: update for 3.19-rc1
2014-12-12 09:48:17 -08:00
aio.c
aio: Skip timer for io_getevents if timeout=0
2014-12-13 17:50:20 -05:00
anon_inodes.c
…
attr.c
…
bad_inode.c
bad_inode: add ->rename2()
2014-08-07 14:40:09 -04:00
binfmt_aout.c
assorted conversions to %p[dD]
2014-11-19 13:01:20 -05:00
binfmt_elf_fdpic.c
handle suicide on late failure exits in execve() in search_binary_handler()
2014-10-09 02:39:00 -04:00
binfmt_elf.c
Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus
2014-12-11 17:56:37 -08:00
binfmt_em86.c
syscalls: implement execveat() system call
2014-12-13 12:42:51 -08:00
binfmt_flat.c
…
binfmt_misc.c
unfuck binfmt_misc.c (broken by commit e6084d4)
2014-12-17 08:27:14 -05:00
binfmt_script.c
syscalls: implement execveat() system call
2014-12-13 12:42:51 -08:00
binfmt_som.c
…
block_dev.c
fs: add freeze_super/thaw_super fs hooks
2014-11-17 10:35:17 +00:00
buffer.c
fs: clarify rate limit suppressed buffer I/O errors
2014-10-21 13:55:11 -06:00
char_dev.c
fs/char_dev.c: remove pointless assignment from __register_chrdev_region()
2014-12-10 17:41:04 -08:00
compat_binfmt_elf.c
…
compat_ioctl.c
Bluetooth: Move HCI socket definitions into its own header file
2014-07-11 13:53:04 +03:00
compat.c
vfs: make first argument of dir_context.actor typed
2014-10-31 17:48:54 -04:00
coredump.c
coredump: add %i/%I in core_pattern to report the tid of the crashed thread
2014-10-14 02:18:21 +02:00
dcache.c
Merge branch 'iov_iter' into for-next
2014-12-08 20:39:29 -05:00
dcookies.c
…
direct-io.c
fuse: honour max_read and max_write in direct_io mode
2014-09-26 21:16:51 -04:00
drop_caches.c
mm: vmscan: invoke slab shrinkers from shrink_zone()
2014-12-13 12:42:48 -08:00
eventfd.c
fs: Convert show_fdinfo functions to void
2014-11-05 14:13:23 -05:00
eventpoll.c
fs: Convert show_fdinfo functions to void
2014-11-05 14:13:23 -05:00
exec.c
syscalls: implement execveat() system call
2014-12-13 12:42:51 -08:00
fcntl.c
vfs: renumber FMODE_NONOTIFY and add to uniqueness check
2015-01-08 15:10:52 -08:00
fhandle.c
…
file_table.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-10-13 11:28:42 +02:00
file.c
fs/file.c: replace get_unused_fd() with get_unused_fd_flags(0)
2014-12-10 17:41:10 -08:00
filesystems.c
…
fs_pin.c
make fs/{namespace,super}.c forget about acct.h
2014-08-07 14:40:09 -04:00
fs_struct.c
…
fs-writeback.c
writeback: fix a subtle race condition in I_DIRTY clearing
2014-11-04 10:42:23 -07:00
inode.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-12-16 15:53:03 -08:00
internal.h
take the targets of /proc/*/ns/* symlinks to separate fs
2014-12-10 21:30:20 -05:00
ioctl.c
Merge branch 'for-3.19' of git://linux-nfs.org/~bfields/linux
2014-12-16 15:25:31 -08:00
Kconfig
overlay filesystem
2014-10-24 00:14:38 +02:00
Kconfig.binfmt
binfmt_elf: allow arch code to examine PT_LOPROC ... PT_HIPROC headers
2014-11-24 07:45:02 +01:00
libfs.c
move d_rcu from overlapping d_child to overlapping d_alias
2014-11-03 15:20:29 -05:00
locks.c
locks: fix NULL-deref in generic_delete_lease
2015-01-13 07:00:55 -05:00
Makefile
Merge branch 'nsfs' into for-next
2014-12-10 21:31:59 -05:00
mbcache.c
fs/mbcache: replace __builtin_log2() with ilog2()
2014-06-25 22:08:29 -04:00
mount.h
common object embedded into various struct ....ns
2014-12-04 14:31:00 -05:00
mpage.c
vfs: guard end of device for mpage interface
2014-10-09 22:25:53 -04:00
namei.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2014-12-16 15:53:03 -08:00
namespace.c
mnt: Fix a memory stomp in umount
2014-12-18 11:22:02 -08:00
no-block.c
…
nsfs.c
take the targets of /proc/*/ns/* symlinks to separate fs
2014-12-10 21:30:20 -05:00
open.c
Merge branch 'for-3.19' of git://linux-nfs.org/~bfields/linux
2014-12-16 15:25:31 -08:00
pipe.c
…
pnode.c
mnt: Move the clear of MNT_LOCKED from copy_tree to it's callers.
2014-12-02 10:46:50 -06:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
vfs: make mounts and mountstats honor root dir like mountinfo does
2014-12-17 08:27:15 -05:00
read_write.c
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2014-12-14 20:36:37 -08:00
readdir.c
vfs: make first argument of dir_context.actor typed
2014-10-31 17:48:54 -04:00
select.c
…
seq_file.c
fs, seq_file: fallback to vmalloc instead of oom kill processes
2014-12-13 12:42:49 -08:00
signalfd.c
fs: Convert show_fdinfo functions to void
2014-11-05 14:13:23 -05:00
splice.c
vfs: export do_splice_direct() to modules
2014-10-24 00:14:35 +02:00
stack.c
fs: fix comment for 'CONFIG_LBADF'
2014-08-26 09:35:56 +02:00
stat.c
…
statfs.c
…
super.c
vfs: Remove i_dquot field from inode
2014-11-10 10:06:18 +01:00
sync.c
kill f_dentry uses
2014-11-19 13:01:25 -05:00
timerfd.c
fs: Convert show_fdinfo functions to void
2014-11-05 14:13:23 -05:00
utimes.c
…
xattr.c
new helper: audit_file()
2014-11-19 13:01:26 -05:00