iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
YueHaibing 9533dbfac0 can: bcm: Fix UAF in bcm_proc_show() 
commit 55c3b96074f3f9b0aee19bf93cd71af7516582bb upstream.

BUG: KASAN: slab-use-after-free in bcm_proc_show+0x969/0xa80
Read of size 8 at addr ffff888155846230 by task cat/7862

CPU: 1 PID: 7862 Comm: cat Not tainted 6.5.0-rc1-00153-gc8746099c197 #230
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xd5/0x150
 print_report+0xc1/0x5e0
 kasan_report+0xba/0xf0
 bcm_proc_show+0x969/0xa80
 seq_read_iter+0x4f6/0x1260
 seq_read+0x165/0x210
 proc_reg_read+0x227/0x300
 vfs_read+0x1d5/0x8d0
 ksys_read+0x11e/0x240
 do_syscall_64+0x35/0xb0
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Allocated by task 7846:
 kasan_save_stack+0x1e/0x40
 kasan_set_track+0x21/0x30
 __kasan_kmalloc+0x9e/0xa0
 bcm_sendmsg+0x264b/0x44e0
 sock_sendmsg+0xda/0x180
 ____sys_sendmsg+0x735/0x920
 ___sys_sendmsg+0x11d/0x1b0
 __sys_sendmsg+0xfa/0x1d0
 do_syscall_64+0x35/0xb0
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 7846:
 kasan_save_stack+0x1e/0x40
 kasan_set_track+0x21/0x30
 kasan_save_free_info+0x27/0x40
 ____kasan_slab_free+0x161/0x1c0
 slab_free_freelist_hook+0x119/0x220
 __kmem_cache_free+0xb4/0x2e0
 rcu_core+0x809/0x1bd0

bcm_op is freed before procfs entry be removed in bcm_release(),
this lead to bcm_proc_show() may read the freed bcm_op.

Fixes: ffd980f976e7 ("[CAN]: Add broadcast manager (bcm) protocol")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://lore.kernel.org/all/20230715092543.15548-1-yuehaibing@huawei.com
Cc: stable@vger.kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-07-27 08:37:40 +02:00
..
6lowpan
6lowpan: iphc: Fix an off-by-one check of array index
2021-09-15 09:47:31 +02:00
9p
9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition
2023-04-20 12:07:36 +02:00
802
mrp: introduce active flags to prevent UAF when applicant uninit
2023-01-18 11:41:37 +01:00
8021q
vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()
2023-05-30 12:44:06 +01:00
appletalk
appletalk: Fix skb allocation size in loopback case
2021-04-07 14:47:41 +02:00
atm
atm: hide unused procfs functions
2023-06-09 10:28:59 +02:00
ax25
ax25: Fix UAF bugs in ax25 timers
2022-04-20 09:19:40 +02:00
batman-adv
batman-adv: Broken sync while rescheduling delayed work
2023-06-14 10:59:56 +02:00
bluetooth
Bluetooth: Fix use-after-free in hci_remove_ltk/hci_remove_irk
2023-06-14 10:59:58 +02:00
bpf
bpf: Move skb->len == 0 checks into __bpf_redirect
2023-01-18 11:41:04 +01:00
bpfilter
bpfilter: Specify the log level for the kmsg message
2021-07-14 16:53:33 +02:00
bridge
net: bridge: keep ports without IFF_UNICAST_FLT in BR_PROMISC mode
2023-07-27 08:37:23 +02:00
caif
net: caif: Fix use-after-free in cfusbl_device_notify()
2023-03-17 08:32:51 +01:00
can
can: bcm: Fix UAF in bcm_proc_show()
2023-07-27 08:37:40 +02:00
ceph
libceph: clear con->out_msg on Policy::stateful_server faults
2020-11-05 11:43:34 +01:00
core
netlink: Add __sock_i_ino() for __netlink_diag_dump().
2023-07-27 08:37:12 +02:00
dcb
net: dcb: disable softirqs in dcbnl_flush_dev()
2022-03-08 19:07:51 +01:00
dccp
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
decnet
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
dns_resolver
KEYS: Don't write out to userspace while holding key semaphore
2020-04-23 10:36:45 +02:00
dsa
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
2023-07-27 08:37:24 +02:00
ethernet
…
hsr
hsr: Avoid double remove of a node.
2023-01-18 11:41:09 +01:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-11-03 23:56:54 +09:00
ife
…
ipv4
tcp: annotate data races in __tcp_oow_rate_limited()
2023-07-27 08:37:23 +02:00
ipv6
ipv6/addrconf: fix a potential refcount underflow for idev
2023-07-27 08:37:32 +02:00
iucv
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
2023-04-20 12:07:32 +02:00
kcm
kcm: close race conditions on sk_receive_queue
2022-11-25 17:42:21 +01:00
key
af_key: Reject optional tunnel/BEET mode templates in outbound policies
2023-05-30 12:44:05 +01:00
l2tp
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
2023-04-26 11:24:05 +02:00
l3mdev
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-27 13:50:47 +02:00
lapb
net: lapb: Copy the skb before sending a packet
2021-02-10 09:25:28 +01:00
llc
llc: only change llc->dev when bind() succeeds
2022-03-28 08:46:48 +02:00
mac80211
wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta
2023-04-20 12:07:33 +02:00
mac802154
mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()
2022-12-14 11:30:45 +01:00
mpls
net: mpls: fix stale pointer if allocation fails during device rename
2023-02-22 12:50:41 +01:00
ncsi
net/ncsi: clear Tx enable mode when handling a Config required AEN
2023-05-17 11:35:58 +02:00
netfilter
netfilter: nf_tables: prevent OOB access in nft_byteorder_eval
2023-07-27 08:37:28 +02:00
netlabel
netlabel: fix out-of-bounds memory accesses
2022-04-15 14:18:35 +02:00
netlink
netlink: Add __sock_i_ino() for __netlink_diag_dump().
2023-07-27 08:37:12 +02:00
netrom
netrom: fix info-leak in nr_write_internal()
2023-06-09 10:28:52 +02:00
nfc
net: nfc: Fix use-after-free caused by nfc_llcp_find_local
2023-07-27 08:37:11 +02:00
nsh
net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()
2023-05-30 12:44:05 +01:00
openvswitch
net: openvswitch: fix flow memory leak in ovs_flow_cmd_new
2023-02-22 12:50:25 +01:00
packet
af_packet: do not use READ_ONCE() in packet_bind()
2023-06-09 10:28:53 +02:00
phonet
phonet: refcount leak in pep_sock_accep
2022-01-11 15:23:33 +01:00
psample
…
qrtr
net: qrtr: fix another OOB Read in qrtr_endpoint_post
2021-09-03 10:08:12 +02:00
rds
rds: rds_rm_zerocopy_callback() correct order for list_add_tail()
2023-03-11 16:43:41 +01:00
rfkill
rfkill: Fix use-after-free in rfkill_resume()
2020-11-24 13:29:05 +01:00
rose
net/rose: Fix to not accept on connected socket
2023-02-22 12:50:34 +01:00
rxrpc
rxrpc: Fix hard call timeout units
2023-05-17 11:35:59 +02:00
sched
net/sched: flower: Ensure both minimum and maximum ports are specified
2023-07-27 08:37:33 +02:00
sctp
sctp: fix potential deadlock on &net->sctp.addr_wq_lock
2023-07-27 08:37:22 +02:00
smc
net/smc: fix fallback failed while sendmsg with fastopen
2023-03-17 08:32:51 +01:00
strparser
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-17 09:48:48 +01:00
sunrpc
SUNRPC: Fix UAF in svc_tcp_listen_data_ready()
2023-07-27 08:37:35 +02:00
switchdev
net: switchdev: do not propagate bridge updates across bridges
2021-10-27 09:54:24 +02:00
tipc
net: tipc: resize nlattr array to correct size
2023-06-21 15:44:12 +02:00
tls
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
unix
af_unix: Fix data races around sk->sk_shutdown.
2023-05-30 12:44:02 +01:00
vmw_vsock
vsock: avoid to close connected socket after the timeout
2023-05-30 12:44:05 +01:00
wimax
…
wireless
wifi: cfg80211: rewrite merging of inherited elements
2023-07-27 08:37:10 +02:00
x25
net/x25: Fix to not accept on connected socket
2023-02-22 12:50:26 +01:00
xdp
xsk: Honor SO_BINDTODEVICE on bind
2023-07-27 08:37:23 +02:00
xfrm
xfrm: Check if_id in inbound policy/secpath match
2023-06-09 10:28:56 +02:00
compat.c
net: Return the correct errno code
2021-06-18 09:59:00 +02:00
Kconfig
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
Makefile
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
socket.c
net: annotate sk->sk_err write from do_recvmmsg()
2023-05-30 12:44:01 +01:00
sysctl_net.c
…