David Ahern 382f57b996 ipv4: Update fib_select_default to handle nexthop objects ...

[ Upstream commit 7c74b0bec9 ]

A user reported [0] hitting the WARN_ON in fib_info_nh:

    [ 8633.839816] ------------[ cut here ]------------
    [ 8633.839819] WARNING: CPU: 0 PID: 1719 at include/net/nexthop.h:251 fib_select_path+0x303/0x381
    ...
    [ 8633.839846] RIP: 0010:fib_select_path+0x303/0x381
    ...
    [ 8633.839848] RSP: 0018:ffffb04d407f7d00 EFLAGS: 00010286
    [ 8633.839850] RAX: 0000000000000000 RBX: ffff9460b9897ee8 RCX: 00000000000000fe
    [ 8633.839851] RDX: 0000000000000000 RSI: 00000000ffffffff RDI: 0000000000000000
    [ 8633.839852] RBP: ffff946076049850 R08: 0000000059263a83 R09: ffff9460840e4000
    [ 8633.839853] R10: 0000000000000014 R11: 0000000000000000 R12: ffffb04d407f7dc0
    [ 8633.839854] R13: ffffffffa4ce3240 R14: 0000000000000000 R15: ffff9460b7681f60
    [ 8633.839857] FS:  00007fcac2e02700(0000) GS:ffff9460bdc00000(0000) knlGS:0000000000000000
    [ 8633.839858] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    [ 8633.839859] CR2: 00007f27beb77e28 CR3: 0000000077734000 CR4: 00000000000006f0
    [ 8633.839867] Call Trace:
    [ 8633.839871]  ip_route_output_key_hash_rcu+0x421/0x890
    [ 8633.839873]  ip_route_output_key_hash+0x5e/0x80
    [ 8633.839876]  ip_route_output_flow+0x1a/0x50
    [ 8633.839878]  __ip4_datagram_connect+0x154/0x310
    [ 8633.839880]  ip4_datagram_connect+0x28/0x40
    [ 8633.839882]  __sys_connect+0xd6/0x100
    ...

The WARN_ON is triggered in fib_select_default which is invoked when
there are multiple default routes. Update the function to use
fib_info_nhc and convert the nexthop checks to use fib_nh_common.

Add test case that covers the affected code path.

[0] https://github.com/FRRouting/frr/issues/6089

Fixes: 493ced1ac4 ("ipv4: Allow routes to use nexthop objects")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-04-29 16:33:07 +02:00

..

accounting

tools/accounting/getdelays.c: fix netlink attribute length

2020-04-13 10:48:08 +02:00

arch

x86/decoder: Add TEST opcode to Group3-2

2020-02-24 08:36:55 +01:00

bpf

bpf: Print error message for bpftool cgroup show

2020-02-24 08:36:40 +01:00

build

tools build: Add capability-related feature detection

2019-08-12 17:14:14 -03:00

cgroup

iocost_monitor: Report debt

2019-09-10 12:31:39 -06:00

debugging

…

firewire

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156

2019-05-30 11:26:35 -07:00

firmware

Merge tag 'driver-core-5.3-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core

2019-07-12 12:24:03 -07:00

gpio

tools: gpio: Fix out-of-tree build regression

2020-04-17 10:50:17 +02:00

hv

Merge tag 'hyperv-next-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux

2019-09-24 12:36:31 -07:00

iio

tools: iio: add .gitignore

2019-08-18 20:45:57 +01:00

include

tools lib: Fix builds when glibc contains strlcpy()

2020-02-05 21:22:40 +00:00

io_uring

tools/io_uring: sync with liburing

2019-05-23 10:25:26 -06:00

kvm/kvm_stat

tools/kvm_stat: Fix kvm_exit filter name

2020-02-11 04:35:36 -08:00

laptop

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 505

2019-06-19 17:11:22 +02:00

leds

leds: core: Add support for composing LED class device names

2019-07-25 20:07:52 +02:00

lib

libbpf: Fix readelf output parsing on powerpc with recent binutils

2020-04-29 16:33:04 +02:00

memory-model

tools/memory-model: Fix data race detection for unordered store and load

2019-12-31 16:43:40 +01:00

nfsd

…

objtool

objtool: Fix switch table detection in .text.unlikely

2020-04-23 10:36:16 +02:00

pci

tools: PCI: Fix fd leakage

2020-01-17 19:48:54 +01:00

pcmcia

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 247

2019-06-19 17:09:08 +02:00

perf

perf report: Fix no branch type statistics report issue

2020-04-21 09:04:52 +02:00

power

tools/power turbostat: Fix 32-bit capabilities warning

2020-04-08 09:08:39 +02:00

scripts

tools: Let O= makes handle a relative path with -C option

2020-04-01 11:02:00 +02:00

spi

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 178

2019-05-30 11:29:19 -07:00

testing

ipv4: Update fib_select_default to handle nexthop objects

2020-04-29 16:33:07 +02:00

thermal/tmon

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 89

2019-05-24 17:37:52 +02:00

time

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282

2019-06-05 17:36:37 +02:00

usb

usbip: Fix unsafe unaligned pointer usage

2020-02-24 08:36:44 +01:00

virtio

tools/virtio: xen stub

2019-10-13 09:38:27 -04:00

vm

tools/vm/slabinfo: add sorting info to help menu

2019-07-12 11:05:46 -07:00

wmi

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19 17:09:55 +02:00

Makefile

tools: Keep list of tools in alphabetical order

2019-08-14 10:59:59 -03:00