linux

iv/linux

History

Sebastian Andrzej Siewior d5c7652eb1 hsr: Disable netpoll.

The hsr device is a software device. Its
net_device_ops::ndo_start_xmit() routine will process the packet and
then pass the resulting skb to dev_queue_xmit().
During processing, hsr acquires a lock with spin_lock_bh()
(hsr_add_node()) which needs to be promoted to the _irq() suffix in
order to avoid a potential deadlock.
Then there are the warnings in dev_queue_xmit() (due to
local_bh_disable() with disabled interrupts) left.

Instead trying to address those (there is qdisc and…) for netpoll sake,
just disable netpoll on hsr.

Disable netpoll on hsr and replace the _irqsave() locking with _bh().

Fixes: f421436a591d3 ("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

2022-12-01 20:26:21 -08:00

hsr_debugfs.c

Revert "net: hsr: use hlist_head instead of list_head for mac addresses"

2022-12-01 20:26:20 -08:00

hsr_device.c

hsr: Disable netpoll.

2022-12-01 20:26:21 -08:00

hsr_device.h

net: hsr: add offloading support

2021-02-11 13:24:44 -08:00

hsr_forward.c

hsr: Disable netpoll.