Arnd Bergmann 84bf6b64a1 ftruncate: pass a signed offset
commit 4b8e88e563b5f666446d002ad0dc1e6e8e7102b0 upstream.

The old ftruncate() syscall, using the 32-bit off_t misses a sign
extension when called in compat mode on 64-bit architectures.  As a
result, passing a negative length accidentally succeeds in truncating
to file size between 2GiB and 4GiB.

Changing the type of the compat syscall to the signed compat_off_t
changes the behavior so it instead returns -EINVAL.

The native entry point, the truncate() syscall and the corresponding
loff_t based variants are all correct already and do not suffer
from this mistake.

Fixes: 3f6d078d4acc ("fix compat truncate/ftruncate")
Reviewed-by: Christian Brauner <brauner@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-07-05 09:12:55 +02:00
..
2021-09-18 13:40:15 +02:00
2024-04-13 12:58:19 +02:00
2024-02-23 08:42:14 +01:00
2024-03-01 13:16:43 +01:00
2023-09-23 11:01:09 +02:00
2024-06-21 14:52:47 +02:00
2022-06-09 10:21:16 +02:00
2024-06-21 14:52:47 +02:00
2023-12-08 08:46:15 +01:00
2024-06-21 14:53:37 +02:00
2023-01-04 11:39:23 +01:00
2024-06-21 14:52:59 +02:00
2024-07-05 09:12:55 +02:00
2023-01-14 10:16:27 +01:00