Jianguo Wu
d62df86c17
seg6: fix parameter passing when calling NF_HOOK() in End.DX4 and End.DX6 behaviors ...
[ Upstream commit 9a3bc8d16e0aacd65c31aaf23a2bced3288a7779 ]
input_action_end_dx4() and input_action_end_dx6() are called NF_HOOK() for
PREROUTING hook, in PREROUTING hook, we should passing a valid indev,
and a NULL outdev to NF_HOOK(), otherwise may trigger a NULL pointer
dereference, as below:
[74830.647293] BUG: kernel NULL pointer dereference, address: 0000000000000090
[74830.655633] #PF: supervisor read access in kernel mode
[74830.657888] #PF: error_code(0x0000) - not-present page
[74830.659500] PGD 0 P4D 0
[74830.660450] Oops: 0000 [#1 ] PREEMPT SMP PTI
...
[74830.664953] Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
[74830.666569] RIP: 0010:rpfilter_mt+0x44/0x15e [ipt_rpfilter]
...
[74830.689725] Call Trace:
[74830.690402] <IRQ>
[74830.690953] ? show_trace_log_lvl+0x1c4/0x2df
[74830.692020] ? show_trace_log_lvl+0x1c4/0x2df
[74830.693095] ? ipt_do_table+0x286/0x710 [ip_tables]
[74830.694275] ? __die_body.cold+0x8/0xd
[74830.695205] ? page_fault_oops+0xac/0x140
[74830.696244] ? exc_page_fault+0x62/0x150
[74830.697225] ? asm_exc_page_fault+0x22/0x30
[74830.698344] ? rpfilter_mt+0x44/0x15e [ipt_rpfilter]
[74830.699540] ipt_do_table+0x286/0x710 [ip_tables]
[74830.700758] ? ip6_route_input+0x19d/0x240
[74830.701752] nf_hook_slow+0x3f/0xb0
[74830.702678] input_action_end_dx4+0x19b/0x1e0
[74830.703735] ? input_action_end_t+0xe0/0xe0
[74830.704734] seg6_local_input_core+0x2d/0x60
[74830.705782] lwtunnel_input+0x5b/0xb0
[74830.706690] __netif_receive_skb_one_core+0x63/0xa0
[74830.707825] process_backlog+0x99/0x140
[74830.709538] __napi_poll+0x2c/0x160
[74830.710673] net_rx_action+0x296/0x350
[74830.711860] __do_softirq+0xcb/0x2ac
[74830.713049] do_softirq+0x63/0x90
input_action_end_dx4() passing a NULL indev to NF_HOOK(), and finally
trigger a NULL dereference in rpfilter_mt()->rpfilter_is_loopback():
static bool
rpfilter_is_loopback(const struct sk_buff *skb,
const struct net_device *in)
{
// in is NULL
return skb->pkt_type == PACKET_LOOPBACK ||
in->flags & IFF_LOOPBACK;
}
Fixes: 7a3f5b0de364 ("netfilter: add netfilter hooks to SRv6 data plane")
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-27 13:49:08 +02:00
2024-06-16 13:47:41 +02:00
2024-05-17 12:02:07 +02:00
2023-12-20 17:01:50 +01:00
2023-12-20 17:01:48 +01:00
2024-06-21 14:38:14 +02:00
2024-06-27 13:49:01 +02:00
2024-06-21 14:38:34 +02:00
2024-06-21 14:38:16 +02:00
2023-05-31 13:06:57 +02:00
2024-06-21 14:38:36 +02:00
2023-06-24 15:50:13 -07:00
2024-02-23 09:25:17 +01:00
2024-03-01 13:34:56 +01:00
2024-06-27 13:49:06 +02:00
2023-08-01 21:07:46 -07:00
2023-11-20 11:59:35 +01:00
2024-03-26 18:20:11 -04:00
2024-01-25 15:35:41 -08:00
2023-08-09 13:08:09 -07:00
2024-05-02 16:32:46 +02:00
2024-06-21 14:38:20 +02:00
2024-02-23 09:24:50 +01:00
2024-05-17 12:02:24 +02:00
2023-08-29 17:39:15 -07:00
2024-01-01 12:42:30 +00:00
2024-06-27 13:49:06 +02:00
2024-06-27 13:49:08 +02:00
2024-03-26 18:19:12 -04:00
2024-03-26 18:19:40 -04:00
2023-08-18 12:44:56 -07:00
2024-05-17 12:02:02 +02:00
2024-02-05 20:14:36 +00:00
2024-06-21 14:38:13 +02:00
2024-04-03 15:28:27 +02:00
2024-03-26 18:19:34 -04:00
2024-04-13 13:07:41 +02:00
2024-06-21 14:38:38 +02:00
2024-06-21 14:38:14 +02:00
2024-06-27 13:49:08 +02:00
2024-01-25 15:35:14 -08:00
2024-03-06 14:48:34 +00:00
2024-06-27 13:49:06 +02:00
2024-06-12 11:12:51 +02:00
2024-05-17 12:02:02 +02:00
2024-06-12 11:12:49 +02:00
2024-06-27 13:49:01 +02:00
2024-05-17 12:02:22 +02:00
2023-12-13 18:45:10 +01:00
2024-06-12 11:12:12 +02:00
2024-04-10 16:35:49 +02:00
2024-01-01 12:42:41 +00:00
2024-01-01 12:42:31 +00:00
2024-05-17 12:02:23 +02:00
2024-06-27 13:49:07 +02:00
2024-01-25 15:35:30 -08:00
2024-06-21 14:38:16 +02:00
2024-06-21 14:38:28 +02:00
2024-03-01 13:35:06 +01:00
2024-06-27 13:49:07 +02:00
2024-06-12 11:12:50 +02:00
2024-06-21 14:38:36 +02:00
2024-04-10 16:35:50 +02:00
2024-06-21 14:38:12 +02:00
2024-03-26 18:19:41 -04:00
2024-04-17 11:19:28 +02:00
2024-06-16 13:47:44 +02:00
2023-07-19 10:07:27 -07:00
2024-01-10 17:16:51 +01:00
2023-08-15 15:26:17 -07:00
d62df86c17