iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/md
History
Ignat Korchagin d68b29584c dm crypt: use GFP_ATOMIC when allocating crypto requests from softirq 
Commit 39d42fa96ba1 ("dm crypt: add flags to optionally bypass kcryptd
workqueues") made it possible for some code paths in dm-crypt to be
executed in softirq context, when the underlying driver processes IO
requests in interrupt/softirq context.

In this case sometimes when allocating a new crypto request we may get
a stacktrace like below:

[  210.103008][    C0] BUG: sleeping function called from invalid context at mm/mempool.c:381
[  210.104746][    C0] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 2602, name: fio
[  210.106599][    C0] CPU: 0 PID: 2602 Comm: fio Tainted: G        W         5.10.0+ #50
[  210.108331][    C0] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015
[  210.110212][    C0] Call Trace:
[  210.110921][    C0]  <IRQ>
[  210.111527][    C0]  dump_stack+0x7d/0xa3
[  210.112411][    C0]  ___might_sleep.cold+0x122/0x151
[  210.113527][    C0]  mempool_alloc+0x16b/0x2f0
[  210.114524][    C0]  ? __queue_work+0x515/0xde0
[  210.115553][    C0]  ? mempool_resize+0x700/0x700
[  210.116586][    C0]  ? crypt_endio+0x91/0x180
[  210.117479][    C0]  ? blk_update_request+0x757/0x1150
[  210.118513][    C0]  ? blk_mq_end_request+0x4b/0x480
[  210.119572][    C0]  ? blk_done_softirq+0x21d/0x340
[  210.120628][    C0]  ? __do_softirq+0x190/0x611
[  210.121626][    C0]  crypt_convert+0x29f9/0x4c00
[  210.122668][    C0]  ? _raw_spin_lock_irqsave+0x87/0xe0
[  210.123824][    C0]  ? kasan_set_track+0x1c/0x30
[  210.124858][    C0]  ? crypt_iv_tcw_ctr+0x4a0/0x4a0
[  210.125930][    C0]  ? kmem_cache_free+0x104/0x470
[  210.126973][    C0]  ? crypt_endio+0x91/0x180
[  210.127947][    C0]  kcryptd_crypt_read_convert+0x30e/0x420
[  210.129165][    C0]  blk_update_request+0x757/0x1150
[  210.130231][    C0]  blk_mq_end_request+0x4b/0x480
[  210.131294][    C0]  blk_done_softirq+0x21d/0x340
[  210.132332][    C0]  ? _raw_spin_lock+0x81/0xd0
[  210.133289][    C0]  ? blk_mq_stop_hw_queue+0x30/0x30
[  210.134399][    C0]  ? _raw_read_lock_irq+0x40/0x40
[  210.135458][    C0]  __do_softirq+0x190/0x611
[  210.136409][    C0]  ? handle_edge_irq+0x221/0xb60
[  210.137447][    C0]  asm_call_irq_on_stack+0x12/0x20
[  210.138507][    C0]  </IRQ>
[  210.139118][    C0]  do_softirq_own_stack+0x37/0x40
[  210.140191][    C0]  irq_exit_rcu+0x110/0x1b0
[  210.141151][    C0]  common_interrupt+0x74/0x120
[  210.142171][    C0]  asm_common_interrupt+0x1e/0x40

Fix this by allocating crypto requests with GFP_ATOMIC mask in
interrupt context.

Fixes: 39d42fa96ba1 ("dm crypt: add flags to optionally bypass kcryptd workqueues")
Cc: stable@vger.kernel.org # v5.9+
Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
Acked-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
2021-01-04 15:02:33 -05:00
..
bcache
md/bcache: convert comma to semicolon
2020-12-23 09:25:15 -07:00
persistent-data
dm thin metadata: Remove unused local variable when create thin and snap
2020-09-29 16:33:11 -04:00
dm-bio-prison-v1.c
dm bio prison: replace spin_lock_irqsave with spin_lock_irq
2019-11-05 14:53:03 -05:00
dm-bio-prison-v1.h
…
dm-bio-prison-v2.c
dm bio prison v2: use true/false for bool variable
2020-01-07 12:07:08 -05:00
dm-bio-prison-v2.h
…
dm-bio-record.h
dm bio record: save/restore bi_end_io and bi_integrity
2020-03-03 10:02:46 -05:00
dm-bufio.c
dm bufio: do buffer cleanup from a workqueue
2020-07-20 11:17:43 -04:00
dm-builtin.c
…
dm-cache-background-tracker.c
…
dm-cache-background-tracker.h
…
dm-cache-block-types.h
…
dm-cache-metadata.c
dm cache metadata: Avoid returning cmd->bm wild pointer on error
2020-09-02 13:38:24 -04:00
dm-cache-metadata.h
…
dm-cache-policy-internal.h
…
dm-cache-policy-smq.c
…
dm-cache-policy.c
…
dm-cache-policy.h
…
dm-cache-target.c
dm cache: simplify the return expression of load_mapping()
2020-12-22 09:54:48 -05:00
dm-clone-metadata.c
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-metadata.h
dm clone metadata: Fix return type of dm_clone_nr_of_hydrated_regions()
2020-03-27 14:42:51 -04:00
dm-clone-target.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-core.h
dm: remove the block_device reference in struct mapped_device
2020-12-01 14:53:39 -07:00
dm-crypt.c
dm crypt: use GFP_ATOMIC when allocating crypto requests from softirq
2021-01-04 15:02:33 -05:00
dm-delay.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-dust.c
dm dust: add interface to list all badblocks
2020-07-20 11:17:41 -04:00
dm-ebs-target.c
dm ebs: avoid double unlikely() notation when using IS_ERR()
2020-12-21 13:59:37 -05:00
dm-era-target.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-exception-store.c
…
dm-exception-store.h
- Improve DM snapshot target's scalability by using finer grained
2019-05-16 15:55:48 -07:00
dm-flakey.c
block: rework zone reporting
2019-11-12 19:12:07 -07:00
dm-init.c
dm init: Set file local variable static
2020-08-04 15:51:28 -04:00
dm-integrity.c
dm integrity: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
2020-11-17 10:45:06 -05:00
dm-io.c
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
dm-ioctl.c
dm ioctl: fix error return code in target_message
2020-12-04 18:04:36 -05:00
dm-kcopyd.c
dm kcopyd: always complete failed jobs
2019-08-15 15:57:39 -04:00
dm-linear.c
dm: add support for REQ_NOWAIT and enable it for linear target
2020-09-25 08:20:03 -06:00
dm-log-userspace-base.c
…
dm-log-userspace-transfer.c
…
dm-log-userspace-transfer.h
…
dm-log-writes.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-log.c
…
dm-mpath.c
dm: use dm_table_get_device_name() where appropriate in targets
2020-09-29 16:33:08 -04:00
dm-mpath.h
…
dm-path-selector.c
…
dm-path-selector.h
dm mpath: pass IO start time to path selector
2020-05-15 10:29:36 -04:00
dm-ps-historical-service-time.c
dm: rename multipath path selector source files to have "dm-ps" prefix
2020-12-04 18:04:35 -05:00
dm-ps-io-affinity.c
dm: rename multipath path selector source files to have "dm-ps" prefix
2020-12-04 18:04:35 -05:00
dm-ps-queue-length.c
dm: rename multipath path selector source files to have "dm-ps" prefix
2020-12-04 18:04:35 -05:00
dm-ps-round-robin.c
dm: rename multipath path selector source files to have "dm-ps" prefix
2020-12-04 18:04:35 -05:00
dm-ps-service-time.c
dm: rename multipath path selector source files to have "dm-ps" prefix
2020-12-04 18:04:35 -05:00
dm-raid1.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-raid.c
dm raid: fix discard limits for raid1
2021-01-04 15:02:30 -05:00
dm-region-hash.c
…
dm-rq.c
block: remove the request_queue to argument request based tracepoints
2020-12-04 09:42:00 -07:00
dm-rq.h
…
dm-snap-persistent.c
dm snap persistent: simplify area_io()
2020-09-29 16:33:12 -04:00
dm-snap-transient.c
…
dm-snap.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
dm-stats.c
dm: replace zero-length array with flexible-array
2020-05-20 17:09:44 -04:00
dm-stats.h
…
dm-stripe.c
dm: add support for REQ_NOWAIT to various targets
2020-12-04 18:04:35 -05:00
dm-switch.c
dm: add support for REQ_NOWAIT to various targets
2020-12-04 18:04:35 -05:00
dm-sysfs.c
…
dm-table.c
for-5.11/block-2020-12-14
2020-12-16 12:57:51 -08:00
dm-target.c
dm mpath: fix missing call of path selector type->end_io
2019-04-25 15:38:52 -04:00
dm-thin-metadata.c
dm thin metadata: Remove unused local variable when create thin and snap
2020-09-29 16:33:11 -04:00
dm-thin-metadata.h
dm thin metadata: Add support for a pre-commit callback
2019-12-05 17:05:24 -05:00
dm-thin.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
dm-uevent.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-uevent.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm-unstripe.c
dm: add support for REQ_NOWAIT to various targets
2020-12-04 18:04:35 -05:00
dm-verity-fec.c
dm verity fec: fix hash block number in verity_fec_decode
2020-04-16 16:16:38 -04:00
dm-verity-fec.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dm-verity-target.c
dm verity: skip verity work if I/O error when system is shutting down
2020-12-21 13:57:25 -05:00
dm-verity-verify-sig.c
dm verity: Add support for signature verification with 2nd keyring
2020-12-04 18:04:35 -05:00
dm-verity-verify-sig.h
dm verity: Fix compilation warning
2020-08-04 15:48:13 -04:00
dm-verity.h
dm verity: add "panic_on_corruption" error handling mode
2020-07-13 11:47:33 -04:00
dm-writecache.c
dm writecache: remove BUG() and fail gracefully instead
2020-12-01 15:43:39 -05:00
dm-zero.c
dm: add support for REQ_NOWAIT to various targets
2020-12-04 18:04:35 -05:00
dm-zoned-metadata.c
dm zoned: Fix zone reclaim trigger
2020-07-08 12:21:53 -04:00
dm-zoned-reclaim.c
dm zoned: Fix zone reclaim trigger
2020-07-08 12:21:53 -04:00
dm-zoned-target.c
for-5.9/block-20200802
2020-08-03 11:57:03 -07:00
dm-zoned.h
dm zoned: select reclaim zone based on device index
2020-06-05 14:59:53 -04:00
dm.c
- Add DM verity support for signature verification with 2nd keyring.
2020-12-22 13:27:21 -08:00
dm.h
dm table: make 'struct dm_table' definition accessible to all of DM core
2020-09-29 16:33:07 -04:00
Kconfig
dm zoned: select CONFIG_CRC32
2021-01-04 15:02:32 -05:00
Makefile
dm: rename multipath path selector source files to have "dm-ps" prefix
2020-12-04 18:04:35 -05:00
md-autodetect.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
md-bitmap.c
md/bitmap: fix memory leak of temporary bitmap
2020-10-08 22:37:39 -07:00
md-bitmap.h
…
md-cluster.c
for-5.11/drivers-2020-12-14
2020-12-16 13:09:32 -08:00
md-cluster.h
…
md-faulty.c
block: rename generic_make_request to submit_bio_noacct
2020-07-01 07:27:24 -06:00
md-linear.c
block: remove the request_queue argument to the block_bio_remap tracepoint
2020-12-04 09:42:00 -07:00
md-linear.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
md-multipath.c
writeback: remove bdi->congested_fn
2020-07-08 17:20:46 -06:00
md-multipath.h
…
md.c
for-5.11/drivers-2020-12-14
2020-12-16 13:09:32 -08:00
md.h
for-5.11/drivers-2020-12-14
2020-12-16 13:09:32 -08:00
raid0.c
for-5.11/block-2020-12-14
2020-12-16 12:57:51 -08:00
raid0.h
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-09-13 13:10:05 -07:00
raid1-10.c
md: raid1-10: Unify r{1,10}bio_pool_free
2019-06-15 01:37:35 -06:00
raid1.c
block: remove the request_queue argument to the block_bio_remap tracepoint
2020-12-04 09:42:00 -07:00
raid1.h
md/raid1: Replace zero-length array with flexible-array
2020-05-13 12:02:23 -07:00
raid5-cache.c
raid5-cache: hold spinlock instead of mutex in r5c_journal_mode_show
2020-08-02 23:03:52 -07:00
raid5-log.h
raid5: set write hint for PPL
2019-03-12 10:15:18 -07:00
raid5-ppl.c
md/raid456: convert macro STRIPE_* to RAID5_STRIPE_*
2020-07-21 17:18:12 -07:00
raid5.c
block: remove the request_queue argument to the block_bio_remap tracepoint
2020-12-04 09:42:00 -07:00
raid5.h
md/raid5: let multiple devices of stripe_head share page
2020-09-24 16:44:44 -07:00
raid10.c
for-5.11/drivers-2020-12-14
2020-12-16 13:09:32 -08:00
raid10.h
Revert "md/raid10: improve discard request for far layout"
2020-12-09 20:46:00 -08:00