724989b830
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
272 lines
6.9 KiB
C
272 lines
6.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Random Number Generator driver for the Keystone SOC
|
|
*
|
|
* Copyright (C) 2016 Texas Instruments Incorporated - https://www.ti.com
|
|
*
|
|
* Authors: Sandeep Nair
|
|
* Vitaly Andrianov
|
|
*/
|
|
|
|
#include <linux/hw_random.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/io.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/err.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/mfd/syscon.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/timekeeping.h>
|
|
|
|
#define SA_CMD_STATUS_OFS 0x8
|
|
|
|
/* TRNG enable control in SA System module*/
|
|
#define SA_CMD_STATUS_REG_TRNG_ENABLE BIT(3)
|
|
|
|
/* TRNG start control in TRNG module */
|
|
#define TRNG_CNTL_REG_TRNG_ENABLE BIT(10)
|
|
|
|
/* Data ready indicator in STATUS register */
|
|
#define TRNG_STATUS_REG_READY BIT(0)
|
|
|
|
/* Data ready clear control in INTACK register */
|
|
#define TRNG_INTACK_REG_READY BIT(0)
|
|
|
|
/*
|
|
* Number of samples taken to gather entropy during startup.
|
|
* If value is 0, the number of samples is 2^24 else
|
|
* equals value times 2^8.
|
|
*/
|
|
#define TRNG_DEF_STARTUP_CYCLES 0
|
|
#define TRNG_CNTL_REG_STARTUP_CYCLES_SHIFT 16
|
|
|
|
/*
|
|
* Minimum number of samples taken to regenerate entropy
|
|
* If value is 0, the number of samples is 2^24 else
|
|
* equals value times 2^6.
|
|
*/
|
|
#define TRNG_DEF_MIN_REFILL_CYCLES 1
|
|
#define TRNG_CFG_REG_MIN_REFILL_CYCLES_SHIFT 0
|
|
|
|
/*
|
|
* Maximum number of samples taken to regenerate entropy
|
|
* If value is 0, the number of samples is 2^24 else
|
|
* equals value times 2^8.
|
|
*/
|
|
#define TRNG_DEF_MAX_REFILL_CYCLES 0
|
|
#define TRNG_CFG_REG_MAX_REFILL_CYCLES_SHIFT 16
|
|
|
|
/* Number of CLK input cycles between samples */
|
|
#define TRNG_DEF_CLK_DIV_CYCLES 0
|
|
#define TRNG_CFG_REG_SAMPLE_DIV_SHIFT 8
|
|
|
|
/* Maximum retries to get rng data */
|
|
#define SA_MAX_RNG_DATA_RETRIES 5
|
|
/* Delay between retries (in usecs) */
|
|
#define SA_RNG_DATA_RETRY_DELAY 5
|
|
|
|
struct trng_regs {
|
|
u32 output_l;
|
|
u32 output_h;
|
|
u32 status;
|
|
u32 intmask;
|
|
u32 intack;
|
|
u32 control;
|
|
u32 config;
|
|
};
|
|
|
|
struct ks_sa_rng {
|
|
struct hwrng rng;
|
|
struct clk *clk;
|
|
struct regmap *regmap_cfg;
|
|
struct trng_regs __iomem *reg_rng;
|
|
u64 ready_ts;
|
|
unsigned int refill_delay_ns;
|
|
};
|
|
|
|
static unsigned int cycles_to_ns(unsigned long clk_rate, unsigned int cycles)
|
|
{
|
|
return DIV_ROUND_UP_ULL((TRNG_DEF_CLK_DIV_CYCLES + 1) * 1000000000ull *
|
|
cycles, clk_rate);
|
|
}
|
|
|
|
static unsigned int startup_delay_ns(unsigned long clk_rate)
|
|
{
|
|
if (!TRNG_DEF_STARTUP_CYCLES)
|
|
return cycles_to_ns(clk_rate, BIT(24));
|
|
return cycles_to_ns(clk_rate, 256 * TRNG_DEF_STARTUP_CYCLES);
|
|
}
|
|
|
|
static unsigned int refill_delay_ns(unsigned long clk_rate)
|
|
{
|
|
if (!TRNG_DEF_MAX_REFILL_CYCLES)
|
|
return cycles_to_ns(clk_rate, BIT(24));
|
|
return cycles_to_ns(clk_rate, 256 * TRNG_DEF_MAX_REFILL_CYCLES);
|
|
}
|
|
|
|
static int ks_sa_rng_init(struct hwrng *rng)
|
|
{
|
|
u32 value;
|
|
struct ks_sa_rng *ks_sa_rng = container_of(rng, struct ks_sa_rng, rng);
|
|
unsigned long clk_rate = clk_get_rate(ks_sa_rng->clk);
|
|
|
|
/* Enable RNG module */
|
|
regmap_write_bits(ks_sa_rng->regmap_cfg, SA_CMD_STATUS_OFS,
|
|
SA_CMD_STATUS_REG_TRNG_ENABLE,
|
|
SA_CMD_STATUS_REG_TRNG_ENABLE);
|
|
|
|
/* Configure RNG module */
|
|
writel(0, &ks_sa_rng->reg_rng->control);
|
|
value = TRNG_DEF_STARTUP_CYCLES << TRNG_CNTL_REG_STARTUP_CYCLES_SHIFT;
|
|
writel(value, &ks_sa_rng->reg_rng->control);
|
|
|
|
value = (TRNG_DEF_MIN_REFILL_CYCLES <<
|
|
TRNG_CFG_REG_MIN_REFILL_CYCLES_SHIFT) |
|
|
(TRNG_DEF_MAX_REFILL_CYCLES <<
|
|
TRNG_CFG_REG_MAX_REFILL_CYCLES_SHIFT) |
|
|
(TRNG_DEF_CLK_DIV_CYCLES <<
|
|
TRNG_CFG_REG_SAMPLE_DIV_SHIFT);
|
|
|
|
writel(value, &ks_sa_rng->reg_rng->config);
|
|
|
|
/* Disable all interrupts from TRNG */
|
|
writel(0, &ks_sa_rng->reg_rng->intmask);
|
|
|
|
/* Enable RNG */
|
|
value = readl(&ks_sa_rng->reg_rng->control);
|
|
value |= TRNG_CNTL_REG_TRNG_ENABLE;
|
|
writel(value, &ks_sa_rng->reg_rng->control);
|
|
|
|
ks_sa_rng->refill_delay_ns = refill_delay_ns(clk_rate);
|
|
ks_sa_rng->ready_ts = ktime_get_ns() +
|
|
startup_delay_ns(clk_rate);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void ks_sa_rng_cleanup(struct hwrng *rng)
|
|
{
|
|
struct ks_sa_rng *ks_sa_rng = container_of(rng, struct ks_sa_rng, rng);
|
|
|
|
/* Disable RNG */
|
|
writel(0, &ks_sa_rng->reg_rng->control);
|
|
regmap_write_bits(ks_sa_rng->regmap_cfg, SA_CMD_STATUS_OFS,
|
|
SA_CMD_STATUS_REG_TRNG_ENABLE, 0);
|
|
}
|
|
|
|
static int ks_sa_rng_data_read(struct hwrng *rng, u32 *data)
|
|
{
|
|
struct ks_sa_rng *ks_sa_rng = container_of(rng, struct ks_sa_rng, rng);
|
|
|
|
/* Read random data */
|
|
data[0] = readl(&ks_sa_rng->reg_rng->output_l);
|
|
data[1] = readl(&ks_sa_rng->reg_rng->output_h);
|
|
|
|
writel(TRNG_INTACK_REG_READY, &ks_sa_rng->reg_rng->intack);
|
|
ks_sa_rng->ready_ts = ktime_get_ns() + ks_sa_rng->refill_delay_ns;
|
|
|
|
return sizeof(u32) * 2;
|
|
}
|
|
|
|
static int ks_sa_rng_data_present(struct hwrng *rng, int wait)
|
|
{
|
|
struct ks_sa_rng *ks_sa_rng = container_of(rng, struct ks_sa_rng, rng);
|
|
u64 now = ktime_get_ns();
|
|
|
|
u32 ready;
|
|
int j;
|
|
|
|
if (wait && now < ks_sa_rng->ready_ts) {
|
|
/* Max delay expected here is 81920000 ns */
|
|
unsigned long min_delay =
|
|
DIV_ROUND_UP((u32)(ks_sa_rng->ready_ts - now), 1000);
|
|
|
|
usleep_range(min_delay, min_delay + SA_RNG_DATA_RETRY_DELAY);
|
|
}
|
|
|
|
for (j = 0; j < SA_MAX_RNG_DATA_RETRIES; j++) {
|
|
ready = readl(&ks_sa_rng->reg_rng->status);
|
|
ready &= TRNG_STATUS_REG_READY;
|
|
|
|
if (ready || !wait)
|
|
break;
|
|
|
|
udelay(SA_RNG_DATA_RETRY_DELAY);
|
|
}
|
|
|
|
return ready;
|
|
}
|
|
|
|
static int ks_sa_rng_probe(struct platform_device *pdev)
|
|
{
|
|
struct ks_sa_rng *ks_sa_rng;
|
|
struct device *dev = &pdev->dev;
|
|
int ret;
|
|
|
|
ks_sa_rng = devm_kzalloc(dev, sizeof(*ks_sa_rng), GFP_KERNEL);
|
|
if (!ks_sa_rng)
|
|
return -ENOMEM;
|
|
|
|
ks_sa_rng->rng = (struct hwrng) {
|
|
.name = "ks_sa_hwrng",
|
|
.init = ks_sa_rng_init,
|
|
.data_read = ks_sa_rng_data_read,
|
|
.data_present = ks_sa_rng_data_present,
|
|
.cleanup = ks_sa_rng_cleanup,
|
|
};
|
|
|
|
ks_sa_rng->reg_rng = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(ks_sa_rng->reg_rng))
|
|
return PTR_ERR(ks_sa_rng->reg_rng);
|
|
|
|
ks_sa_rng->regmap_cfg =
|
|
syscon_regmap_lookup_by_phandle(dev->of_node,
|
|
"ti,syscon-sa-cfg");
|
|
|
|
if (IS_ERR(ks_sa_rng->regmap_cfg))
|
|
return dev_err_probe(dev, -EINVAL, "syscon_node_to_regmap failed\n");
|
|
|
|
pm_runtime_enable(dev);
|
|
ret = pm_runtime_resume_and_get(dev);
|
|
if (ret < 0) {
|
|
pm_runtime_disable(dev);
|
|
return dev_err_probe(dev, ret, "Failed to enable SA power-domain\n");
|
|
}
|
|
|
|
return devm_hwrng_register(&pdev->dev, &ks_sa_rng->rng);
|
|
}
|
|
|
|
static void ks_sa_rng_remove(struct platform_device *pdev)
|
|
{
|
|
pm_runtime_put_sync(&pdev->dev);
|
|
pm_runtime_disable(&pdev->dev);
|
|
}
|
|
|
|
static const struct of_device_id ks_sa_rng_dt_match[] = {
|
|
{
|
|
.compatible = "ti,keystone-rng",
|
|
},
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ks_sa_rng_dt_match);
|
|
|
|
static struct platform_driver ks_sa_rng_driver = {
|
|
.driver = {
|
|
.name = "ks-sa-rng",
|
|
.of_match_table = ks_sa_rng_dt_match,
|
|
},
|
|
.probe = ks_sa_rng_probe,
|
|
.remove_new = ks_sa_rng_remove,
|
|
};
|
|
|
|
module_platform_driver(ks_sa_rng_driver);
|
|
|
|
MODULE_DESCRIPTION("Keystone NETCP SA H/W Random Number Generator driver");
|
|
MODULE_AUTHOR("Vitaly Andrianov <vitalya@ti.com>");
|
|
MODULE_LICENSE("GPL");
|