15319a4e8e
As &card->tx_queue_lock is acquired under softirq context along the
following call chain from solos_bh(), other acquisition of the same
lock inside process context should disable at least bh to avoid double
lock.
<deadlock #2>
pclose()
--> spin_lock(&card->tx_queue_lock)
<interrupt>
--> solos_bh()
--> fpga_tx()
--> spin_lock(&card->tx_queue_lock)
This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.
To prevent the potential deadlock, the patch uses spin_lock_bh()
on &card->tx_queue_lock under process context code consistently to
prevent the possible deadlock scenario.
Fixes:
|
||
---|---|---|
.. | ||
.gitignore | ||
adummy.c | ||
atmtcp.c | ||
eni.c | ||
eni.h | ||
fore200e.c | ||
fore200e.h | ||
he.c | ||
he.h | ||
idt77105.c | ||
idt77105.h | ||
idt77252_tables.h | ||
idt77252.c | ||
idt77252.h | ||
iphase.c | ||
iphase.h | ||
Kconfig | ||
lanai.c | ||
Makefile | ||
midway.h | ||
nicstar.c | ||
nicstar.h | ||
nicstarmac.c | ||
nicstarmac.copyright | ||
solos-attrlist.c | ||
solos-pci.c | ||
suni.c | ||
suni.h | ||
tonga.h | ||
zeprom.h |