b6a7828502
The summary of the changes for this pull requests is: * Song Liu's new struct module_memory replacement * Nick Alcock's MODULE_LICENSE() removal for non-modules * My cleanups and enhancements to reduce the areas where we vmalloc module memory for duplicates, and the respective debug code which proves the remaining vmalloc pressure comes from userspace. Most of the changes have been in linux-next for quite some time except the minor fixes I made to check if a module was already loaded prior to allocating the final module memory with vmalloc and the respective debug code it introduces to help clarify the issue. Although the functional change is small it is rather safe as it can only *help* reduce vmalloc space for duplicates and is confirmed to fix a bootup issue with over 400 CPUs with KASAN enabled. I don't expect stable kernels to pick up that fix as the cleanups would have also had to have been picked up. Folks on larger CPU systems with modules will want to just upgrade if vmalloc space has been an issue on bootup. Given the size of this request, here's some more elaborate details on this pull request. The functional change change in this pull request is the very first patch from Song Liu which replaces the struct module_layout with a new struct module memory. The old data structure tried to put together all types of supported module memory types in one data structure, the new one abstracts the differences in memory types in a module to allow each one to provide their own set of details. This paves the way in the future so we can deal with them in a cleaner way. If you look at changes they also provide a nice cleanup of how we handle these different memory areas in a module. This change has been in linux-next since before the merge window opened for v6.3 so to provide more than a full kernel cycle of testing. It's a good thing as quite a bit of fixes have been found for it. Jason Baron then made dynamic debug a first class citizen module user by using module notifier callbacks to allocate / remove module specific dynamic debug information. Nick Alcock has done quite a bit of work cross-tree to remove module license tags from things which cannot possibly be module at my request so to: a) help him with his longer term tooling goals which require a deterministic evaluation if a piece a symbol code could ever be part of a module or not. But quite recently it is has been made clear that tooling is not the only one that would benefit. Disambiguating symbols also helps efforts such as live patching, kprobes and BPF, but for other reasons and R&D on this area is active with no clear solution in sight. b) help us inch closer to the now generally accepted long term goal of automating all the MODULE_LICENSE() tags from SPDX license tags In so far as a) is concerned, although module license tags are a no-op for non-modules, tools which would want create a mapping of possible modules can only rely on the module license tag after the commit8b41fc4454
("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"). Nick has been working on this *for years* and AFAICT I was the only one to suggest two alternatives to this approach for tooling. The complexity in one of my suggested approaches lies in that we'd need a possible-obj-m and a could-be-module which would check if the object being built is part of any kconfig build which could ever lead to it being part of a module, and if so define a new define -DPOSSIBLE_MODULE [0]. A more obvious yet theoretical approach I've suggested would be to have a tristate in kconfig imply the same new -DPOSSIBLE_MODULE as well but that means getting kconfig symbol names mapping to modules always, and I don't think that's the case today. I am not aware of Nick or anyone exploring either of these options. Quite recently Josh Poimboeuf has pointed out that live patching, kprobes and BPF would benefit from resolving some part of the disambiguation as well but for other reasons. The function granularity KASLR (fgkaslr) patches were mentioned but Joe Lawrence has clarified this effort has been dropped with no clear solution in sight [1]. In the meantime removing module license tags from code which could never be modules is welcomed for both objectives mentioned above. Some developers have also welcomed these changes as it has helped clarify when a module was never possible and they forgot to clean this up, and so you'll see quite a bit of Nick's patches in other pull requests for this merge window. I just picked up the stragglers after rc3. LWN has good coverage on the motivation behind this work [2] and the typical cross-tree issues he ran into along the way. The only concrete blocker issue he ran into was that we should not remove the MODULE_LICENSE() tags from files which have no SPDX tags yet, even if they can never be modules. Nick ended up giving up on his efforts due to having to do this vetting and backlash he ran into from folks who really did *not understand* the core of the issue nor were providing any alternative / guidance. I've gone through his changes and dropped the patches which dropped the module license tags where an SPDX license tag was missing, it only consisted of 11 drivers. To see if a pull request deals with a file which lacks SPDX tags you can just use: ./scripts/spdxcheck.py -f \ $(git diff --name-only commid-id | xargs echo) You'll see a core module file in this pull request for the above, but that's not related to his changes. WE just need to add the SPDX license tag for the kernel/module/kmod.c file in the future but it demonstrates the effectiveness of the script. Most of Nick's changes were spread out through different trees, and I just picked up the slack after rc3 for the last kernel was out. Those changes have been in linux-next for over two weeks. The cleanups, debug code I added and final fix I added for modules were motivated by David Hildenbrand's report of boot failing on a systems with over 400 CPUs when KASAN was enabled due to running out of virtual memory space. Although the functional change only consists of 3 lines in the patch "module: avoid allocation if module is already present and ready", proving that this was the best we can do on the modules side took quite a bit of effort and new debug code. The initial cleanups I did on the modules side of things has been in linux-next since around rc3 of the last kernel, the actual final fix for and debug code however have only been in linux-next for about a week or so but I think it is worth getting that code in for this merge window as it does help fix / prove / evaluate the issues reported with larger number of CPUs. Userspace is not yet fixed as it is taking a bit of time for folks to understand the crux of the issue and find a proper resolution. Worst come to worst, I have a kludge-of-concept [3] of how to make kernel_read*() calls for modules unique / converge them, but I'm currently inclined to just see if userspace can fix this instead. [0] https://lore.kernel.org/all/Y/kXDqW+7d71C4wz@bombadil.infradead.org/ [1] https://lkml.kernel.org/r/025f2151-ce7c-5630-9b90-98742c97ac65@redhat.com [2] https://lwn.net/Articles/927569/ [3] https://lkml.kernel.org/r/20230414052840.1994456-3-mcgrof@kernel.org -----BEGIN PGP SIGNATURE----- iQJGBAABCgAwFiEENnNq2KuOejlQLZofziMdCjCSiKcFAmRG4m0SHG1jZ3JvZkBr ZXJuZWwub3JnAAoJEM4jHQowkoinQ2oP/0xlvKwJg6Ey8fHZF0qv8VOskE80zoLF hMazU3xfqLA+1TQvouW1YBxt3jwS3t1Ehs+NrV+nY9Yzcm0MzRX/n3fASJVe7nRr oqWWQU+voYl5Pw1xsfdp6C8IXpBQorpYby3Vp0MAMoZyl2W2YrNo36NV488wM9KC jD4HF5Z6xpnPSZTRR7AgW9mo7FdAtxPeKJ76Bch7lH8U6omT7n36WqTw+5B1eAYU YTOvrjRs294oqmWE+LeebyiOOXhH/yEYx4JNQgCwPdxwnRiGJWKsk5va0hRApqF/ WW8dIqdEnjsa84lCuxnmWgbcPK8cgmlO0rT0DyneACCldNlldCW1LJ0HOwLk9pea p3JFAsBL7TKue4Tos6I7/4rx1ufyBGGIigqw9/VX5g0Iif+3BhWnqKRfz+p9wiMa Fl7cU6u7yC68CHu1HBSisK16cYMCPeOnTSd89upHj8JU/t74O6k/ARvjrQ9qmNUt c5U+OY+WpNJ1nXQydhY/yIDhFdYg8SSpNuIO90r4L8/8jRQYXNG80FDd1UtvVDuy eq0r2yZ8C0XHSlOT9QHaua/tWV/aaKtyC/c0hDRrigfUrq8UOlGujMXbUnrmrWJI tLJLAc7ePWAAoZXGSHrt0U27l029GzLwRdKqJ6kkDANVnTeOdV+mmBg9zGh3/Mp6 agiwdHUMVN7X =56WK -----END PGP SIGNATURE----- Merge tag 'modules-6.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux Pull module updates from Luis Chamberlain: "The summary of the changes for this pull requests is: - Song Liu's new struct module_memory replacement - Nick Alcock's MODULE_LICENSE() removal for non-modules - My cleanups and enhancements to reduce the areas where we vmalloc module memory for duplicates, and the respective debug code which proves the remaining vmalloc pressure comes from userspace. Most of the changes have been in linux-next for quite some time except the minor fixes I made to check if a module was already loaded prior to allocating the final module memory with vmalloc and the respective debug code it introduces to help clarify the issue. Although the functional change is small it is rather safe as it can only *help* reduce vmalloc space for duplicates and is confirmed to fix a bootup issue with over 400 CPUs with KASAN enabled. I don't expect stable kernels to pick up that fix as the cleanups would have also had to have been picked up. Folks on larger CPU systems with modules will want to just upgrade if vmalloc space has been an issue on bootup. Given the size of this request, here's some more elaborate details: The functional change change in this pull request is the very first patch from Song Liu which replaces the 'struct module_layout' with a new 'struct module_memory'. The old data structure tried to put together all types of supported module memory types in one data structure, the new one abstracts the differences in memory types in a module to allow each one to provide their own set of details. This paves the way in the future so we can deal with them in a cleaner way. If you look at changes they also provide a nice cleanup of how we handle these different memory areas in a module. This change has been in linux-next since before the merge window opened for v6.3 so to provide more than a full kernel cycle of testing. It's a good thing as quite a bit of fixes have been found for it. Jason Baron then made dynamic debug a first class citizen module user by using module notifier callbacks to allocate / remove module specific dynamic debug information. Nick Alcock has done quite a bit of work cross-tree to remove module license tags from things which cannot possibly be module at my request so to: a) help him with his longer term tooling goals which require a deterministic evaluation if a piece a symbol code could ever be part of a module or not. But quite recently it is has been made clear that tooling is not the only one that would benefit. Disambiguating symbols also helps efforts such as live patching, kprobes and BPF, but for other reasons and R&D on this area is active with no clear solution in sight. b) help us inch closer to the now generally accepted long term goal of automating all the MODULE_LICENSE() tags from SPDX license tags In so far as a) is concerned, although module license tags are a no-op for non-modules, tools which would want create a mapping of possible modules can only rely on the module license tag after the commit8b41fc4454
("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"). Nick has been working on this *for years* and AFAICT I was the only one to suggest two alternatives to this approach for tooling. The complexity in one of my suggested approaches lies in that we'd need a possible-obj-m and a could-be-module which would check if the object being built is part of any kconfig build which could ever lead to it being part of a module, and if so define a new define -DPOSSIBLE_MODULE [0]. A more obvious yet theoretical approach I've suggested would be to have a tristate in kconfig imply the same new -DPOSSIBLE_MODULE as well but that means getting kconfig symbol names mapping to modules always, and I don't think that's the case today. I am not aware of Nick or anyone exploring either of these options. Quite recently Josh Poimboeuf has pointed out that live patching, kprobes and BPF would benefit from resolving some part of the disambiguation as well but for other reasons. The function granularity KASLR (fgkaslr) patches were mentioned but Joe Lawrence has clarified this effort has been dropped with no clear solution in sight [1]. In the meantime removing module license tags from code which could never be modules is welcomed for both objectives mentioned above. Some developers have also welcomed these changes as it has helped clarify when a module was never possible and they forgot to clean this up, and so you'll see quite a bit of Nick's patches in other pull requests for this merge window. I just picked up the stragglers after rc3. LWN has good coverage on the motivation behind this work [2] and the typical cross-tree issues he ran into along the way. The only concrete blocker issue he ran into was that we should not remove the MODULE_LICENSE() tags from files which have no SPDX tags yet, even if they can never be modules. Nick ended up giving up on his efforts due to having to do this vetting and backlash he ran into from folks who really did *not understand* the core of the issue nor were providing any alternative / guidance. I've gone through his changes and dropped the patches which dropped the module license tags where an SPDX license tag was missing, it only consisted of 11 drivers. To see if a pull request deals with a file which lacks SPDX tags you can just use: ./scripts/spdxcheck.py -f \ $(git diff --name-only commid-id | xargs echo) You'll see a core module file in this pull request for the above, but that's not related to his changes. WE just need to add the SPDX license tag for the kernel/module/kmod.c file in the future but it demonstrates the effectiveness of the script. Most of Nick's changes were spread out through different trees, and I just picked up the slack after rc3 for the last kernel was out. Those changes have been in linux-next for over two weeks. The cleanups, debug code I added and final fix I added for modules were motivated by David Hildenbrand's report of boot failing on a systems with over 400 CPUs when KASAN was enabled due to running out of virtual memory space. Although the functional change only consists of 3 lines in the patch "module: avoid allocation if module is already present and ready", proving that this was the best we can do on the modules side took quite a bit of effort and new debug code. The initial cleanups I did on the modules side of things has been in linux-next since around rc3 of the last kernel, the actual final fix for and debug code however have only been in linux-next for about a week or so but I think it is worth getting that code in for this merge window as it does help fix / prove / evaluate the issues reported with larger number of CPUs. Userspace is not yet fixed as it is taking a bit of time for folks to understand the crux of the issue and find a proper resolution. Worst come to worst, I have a kludge-of-concept [3] of how to make kernel_read*() calls for modules unique / converge them, but I'm currently inclined to just see if userspace can fix this instead" Link: https://lore.kernel.org/all/Y/kXDqW+7d71C4wz@bombadil.infradead.org/ [0] Link: https://lkml.kernel.org/r/025f2151-ce7c-5630-9b90-98742c97ac65@redhat.com [1] Link: https://lwn.net/Articles/927569/ [2] Link: https://lkml.kernel.org/r/20230414052840.1994456-3-mcgrof@kernel.org [3] * tag 'modules-6.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux: (121 commits) module: add debugging auto-load duplicate module support module: stats: fix invalid_mod_bytes typo module: remove use of uninitialized variable len module: fix building stats for 32-bit targets module: stats: include uapi/linux/module.h module: avoid allocation if module is already present and ready module: add debug stats to help identify memory pressure module: extract patient module check into helper modules/kmod: replace implementation with a semaphore Change DEFINE_SEMAPHORE() to take a number argument module: fix kmemleak annotations for non init ELF sections module: Ignore L0 and rename is_arm_mapping_symbol() module: Move is_arm_mapping_symbol() to module_symbol.h module: Sync code of is_arm_mapping_symbol() scripts/gdb: use mem instead of core_layout to get the module address interconnect: remove module-related code interconnect: remove MODULE_LICENSE in non-modules zswap: remove MODULE_LICENSE in non-modules zpool: remove MODULE_LICENSE in non-modules x86/mm/dump_pagetables: remove MODULE_LICENSE in non-modules ...
396 lines
9.4 KiB
C
396 lines
9.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2015 HiSilicon Limited, All Rights Reserved.
|
|
* Author: Jun Ma <majun258@huawei.com>
|
|
* Author: Yun Wu <wuyun.wu@huawei.com>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/irqchip.h>
|
|
#include <linux/module.h>
|
|
#include <linux/msi.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
|
|
/* Interrupt numbers per mbigen node supported */
|
|
#define IRQS_PER_MBIGEN_NODE 128
|
|
|
|
/* 64 irqs (Pin0-pin63) are reserved for each mbigen chip */
|
|
#define RESERVED_IRQ_PER_MBIGEN_CHIP 64
|
|
|
|
/* The maximum IRQ pin number of mbigen chip(start from 0) */
|
|
#define MAXIMUM_IRQ_PIN_NUM 1407
|
|
|
|
/*
|
|
* In mbigen vector register
|
|
* bit[21:12]: event id value
|
|
* bit[11:0]: device id
|
|
*/
|
|
#define IRQ_EVENT_ID_SHIFT 12
|
|
#define IRQ_EVENT_ID_MASK 0x3ff
|
|
|
|
/* register range of each mbigen node */
|
|
#define MBIGEN_NODE_OFFSET 0x1000
|
|
|
|
/* offset of vector register in mbigen node */
|
|
#define REG_MBIGEN_VEC_OFFSET 0x200
|
|
|
|
/*
|
|
* offset of clear register in mbigen node
|
|
* This register is used to clear the status
|
|
* of interrupt
|
|
*/
|
|
#define REG_MBIGEN_CLEAR_OFFSET 0xa000
|
|
|
|
/*
|
|
* offset of interrupt type register
|
|
* This register is used to configure interrupt
|
|
* trigger type
|
|
*/
|
|
#define REG_MBIGEN_TYPE_OFFSET 0x0
|
|
|
|
/**
|
|
* struct mbigen_device - holds the information of mbigen device.
|
|
*
|
|
* @pdev: pointer to the platform device structure of mbigen chip.
|
|
* @base: mapped address of this mbigen chip.
|
|
*/
|
|
struct mbigen_device {
|
|
struct platform_device *pdev;
|
|
void __iomem *base;
|
|
};
|
|
|
|
static inline unsigned int get_mbigen_vec_reg(irq_hw_number_t hwirq)
|
|
{
|
|
unsigned int nid, pin;
|
|
|
|
hwirq -= RESERVED_IRQ_PER_MBIGEN_CHIP;
|
|
nid = hwirq / IRQS_PER_MBIGEN_NODE + 1;
|
|
pin = hwirq % IRQS_PER_MBIGEN_NODE;
|
|
|
|
return pin * 4 + nid * MBIGEN_NODE_OFFSET
|
|
+ REG_MBIGEN_VEC_OFFSET;
|
|
}
|
|
|
|
static inline void get_mbigen_type_reg(irq_hw_number_t hwirq,
|
|
u32 *mask, u32 *addr)
|
|
{
|
|
unsigned int nid, irq_ofst, ofst;
|
|
|
|
hwirq -= RESERVED_IRQ_PER_MBIGEN_CHIP;
|
|
nid = hwirq / IRQS_PER_MBIGEN_NODE + 1;
|
|
irq_ofst = hwirq % IRQS_PER_MBIGEN_NODE;
|
|
|
|
*mask = 1 << (irq_ofst % 32);
|
|
ofst = irq_ofst / 32 * 4;
|
|
|
|
*addr = ofst + nid * MBIGEN_NODE_OFFSET
|
|
+ REG_MBIGEN_TYPE_OFFSET;
|
|
}
|
|
|
|
static inline void get_mbigen_clear_reg(irq_hw_number_t hwirq,
|
|
u32 *mask, u32 *addr)
|
|
{
|
|
unsigned int ofst = (hwirq / 32) * 4;
|
|
|
|
*mask = 1 << (hwirq % 32);
|
|
*addr = ofst + REG_MBIGEN_CLEAR_OFFSET;
|
|
}
|
|
|
|
static void mbigen_eoi_irq(struct irq_data *data)
|
|
{
|
|
void __iomem *base = data->chip_data;
|
|
u32 mask, addr;
|
|
|
|
get_mbigen_clear_reg(data->hwirq, &mask, &addr);
|
|
|
|
writel_relaxed(mask, base + addr);
|
|
|
|
irq_chip_eoi_parent(data);
|
|
}
|
|
|
|
static int mbigen_set_type(struct irq_data *data, unsigned int type)
|
|
{
|
|
void __iomem *base = data->chip_data;
|
|
u32 mask, addr, val;
|
|
|
|
if (type != IRQ_TYPE_LEVEL_HIGH && type != IRQ_TYPE_EDGE_RISING)
|
|
return -EINVAL;
|
|
|
|
get_mbigen_type_reg(data->hwirq, &mask, &addr);
|
|
|
|
val = readl_relaxed(base + addr);
|
|
|
|
if (type == IRQ_TYPE_LEVEL_HIGH)
|
|
val |= mask;
|
|
else
|
|
val &= ~mask;
|
|
|
|
writel_relaxed(val, base + addr);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct irq_chip mbigen_irq_chip = {
|
|
.name = "mbigen-v2",
|
|
.irq_mask = irq_chip_mask_parent,
|
|
.irq_unmask = irq_chip_unmask_parent,
|
|
.irq_eoi = mbigen_eoi_irq,
|
|
.irq_set_type = mbigen_set_type,
|
|
.irq_set_affinity = irq_chip_set_affinity_parent,
|
|
};
|
|
|
|
static void mbigen_write_msg(struct msi_desc *desc, struct msi_msg *msg)
|
|
{
|
|
struct irq_data *d = irq_get_irq_data(desc->irq);
|
|
void __iomem *base = d->chip_data;
|
|
u32 val;
|
|
|
|
if (!msg->address_lo && !msg->address_hi)
|
|
return;
|
|
|
|
base += get_mbigen_vec_reg(d->hwirq);
|
|
val = readl_relaxed(base);
|
|
|
|
val &= ~(IRQ_EVENT_ID_MASK << IRQ_EVENT_ID_SHIFT);
|
|
val |= (msg->data << IRQ_EVENT_ID_SHIFT);
|
|
|
|
/* The address of doorbell is encoded in mbigen register by default
|
|
* So,we don't need to program the doorbell address at here
|
|
*/
|
|
writel_relaxed(val, base);
|
|
}
|
|
|
|
static int mbigen_domain_translate(struct irq_domain *d,
|
|
struct irq_fwspec *fwspec,
|
|
unsigned long *hwirq,
|
|
unsigned int *type)
|
|
{
|
|
if (is_of_node(fwspec->fwnode) || is_acpi_device_node(fwspec->fwnode)) {
|
|
if (fwspec->param_count != 2)
|
|
return -EINVAL;
|
|
|
|
if ((fwspec->param[0] > MAXIMUM_IRQ_PIN_NUM) ||
|
|
(fwspec->param[0] < RESERVED_IRQ_PER_MBIGEN_CHIP))
|
|
return -EINVAL;
|
|
else
|
|
*hwirq = fwspec->param[0];
|
|
|
|
/* If there is no valid irq type, just use the default type */
|
|
if ((fwspec->param[1] == IRQ_TYPE_EDGE_RISING) ||
|
|
(fwspec->param[1] == IRQ_TYPE_LEVEL_HIGH))
|
|
*type = fwspec->param[1];
|
|
else
|
|
return -EINVAL;
|
|
|
|
return 0;
|
|
}
|
|
return -EINVAL;
|
|
}
|
|
|
|
static int mbigen_irq_domain_alloc(struct irq_domain *domain,
|
|
unsigned int virq,
|
|
unsigned int nr_irqs,
|
|
void *args)
|
|
{
|
|
struct irq_fwspec *fwspec = args;
|
|
irq_hw_number_t hwirq;
|
|
unsigned int type;
|
|
struct mbigen_device *mgn_chip;
|
|
int i, err;
|
|
|
|
err = mbigen_domain_translate(domain, fwspec, &hwirq, &type);
|
|
if (err)
|
|
return err;
|
|
|
|
err = platform_msi_device_domain_alloc(domain, virq, nr_irqs);
|
|
if (err)
|
|
return err;
|
|
|
|
mgn_chip = platform_msi_get_host_data(domain);
|
|
|
|
for (i = 0; i < nr_irqs; i++)
|
|
irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i,
|
|
&mbigen_irq_chip, mgn_chip->base);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void mbigen_irq_domain_free(struct irq_domain *domain, unsigned int virq,
|
|
unsigned int nr_irqs)
|
|
{
|
|
platform_msi_device_domain_free(domain, virq, nr_irqs);
|
|
}
|
|
|
|
static const struct irq_domain_ops mbigen_domain_ops = {
|
|
.translate = mbigen_domain_translate,
|
|
.alloc = mbigen_irq_domain_alloc,
|
|
.free = mbigen_irq_domain_free,
|
|
};
|
|
|
|
static int mbigen_of_create_domain(struct platform_device *pdev,
|
|
struct mbigen_device *mgn_chip)
|
|
{
|
|
struct device *parent;
|
|
struct platform_device *child;
|
|
struct irq_domain *domain;
|
|
struct device_node *np;
|
|
u32 num_pins;
|
|
|
|
for_each_child_of_node(pdev->dev.of_node, np) {
|
|
if (!of_property_read_bool(np, "interrupt-controller"))
|
|
continue;
|
|
|
|
parent = bus_get_dev_root(&platform_bus_type);
|
|
if (parent) {
|
|
child = of_platform_device_create(np, NULL, parent);
|
|
put_device(parent);
|
|
if (!child) {
|
|
of_node_put(np);
|
|
return -ENOMEM;
|
|
}
|
|
}
|
|
|
|
if (of_property_read_u32(child->dev.of_node, "num-pins",
|
|
&num_pins) < 0) {
|
|
dev_err(&pdev->dev, "No num-pins property\n");
|
|
of_node_put(np);
|
|
return -EINVAL;
|
|
}
|
|
|
|
domain = platform_msi_create_device_domain(&child->dev, num_pins,
|
|
mbigen_write_msg,
|
|
&mbigen_domain_ops,
|
|
mgn_chip);
|
|
if (!domain) {
|
|
of_node_put(np);
|
|
return -ENOMEM;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_ACPI
|
|
static const struct acpi_device_id mbigen_acpi_match[] = {
|
|
{ "HISI0152", 0 },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
|
|
|
|
static int mbigen_acpi_create_domain(struct platform_device *pdev,
|
|
struct mbigen_device *mgn_chip)
|
|
{
|
|
struct irq_domain *domain;
|
|
u32 num_pins = 0;
|
|
int ret;
|
|
|
|
/*
|
|
* "num-pins" is the total number of interrupt pins implemented in
|
|
* this mbigen instance, and mbigen is an interrupt controller
|
|
* connected to ITS converting wired interrupts into MSI, so we
|
|
* use "num-pins" to alloc MSI vectors which are needed by client
|
|
* devices connected to it.
|
|
*
|
|
* Here is the DSDT device node used for mbigen in firmware:
|
|
* Device(MBI0) {
|
|
* Name(_HID, "HISI0152")
|
|
* Name(_UID, Zero)
|
|
* Name(_CRS, ResourceTemplate() {
|
|
* Memory32Fixed(ReadWrite, 0xa0080000, 0x10000)
|
|
* })
|
|
*
|
|
* Name(_DSD, Package () {
|
|
* ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
|
|
* Package () {
|
|
* Package () {"num-pins", 378}
|
|
* }
|
|
* })
|
|
* }
|
|
*/
|
|
ret = device_property_read_u32(&pdev->dev, "num-pins", &num_pins);
|
|
if (ret || num_pins == 0)
|
|
return -EINVAL;
|
|
|
|
domain = platform_msi_create_device_domain(&pdev->dev, num_pins,
|
|
mbigen_write_msg,
|
|
&mbigen_domain_ops,
|
|
mgn_chip);
|
|
if (!domain)
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
}
|
|
#else
|
|
static inline int mbigen_acpi_create_domain(struct platform_device *pdev,
|
|
struct mbigen_device *mgn_chip)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
static int mbigen_device_probe(struct platform_device *pdev)
|
|
{
|
|
struct mbigen_device *mgn_chip;
|
|
struct resource *res;
|
|
int err;
|
|
|
|
mgn_chip = devm_kzalloc(&pdev->dev, sizeof(*mgn_chip), GFP_KERNEL);
|
|
if (!mgn_chip)
|
|
return -ENOMEM;
|
|
|
|
mgn_chip->pdev = pdev;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res)
|
|
return -EINVAL;
|
|
|
|
mgn_chip->base = devm_ioremap(&pdev->dev, res->start,
|
|
resource_size(res));
|
|
if (!mgn_chip->base) {
|
|
dev_err(&pdev->dev, "failed to ioremap %pR\n", res);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)
|
|
err = mbigen_of_create_domain(pdev, mgn_chip);
|
|
else if (ACPI_COMPANION(&pdev->dev))
|
|
err = mbigen_acpi_create_domain(pdev, mgn_chip);
|
|
else
|
|
err = -EINVAL;
|
|
|
|
if (err) {
|
|
dev_err(&pdev->dev, "Failed to create mbi-gen irqdomain\n");
|
|
return err;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, mgn_chip);
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id mbigen_of_match[] = {
|
|
{ .compatible = "hisilicon,mbigen-v2" },
|
|
{ /* END */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, mbigen_of_match);
|
|
|
|
static struct platform_driver mbigen_platform_driver = {
|
|
.driver = {
|
|
.name = "Hisilicon MBIGEN-V2",
|
|
.of_match_table = mbigen_of_match,
|
|
.acpi_match_table = ACPI_PTR(mbigen_acpi_match),
|
|
.suppress_bind_attrs = true,
|
|
},
|
|
.probe = mbigen_device_probe,
|
|
};
|
|
|
|
module_platform_driver(mbigen_platform_driver);
|
|
|
|
MODULE_AUTHOR("Jun Ma <majun258@huawei.com>");
|
|
MODULE_AUTHOR("Yun Wu <wuyun.wu@huawei.com>");
|
|
MODULE_DESCRIPTION("HiSilicon MBI Generator driver");
|