iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv6
History
Wang Hai e255e11e66 ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init 
kmemleak report a memory leak as follows:

unreferenced object 0xffff8880059c6a00 (size 64):
  comm "ip", pid 23696, jiffies 4296590183 (age 1755.384s)
  hex dump (first 32 bytes):
    20 01 00 10 00 00 00 00 00 00 00 00 00 00 00 00   ...............
    1c 00 00 00 00 00 00 00 00 00 00 00 07 00 00 00  ................
  backtrace:
    [<00000000aa4e7a87>] ip6addrlbl_add+0x90/0xbb0
    [<0000000070b8d7f1>] ip6addrlbl_net_init+0x109/0x170
    [<000000006a9ca9d4>] ops_init+0xa8/0x3c0
    [<000000002da57bf2>] setup_net+0x2de/0x7e0
    [<000000004e52d573>] copy_net_ns+0x27d/0x530
    [<00000000b07ae2b4>] create_new_namespaces+0x382/0xa30
    [<000000003b76d36f>] unshare_nsproxy_namespaces+0xa1/0x1d0
    [<0000000030653721>] ksys_unshare+0x3a4/0x780
    [<0000000007e82e40>] __x64_sys_unshare+0x2d/0x40
    [<0000000031a10c08>] do_syscall_64+0x33/0x40
    [<0000000099df30e7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

We should free all rules when we catch an error in ip6addrlbl_net_init().
otherwise a memory leak will occur.

Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Link: https://lore.kernel.org/r/20201124071728.8385-1-wanghai38@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-11-25 11:20:16 -08:00
..
ila
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
netfilter
ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module
2020-11-19 10:49:50 -08:00
addrconf_core.c
ipv6: add ipv6_fragment hook in ipv6_stub
2020-08-31 12:26:39 -07:00
addrconf.c
ipv6: Fix error path to cancel the meseage
2020-11-13 18:20:00 -08:00
addrlabel.c
ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init
2020-11-25 11:20:16 -08:00
af_inet6.c
ipv6: add ipv6_fragment hook in ipv6_stub
2020-08-31 12:26:39 -07:00
ah6.c
ah6: fix error return code in ah6_input()
2020-11-18 10:53:16 -08:00
anycast.c
ipv6: fix memory leaks on IPV6_ADDRFORM path
2020-07-30 16:30:55 -07:00
calipso.c
net/ipv6: use semicolons rather than commas to separate statements
2020-10-13 17:11:52 -07:00
datagram.c
icmp6: support rfc 4884
2020-07-24 17:12:41 -07:00
esp6_offload.c
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
esp6.c
xfrm: esp6: fix the location of the transport header with encapsulation
2020-07-28 07:57:23 +02:00
exthdrs_core.c
ipv6: remove printk
2019-07-27 14:23:48 -07:00
exthdrs_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
exthdrs.c
net: ipv6: kerneldoc fixes
2020-07-13 17:20:39 -07:00
fib6_notifier.c
net: fib_notifier: propagate extack down to the notifier block callback
2019-10-04 11:10:56 -07:00
fib6_rules.c
fib: use indirect call wrappers in the most common fib_rules_ops
2020-07-28 17:42:31 -07:00
fou6.c
net: Add MODULE_DESCRIPTION entries to network modules
2020-06-20 21:33:57 -07:00
icmp.c
IPv6: reply ICMP error if the first fragment don't include all headers
2020-10-31 13:16:02 -07:00
inet6_connection_sock.c
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2019-12-24 22:28:54 -08:00
inet6_hashtables.c
net: ipv6: remove unused arg exact_dif in compute_score
2020-08-31 13:08:10 -07:00
ip6_checksum.c
net: udp: fix handling of CHECKSUM_COMPLETE packets
2018-10-24 14:18:16 -07:00
ip6_fib.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-15 12:43:21 -07:00
ip6_flowlabel.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2020-08-05 20:13:21 -07:00
ip6_gre.c
ip6gre: avoid tx_error when sending MLD/DAD on external tunnels
2020-09-28 16:01:37 -07:00
ip6_icmp.c
ipv6: icmp6: avoid indirect call for icmpv6_send()
2020-06-19 13:41:59 -07:00
ip6_input.c
bpf: Add socket assign support
2020-03-30 13:45:04 -07:00
ip6_offload.c
udp: move gro declarations to net/udp.h
2020-06-23 20:10:15 -07:00
ip6_offload.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ip6_output.c
networking changes for the 5.10 merge window
2020-10-15 18:42:13 -07:00
ip6_tunnel.c
ip6_tunnel: set inner ipproto before ip6_tnl_encap
2020-10-30 08:07:30 -07:00
ip6_udp_tunnel.c
net: Make locking in sock_bindtoindex optional
2020-06-01 14:57:14 -07:00
ip6_vti.c
ipv6: use dev_sw_netstats_rx_add()
2020-10-06 06:23:21 -07:00
ip6mr.c
net/ipv6: switch ip6_mroute_setsockopt to sockptr_t
2020-07-24 15:41:54 -07:00
ipcomp6.c
ipcomp: assign if_id to child tunnel from parent tunnel
2020-07-09 12:55:37 +02:00
ipv6_sockglue.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-08-02 01:02:12 -07:00
Kconfig
net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC
2020-09-18 17:45:04 -07:00
Makefile
net: ipv6: add rpl sr tunnel
2020-03-29 22:30:57 -07:00
mcast_snoop.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 343
2019-06-05 17:37:07 +02:00
mcast.c
mld: fix memory leak in ipv6_mc_destroy_dev()
2020-06-15 13:29:39 -07:00
mip6.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
ndisc.c
net: Exempt multicast addresses from five-second neighbor lifetime
2020-11-13 14:24:39 -08:00
netfilter.c
netfilter: use actual socket sk rather than skb sk when routing harder
2020-10-30 12:57:39 +01:00
output_core.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
ping.c
ipv6/ping: set skb->mark on icmpv6 sockets
2020-07-03 14:36:04 -07:00
proc.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-06-07 11:00:14 -07:00
protocol.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
raw.c
csum_partial_copy_nocheck(): drop the last argument
2020-08-20 15:45:14 -04:00
reassembly.c
ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module
2020-11-19 10:49:50 -08:00
route.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-10-15 12:43:21 -07:00
rpl_iptunnel.c
net: ipv6: Use struct_size() helper and kcalloc()
2020-06-23 20:27:09 -07:00
rpl.c
ipv6: rpl: fix full address compression
2020-04-18 15:04:27 -07:00
seg6_hmac.c
crypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h
2020-05-08 15:32:17 +10:00
seg6_iptunnel.c
seg6_iptunnel: Refactor seg6_lwt_headroom out of uapi header
2020-08-03 17:57:40 -07:00
seg6_local.c
seg6: fix seg6_validate_srh() to avoid slab-out-of-bounds
2020-06-04 15:39:32 -07:00
seg6.c
seg6: fix seg6_validate_srh() to avoid slab-out-of-bounds
2020-06-04 15:39:32 -07:00
sit.c
IPv6: Set SIT tunnel hard_header_len to zero
2020-11-09 15:07:40 -08:00
syncookies.c
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-10 17:42:35 -08:00
sysctl_net_ipv6.c
ipv6: Fix sysctl max for fib_multipath_hash_policy
2020-09-02 15:44:53 -07:00
tcp_ipv6.c
tcp: Set ECT0 bit in tos/tclass for synack when BPF needs ECN
2020-11-24 14:12:55 -08:00
tcpv6_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tunnel6.c
tunnel6: add tunnel6_input_afinfo for ipip and ipv6 tunnels
2020-07-09 12:52:37 +02:00
udp_impl.h
net: pass a sockptr_t into ->setsockopt
2020-07-24 15:41:54 -07:00
udp_offload.c
net: udp: fix IP header access and skb lookup on Fast/frag0 UDP GRO
2020-11-12 09:55:51 -08:00
udp.c
udp, bpf: Ignore connections in reuseport group after BPF sk lookup
2020-07-31 02:00:48 +02:00
udplite.c
net/ipv6: remove compat_ipv6_{get,set}sockopt
2020-07-19 18:16:41 -07:00
xfrm6_input.c
xfrm: state: remove extract_input indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm6_output.c
xfrm: remove output_finish indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm6_policy.c
net: add bool confirm_neigh parameter for dst_ops.update_pmtu
2019-12-24 22:28:54 -08:00
xfrm6_protocol.c
xfrm: add support for UDPv6 encapsulation of ESP
2020-04-28 11:28:36 +02:00
xfrm6_state.c
xfrm: remove output_finish indirection from xfrm_state_afinfo
2020-05-06 09:40:08 +02:00
xfrm6_tunnel.c
xfrm: interface: fix the priorities for ipip and ipv6 tunnels
2020-10-09 12:29:48 +02:00